Code Review

🌱 ShiningPlague-adopted. Originally Donchitos (barebones stub); battle-tested on a shipped Godot project. Upstream was a pointer-only file; this version is the full implementation — director-gate dispatch, control-manifest cross-check, engine-specialist consult.

Architectural code review that validates implementation against design decisions, coding standards, and engine-specific patterns.

If an artifact named here is absent: say so plainly in one line, skip that step, and continue. Never invent the file to satisfy a checklist, and never fail a close because an optional artifact was never created.

Inputs

• Changed files — git diff or explicit file list
• Governing ADR(s) — from docs/adr/ (if the feature has one)
• Control manifest — docs/architecture/control-manifest.md

Procedure

1. Gather Context

• git diff --stat to identify scope of changes
• Read the governing ADR (if known) or grep docs/adr/ for related decisions
• Read docs/architecture/control-manifest.md for applicable rules
• Read .claude/docs/engine-notes/godot-gotchas.md for engine-specific patterns

2. Dispatch Lead Programmer

Spawn lead-programmer with gate LP-CODE-REVIEW from .claude/docs/director-gates.md. Pass: diff, ADR references, control manifest rules relevant to changed systems. Await verdict.

3. Check Against Control Manifest

For each changed file, identify which control manifest rules apply (rules are tagged by system/layer). Flag violations.

4. Check Architecture Principles

From CLAUDE.md:

• Data-driven? (no embedded data in scripts — JSON in data/)
• Tag-based? (no hardcoded per-location lists — use tag matching)
• Decomposed? (signals, not direct method calls — autoload singletons)
• Modular? (no assumed dependencies — check + degrade gracefully)
• Human-editable? (schema in data/_schemas/)
• Action-based? (player actions query tags, not hardcoded lists)

5. Engine-Specific Review

Spawn godot-gdscript-specialist for:

• Static typing enforcement
• Signal vs direct call patterns
• Resource class usage
• Performance patterns (avoid per-frame allocations, use @export over get_node)

6. Present Verdict

• APPROVE — ship it
• CONCERNS [list] — fix flagged items, then re-review
• REJECT [blockers] — architecture violation, needs redesign

Chain-Propose

After APPROVE → propose /verification-before-completion if not yet run. After APPROVE → propose commit + push (with drafted commit message). After CONCERNS/REJECT → revise the code, then re-run /code-review.

Project Paths

• Source: src/systems/, src/ui/, src/autoloads/
• Scenes: scenes/
• Addons: addons/
• ADRs: docs/adr/
• Control manifest: docs/architecture/control-manifest.md
• Engine gotchas: .claude/docs/engine-notes/godot-gotchas.md
• Director gates: .claude/docs/director-gates.md