agentleFS
storybookjsstorybookjs/storybook/.agents/skills/code-review/SKILL.md

code-review

Skill92k starsChanged 4 days agoMITView on GitHub

Reviews the changes since a fixed point (commit, branch or merge-base) on two axes, in parallel subagents. Standards: does the code follow this repo's guidelines? Spec: does it do what the issue asked? Use when the user asks to review a branch, a PR or work in progress, or to "review since X".

194 other projects use a version of this.

Trending

More talk lately.about the whole repository

Dec 2025: 0 mentionsJan 2026: 0 mentionsFeb 2026: 0 mentionsMar 2026: 0 mentionsApr 2026: 0 mentionsMay 2026: 2 mentionsJun 2026: 0 mentionsJul 2026: 0 mentionsAug 2026: 0 mentionsSep 2026: 1 mentionOct 2026: 2 mentionsNov 2026: 1 mention
Dec 2025Jun 2026Nov 2026
Mentions a month of the storybookjs/storybook repository that our weekly crawl found. There is no adoption data for this file yet.

Most recently taken up by

Who's talking about storybookjs/storybook

The biggest 5 of 89 mentions linking to the repository that our crawl found. Each line is their own headline.

See all 89

Talked about on Stack Overflow, YouTube, GitHub, Bluesky and Hacker News (89 times).

On Stack Overflow · 30

25 more on Stack Overflow

On YouTube · 25

20 more on YouTube

On GitHub · 19

14 more on GitHub

On Bluesky · 13

8 more on Bluesky

Used with

Projects with it also use close-spec, design-with-images and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • dzhngSkill

    close-spec

    When a spec under specs/<feature>/ is done shipping (a write-spec build, or any planned task that produced a spec), archive it to specs/done/ and rewrite it from a build-plan into a durable rationale — the why, the principles, the invariants — pointing back to the real code for the how. Use when implementation has landed and the plan no longer matches what shipped, or the user says a feature/spec is finished. Pairs with [write-spec](../write-spec/SKILL.md) (the plan this closes) and [review](../review/SKILL.md) (run before closing).

    Also in 5 projects that use this

  • dzhngSkill

    design-with-images

    Explore UI and visual design with image generation, then iterate the real implementation against the user-selected concept. Use when brainstorming visual directions, offering mockup variants, or implementing an approved generated design; do not stop at the mockups or the first code approximation.

    Also in 5 projects that use this

  • PydanticSkill

    add-new-model

    Add support for a newly-released language or image generation model in pydantic-ai (e.g. openai:gpt-5.6, anthropic:claude-sonnet-5, openai:gpt-image-2). Use when a provider ships a new model id and you need to wire literals, profile flags, adapters, and tests to recognize it. Handles SDK-lag, gateway list conventions, capability probing, and direct image-model geometry.

    Also in 9 projects that use this

  • transitive-bullshitSkill

    compare-screenshots

    Compare screenshots against the intended design, distinguishing approved references from historical baselines. Use for iterative implementation matching, before/after visual review, objective image telemetry, or checking a lone capture for flat, empty, or badly framed content.

    Also in 5 projects that use this

  • Microsoft AzureSkill

    azsdk-common-apiview-feedback-resolution

    Analyze and resolve APIView review feedback on Azure SDK PRs. **UTILITY SKILL**. USE FOR: APIView comments, API review feedback, SDK API surface changes. DO NOT USE FOR: general code review, non-APIView feedback. INVOKES: azure-sdk-mcp:azsdk_apiview_get_comments, azure-sdk-mcp:azsdk_customized_code_update, azure-sdk-mcp:azsdk_typespec_delegate_apiview_feedback, azure-sdk-mcp:azsdk_run_typespec_validation, azure-sdk-mcp:azsdk_package_generate_code.

    Also in 6 projects that use this

  • Microsoft AzureSkill

    azsdk-common-generate-sdk-locally

    Generate and finalize Azure SDKs locally from TypeSpec, including build, checks, tests, changelog, metadata, and version updates by default. WHEN: "generate SDK locally", "build SDK", "run SDK tests", "run CI checks", "validate package", "run checks", "update changelog", "fix SDK build errors", "resolve SDK generation errors", "customize TypeSpec", "rename SDK client", "rename SDK model", "hide operation from SDK", "fix analyzer errors", "resolve customization drift", "create subclient", "update metadata", "update version". INVOKES: azsdk_verify_setup, azsdk_package_generate_code, azsdk_package_build_code, azsdk_package_run_check, azsdk_package_run_tests, azsdk_customized_code_update, azsdk_package_update_changelog_content, azsdk_package_update_metadata, azsdk_package_update_version.

    Also in 6 projects that use this

  • +4 more from dzhng
  • +2 more from Azure

The file

We split this skill into the rules it gives an agent

2 rules. 0 are common, 1 is distinctive, and 1 is very specific to this project.

  • 0

    Common

    Most of the 183 edited versions we read keep these.

  • 1

    Distinctive

    This author's own choices. Worth a look.

  • 1

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Very specific:

    Pin the fixed point: Use the one the user gave.

    line 22
  2. Distinctive:

    When the user asks you to fix the findings, judge each one with the whole repo in view: fix the valid ones, and say why you leave the …

    line 36

“Common” is measured: kept by at least 6 in 10 of the 183 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Code review

Two axes, reported side by side:

  • Standards: does the change follow this repo's documented rules?
  • Spec: does the change do what the issue asked, and nothing else?

A change can pass one axis and fail the other. Each axis runs in its own subagent, so one cannot hide the other. Both follow the review rules.

Steps

  1. Pin the fixed point. Use the one the user gave. If there is none, use the merge-base with origin/next. Confirm it with git rev-parse. Record the diff command (git diff <fixed-point>...HEAD) and the commit list (git log --oneline <fixed-point>..HEAD). Stop here if the diff is empty.
  2. Find the spec. In this order: a spec file or the issue the user named; a Linear key (SB-1234) or Closes #N in the branch name, the commits or the PR body; the PR body itself. Fetch the issue with the Linear or GitHub tools, including its comments: a later comment can overrule the description. Write the spec to a temporary file, with the overruling decisions in a dated section at the top. The subagent cannot read the tracker. If there is no spec, the Spec axis reports "no spec".
  3. List the standards. The review rules, AGENTS.md, and each guideline in .agents/guidelines/ that the diff touches (the AGENTS.md table says which one owns which topic). Also any AGENTS.md or README in a changed package.
  4. Run both subagents in parallel, in the foreground. Each brief has the diff command, the commit list, and the section "Edge cases and guards" from the review rules, pasted in full.
    • Standards brief: the list from step 3. "For each place where the diff breaks a documented rule, cite the file and the rule, and quote the hunk. Mark each finding as a hard break or a judgement call. Skip what lint, format or type checks already enforce. At most 400 words."
    • Spec brief: the spec file. "Report: (a) what the spec asks for that is missing or partial; (b) behaviour in the diff the spec did not ask for; (c) what looks implemented but wrong. Quote the spec line for each finding. At most 400 words."
  5. Report. Show the two reports under ## Standards and ## Spec. Keep the axes apart: do not merge or rank findings across them. End with one line per axis: the number of findings and the worst one.

Done when both axes have reported, or the Spec axis has reported "no spec".

When the user asks you to fix the findings, judge each one with the whole repo in view: fix the valid ones, and say why you leave the others.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.