agentleFS
patonkikhpatonkikh/APES/skills/architecture/architecture-review/skill.md

architecture-review

Skill3 starsChanged 4 months agoMITView on GitHub

Conduct a structured architecture review against requirements, quality attributes, and best practices; produce findings with severity and remediation recommendations. Use when working on solution architecture, C4 diagrams, APIs, ADRs, or system design.

78 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use create-stories, story-done and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • lilangMaxSkill

    create-stories

    Break a single epic into implementable story files. Reads the epic, its GDD, governing ADRs, and control manifest. Each story embeds its GDD requirement TR-ID, ADR guidance, acceptance criteria, story type, and test evidence path. Run after /create-epics for each epic.

    Also in 11 projects that use this

  • lilangMaxSkill

    story-done

    End-of-story completion review. Reads the story file, verifies each acceptance criterion against the implementation, checks for GDD/ADR deviations, prompts code review, updates story status to Complete, and surfaces the next ready story from the sprint.

    Also in 11 projects that use this

  • +10 more from lilangMax

The file

We split this skill into the rules it gives an agent

1 rule. 0 are common, 1 is distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 70 edited versions we read keep these.

  • 1

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Use ATAM-inspired quality attribute review.

    line 118

“Common” is measured: kept by at least 6 in 10 of the 70 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
skill.md

Architecture Review

Purpose

Conduct a structured architecture review against requirements, quality attributes, and best practices; produce findings with severity and remediation recommendations.

Input: Solution architecture, context/container diagrams, ADRs (optional), PRD/NFRs
Output: Architecture Review Report with findings, risk rating, and action items Examples: See examples.md for worked input/output.


Workflow

Step 1: Establish review scope

Confirm artifacts under review:

  • Solution architecture document
  • C4 context and container diagrams
  • ADRs
  • PRD/NFRs as acceptance baseline

Define review focus: security, scalability, maintainability, cost, or full review.

Step 2: Check requirements traceability

FR/NFR IDAddressed byStatusGap

Flag unaddressed Must-have requirements.

Step 3: Evaluate quality attributes

Score each attribute (1–5) with evidence:

AttributeScoreEvidenceRisk

Attributes: security, scalability, availability, maintainability, operability, cost efficiency.

Step 4: Apply review checklist

Categories:

  • Security: auth, data protection, trust boundaries, secrets management
  • Resilience: failure modes, retries, circuit breakers, backup/recovery
  • Scalability: bottlenecks, stateless design, data partitioning
  • Maintainability: coupling, complexity, technology diversity
  • Operability: monitoring, logging, deployment, rollback

Step 5: Document findings

For each finding:

IDSeverityCategoryFindingRecommendationOwner

Severity: Critical | High | Medium | Low | Info

Step 6: Summarize and recommend

  • Overall risk rating: Green | Amber | Red
  • Go/no-go for implementation
  • Required actions before proceed

Step 7: Validate

Run Validation checklist.


Decision Rules

ConditionAction
No architecture artifactsStop; request solution-architecture output
Critical security findingOverall rating Red; block proceed until resolved
NFR not addressable by current designFlag as gap; recommend architecture revision
Finding without recommendationRewrite with specific remediation action
ADR contradicts implementationFlag ADR compliance issue

Validation

  • Review scope and artifacts listed
  • FR/NFR traceability matrix completed
  • All 6 quality attributes scored with evidence
  • ≥5 findings documented with severity
  • Every Critical/High finding has recommendation
  • Overall risk rating stated with rationale
  • Go/no-go recommendation explicit

Anti-patterns

  • Rubber stamp — all greens without evidence.
  • Style review — commenting on naming instead of architectural risks.
  • No prioritization — 50 Medium findings without severity ranking.
  • Missing NFR check — reviewing diagrams only, not requirements.
  • Vague recommendations — "improve security" without specific action.

Best Practices

  • Use ATAM-inspired quality attribute review.
  • Reference specific diagram elements in findings.
  • Link findings to ADRs when decision is needed.
  • Separate must-fix before launch vs post-launch improvements.
  • Include positive observations (architecture strengths).

Output Structure

# Architecture Review: [System Name]
**Date:** YYYY-MM-DD
**Reviewer:** [role]
**Scope:** [focus areas]

## Artifacts Reviewed
- [ ] Solution architecture
- [ ] System context
- [ ] Container diagram
- [ ] ADRs
- [ ] PRD/NFRs

## Requirements Traceability
| ID | Addressed | Gap |
|----|-----------|-----|

## Quality Attribute Scores
| Attribute | Score | Evidence |
|-----------|-------|----------|

## Findings
| ID | Severity | Category | Finding | Recommendation |
|----|----------|----------|---------|----------------|

## Strengths
- [Positive observation]

## Summary
**Overall risk:** Green | Amber | Red
**Recommendation:** Proceed | Proceed with conditions | Do not proceed

## Required Actions
| Priority | Action | Owner | Deadline |
|----------|--------|-------|----------|

Next Skills

OutcomeRecommended Skill
Fix architecture gapsarchitecture/solution-architecture
Document new decisionsarchitecture/adr-generator
Update diagramsarchitecture/container-diagram-builder
Design APIsarchitecture/api-designer
Return to product scopeproduct/prd-generator

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.