agentleFS
educlopezeduclopez/ui-craft/.agents/skills/finalize/SKILL.md

finalize

Skill441 starsChanged 3 months agoMITView on GitHub

Pre-ship gate — runs detector, verifies brief and tokens, applies the 10-pass finish bar, ranks findings by feedback hierarchy. Use when the user wants to ship, merge, or finalize a surface and needs a verdict (READY / NOT READY / BLOCKED) before committing. Invoke when the user asks for finalize on their UI, or mentions 'finalize' alongside design / UI / frontend work.

22 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use simplify, debug and 3 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • Hugging FaceSkill

    simplify

    Refactor code after tests pass. The "Refactor" phase of Red-Green-Refactor.

    Also in 3 projects that use this

  • AnthropicSkill

    debug

    Structured debugging session — reproduce, isolate, diagnose, and fix. Trigger with an error message or stack trace, "this works in staging but not prod", "something broke after the deploy", or when behavior diverges from expected and the cause isn't obvious.

    Also in 3 projects that use this

  • Microsoft AzureSkill

    verify

    End-to-end app testing pipeline for browser-based web apps on cloud browsers via Azure Playwright Workspaces: verify the live app, author tests for working flows, heal failing tests, then re-run with video and produce one consolidated report. Three phases (app verification, test authoring, test healing) plus a scoped final sanity run; each phase emits a sub-report. Use when asked to "verify my app", "make sure my app works and has good test coverage", "do a full QA pass", "add tests where I'm missing coverage", "fix failing tests and add new ones", "smoke test before deploy", "QA my deployment", or any combined verify-and-test ask. Requires Azure CLI (`az login`) and a Playwright Workspace resource ID — bootstraps configs on first invocation. Browser-based web apps with Playwright only — not for unit/API tests, native mobile/desktop, load/perf, or full accessibility audits.

    Also in 3 projects that use this

  • SentrySkill

    commit

    Create commit messages following Sentry conventions. Use when committing code changes, writing commit messages, or formatting git history. Follows conventional commits with Sentry-specific issue references.

    Also in 3 projects that use this

  • MicrosoftSkill

    handoff

    Compact the current conversation into a handoff document for another agent to pick up.

    Also in 3 projects that use this

The file

We split this skill into the rules it gives an agent

7 rules. 0 are common, 4 are distinctive, and 3 are very specific to this project.

  • 0

    Common

    Most of the 22 edited versions we read keep these.

  • 4

    Distinctive

    This author's own choices. Worth a look.

  • 3

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Very specific:

    Run npx ui-craft-detect on $ARGUMENTS (or current working surface if no argument).

    line 25
  2. Very specific:

    Craft Read recorded?: If a .ui-craft/spec.md section or session declared a Craft Read, verify the built surface matches it (theme, …

    line 49
  3. Distinctive:

    Copy self-audit: Read every visible string (headlines, eyebrows, buttons, captions, alt text, footer).

    line 61
  4. Very specific:

    If a finding conflicts with a recorded principle in brief.md: downgrade to "Deferred per brief" and cite the exact principle.

    line 84
  5. Distinctive:

    If any Value findings exist: surface them first in the report and add a standing recommendation to defer all Delight findings until Value …

    line 99
  6. Distinctive:

    If a tier has no findings, omit the section header entirely.

    line 132
  7. Distinctive:

    Do not edit any file. Do not propose code changes inline.

    line 146

“Common” is measured: kept by at least 6 in 10 of the 22 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md
<!-- HARNESS MIRROR — do not edit here. Canonical source: skills/ or commands/. After editing source, copy into cli/assets/<harness>/ and repo-root harness mirrors. -->

Context: this sub-skill is one lens of the broader ui-craft skill. If the ui-craft skill is also installed, read its SKILL.md first for Discovery + Anti-Slop + Craft Test, then apply the specific lens below.

Load the ui-craft skill. This command produces findings only — do NOT edit code.


Step 1 — Brief check (gate)

Look for .ui-craft/brief.md.

  • Absent: STOP. Output: "No brief found. Run /brief first. /finalize requires a design brief to distinguish intentional decisions from findings." Do not proceed.
  • Present: load it. Extract principles (numbered, in conflict-resolution order). These are the override registry for Steps 4–5.

Step 2 — Detector

Run npx ui-craft-detect on $ARGUMENTS (or current working surface if no argument).

Capture all output. Every Critical detector finding maps directly to a block-ship finding in the report. Preserve detector source labels.


Step 3 — Token check

Quick three-question audit (no deep read required):

  1. Are all three token layers present (primitives → semantic → component)?
  2. Are both light and dark modes explicitly authored (not inverted)?
  3. Are all seven token categories represented (color, spacing, radius, shadow, typography, motion, z-index)?

Any "no": flag as Major. Do not block ship. Append a recommendation: "Run /tokens to close the gap at [category]."


Step 3b — Craft-intent check (full surfaces only)

Applies only when the target is a complete surface (dashboard, landing, auth, settings shell, portfolio) — skip for single components.

  1. Signature bet present? Scan for exactly one memorable decision from references/craft-intent.md §3 (product / auth / marketing lists). Zero → Major ("no signature — surface is competent but anonymous; run /bolder or /polish"). Two or more competing → Major ("signature bets stack — keep the strongest, cut the rest").
  2. Variance matches surface? Layout risk visibly inconsistent with the surface's DESIGN_VARIANCE default (e.g. experimental asymmetry on an auth form, or a landing that is one centered symmetric column) → Major, unless the brief or spec records the deviation.
  3. Craft Read recorded? If a .ui-craft/spec.md section or session declared a Craft Read, verify the built surface matches it (theme, variance, signature). Mismatch → Major with the specific delta.

These findings are Major, never Critical — they gate NOT READY, not BLOCKED.


Step 3c — Copy self-audit + mechanical counts (marketing surfaces only)

Applies to landings, portfolios, and campaign pages — skip for product shells.

Load references/recipe-landing.md and run its Acceptance-bar mechanical checks against the built surface — thresholds (eyebrow count, layout-family budget, hero discipline) live there, not here; this step only names which checks apply and where a violation lands.

  1. Copy self-audit. Read every visible string (headlines, eyebrows, buttons, captions, alt text, footer). Grammatically broken copy, unclear referents, forced-clever labels ("Field notes" over testimonials, "Quietly trusted by"), or fake-precise numbers with no source → Major per references/copy.md Copy Self-Audit.
  2. Eyebrow count (mechanical) — per references/recipe-landing.md Eyebrow budget. Over budget → Major ("eyebrow flood — delete labels until the count passes").
  3. Layout-family count (mechanical) — per references/recipe-landing.md Layout-family budget. Any repeat or consecutive-split overrun → Major.
  4. CTA intent (mechanical) — per references/copy.md CTAs & Buttons (one label per intent; CTA fits one line at desktop). Violation → Major.
  5. Hero discipline — per references/recipe-landing.md Hero discipline. Over budget → Major.

Step 4 — Finish bar

Load references/finish-bar.md. Run all 10 passes in document order. Do not reorder.

Knob behavior (apply before running):

  • CRAFT_LEVEL ≤ 6 AND user did not explicitly invoke /finalize: run Passes 1, 6, 8 only; mark remaining as N/A (knob-gated).
  • CRAFT_LEVEL ≥ 7 OR user explicitly invoked /finalize: run all 10 passes.
  • MOTION_INTENSITY ≤ 3: Pass 7 = motion-gap audit only; do not fail on absent entrance animations.
  • VISUAL_DENSITY ≥ 8 AND brief documents compressed rhythm: Pass 4 accepts compressed spacing values.

For each pass:

  • Collect findings.
  • Assign severity per the severity map in finish-bar.md (Critical / Major / Minor).
  • If a finding conflicts with a recorded principle in brief.md: downgrade to "Deferred per brief" and cite the exact principle. If no brief principle covers it, it remains a finding regardless.
  • Record file:line when available.

Step 5 — Feedback hierarchy filter

Load references/review.md Feedback Hierarchy section.

Group all findings (detector + token + finish-bar) into three tiers:

  • Value — does the surface solve the problem the brief defines?
  • Ease of Use — can the user accomplish the primary task?
  • Delight — is it polished?

If any Value findings exist: surface them first in the report and add a standing recommendation to defer all Delight findings until Value findings are resolved. This prevents polish work masking broken functionality.


Step 6 — Output

Print this report. Do not add preamble.

## Finalize report — <surface name>

**Ship verdict:** READY / NOT READY / BLOCKED

> BLOCKED = any Critical finding present.
> NOT READY = any Major finding present, no Critical.
> READY = zero Critical, zero Major (Minor explicitly accepted).

### Block-ship findings (must fix before merge)
- [Pass / detector source] — [finding] — [file:line if available]

### Major findings (fix or defer with recorded reason)
- [...]

### Minor findings (polish; ship-okay if explicitly accepted)
- [...]

### Deferred per brief
- [finding] — [principle from brief.md that defers it]

### Recommended next actions
- [ordered, 3–5 items max]

If a tier has no findings, omit the section header entirely.


Step 6b — Convergence mode (explicit opt-in only)

Convergence mode activates ONLY when the user explicitly says "run in convergence mode", "converge until the bar passes", or uses a --converge flag. A vague "keep going", "fix it", or "make it pass" does NOT trigger convergence — the default remains findings-only (Step 7 hard-stop applies).

When explicitly triggered: load skills/ui-craft/references/loops.md and run preset visual-anti-slop (budget the default loop budget defined in loops.md, hard cap 5). Emit the pre-flight cost notice before iteration 1. After each single highest-impact fix, re-run finalize Steps 2–6 (this command's own steps) until READY or budget exhausted. Note: finalize's findings-only hard-stop (Step 7) is lifted ONLY inside convergence mode — fixes are applied during iteration.


Step 7 — Hard stops

Do not edit any file. Do not propose code changes inline. The verdict is the output. If the user asks for fixes after reading the report, respond to that as a separate request.

Next step: Ship. If the gate is red, the findings name the pass to re-run — /polish, /harden or /clarify.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.