agentleFS
rpraharajrpraharaj/ai-sdlc/skills/review-change/SKILL.md

review-change

Skill0 starsChanged 18 days agoMITView on GitHub

Review a local or branch diff for bugs and engineering-bar failures. Use when the user wants a code review, review of uncommitted work, or a second look at a branch. Write structured findings. Do not edit product code.

29 other projects use a version of this, 1 of them edited.

Adopted by

Most recently taken up by

Used with

Projects with it also use plan-change, prepare-release and 1 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • BanKnightSkill

    plan-change

    将已完成 spec/design 的 change 拆成可执行 plan 与 tasks。用户要把设计落成执行计划、任务清单或实现步骤时使用。

    Also in 7 projects that use this

  • ShopifySkill

    prepare-release

    Prepare the changeset-release/main branch for release by syncing version.ts files and running pnpm install

    Also in 3 projects that use this

  • Microsoft AzureSkill

    release-notes

    Author and update release notes for Azure App Configuration libraries and providers. USE FOR: write release notes, add release note entry, update release notes, draft release notes, new version release notes, format release notes. DO NOT USE FOR: generating changelogs from git history, writing internal engineering notes.

    Also in 3 projects that use this

The file

We split this skill into the rules it gives an agent

4 rules. 0 are common, 4 are distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 25 edited versions we read keep these.

  • 4

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Read-only review of a diff.

    line 17
  2. Distinctive:

    If the diff is empty, stop.

    line 32
  3. Distinctive:

    If a shape-work / spec exists, report spec axis separately (missing / extra / wrong).

    line 44
  4. Distinctive:

    Write findings from references/review-template.md.

    line 46

“Common” is measured: kept by at least 6 in 10 of the 25 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Review change

Read-only review of a diff. Do not edit product source. Do not commit.

Is this the right skill?

SignalDo this instead
Delete-list / over-engineering onlylean-review
Merge gate with commandsready-to-merge
Architecture docreview-architecture

Required inputs

  • A diff: named PR/branch, or local staged+unstaged+untracked
  • AGENTS.md

If the diff is empty, stop. If it is huge, summarize by file and ask what to narrow.

Human decisions (do not invent)

  • Posting the review to a host (only if they asked and a host CLI already works)
  • Approving/requesting changes on the host

Procedure

  1. Collect the diff. Read changed files, not only hunks, when a finding depends on callers.
  2. Load ../engineering-bar/SKILL.md and ../engineering-bar/references/bar.md.
  3. Also look for incorrect behavior vs stated intent, missing tests (write-tests), authz (security-pass), over-engineering (lean-review — do not turn this into a delete-list).
  4. If a shape-work / spec exists, report spec axis separately (missing / extra / wrong).
  5. Severity: bug / suggestion / nit. Do not flood nits when there are bugs.
  6. Write findings from references/review-template.md. Empty Issues is valid after you read the diff.

Output

  • Path: reply, or a file if they asked
  • Template: references/review-template.md

Quality bar

  • Every issue has a file path
  • Product code was not edited
  • No invented findings
  • Spec is n/a if none exists

Done

Issue counts by severity. Do not implement fixes unless asked (implement-change / debug).

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.