Style Review Step

Step skill for the docs-orchestrator pipeline. Follows the step skill contract: parse args → dispatch agent → write output.

Arguments

• $1 — JIRA ticket ID (required)
• --base-path <path> — Base output path (e.g., .agent_workspace/proj-123)
• --format <adoc|mkdocs> — Documentation format (default: adoc)

Input

<base-path>/writing/

Output

<base-path>/style-review/review.md

Execution

1. Parse arguments

Extract the ticket ID, --base-path, and --format from the args string.

Set the paths:

OUTPUT_DIR="${BASE_PATH}/style-review"
OUTPUT_FILE="${OUTPUT_DIR}/review.md"
mkdir -p "$OUTPUT_DIR"

2. Determine source files

Read the writing step's sidecar at ${BASE_PATH}/writing/step-result.json to determine the writing mode and file list.

If the sidecar exists and mode is "update-in-place" with a non-empty files array:

Build a <SOURCE_FILES_BLOCK> listing the files explicitly:

**Source files** — review and edit each of these files:
- `/absolute/path/to/file1.adoc`
- `/absolute/path/to/file2.adoc`

**Edit files in place** at their current paths. Do NOT create copies or move files.

Otherwise (draft mode, missing sidecar, or empty files array):

Set DRAFTS_DIR="${BASE_PATH}/writing" and build the block as:

**Source files**: `<DRAFTS_DIR>/` — review and edit files at this location only.

**Edit files in place** at the source path above. Do NOT create copies or write to a drafts/ subfolder.

3. Dispatch agent

You MUST use the Agent tool to invoke the docs-reviewer subagent. Do NOT read the agent's markdown file or attempt to perform the agent's work yourself — the agent has a specialized system prompt and must run as an isolated subagent.

Select the prompt below based on the --format flag. Substitute <SOURCE_FILES_BLOCK> with the block built in step 2.

Agent tool parameters:

• subagent_type: docs-skills:docs-reviewer
• description: Review documentation for <TICKET>
• run_in_background: false (the orchestrator must wait for the reviewer to finish before verifying output)

Prompt for AsciiDoc (--format adoc):

Review the AsciiDoc documentation drafts for ticket <TICKET>.

<SOURCE_FILES_BLOCK>

Report output: <OUTPUT_FILE> — you MUST save the review report to exactly this path. Do NOT write to any other location.

For each file:

1. Run Vale linting once (use the lint-with-vale skill)
2. Fix obvious errors where the fix is clear and unambiguous
3. Run documentation review skills:
   • Red Hat docs: docs-review-modular-docs, docs-review-content-quality
   • IBM Style Guide: ibm-sg-audience-and-medium, ibm-sg-language-and-grammar, ibm-sg-punctuation, ibm-sg-numbers-and-measurement, ibm-sg-structure-and-format, ibm-sg-references, ibm-sg-technical-elements, ibm-sg-legal-information
   • Red Hat SSG: rh-ssg-grammar-and-language, rh-ssg-formatting, rh-ssg-structure, rh-ssg-technical-examples, rh-ssg-gui-and-links, rh-ssg-legal-and-support, rh-ssg-accessibility, rh-ssg-release-notes (if applicable)
4. Skip ambiguous issues requiring broader context

After writing the report to <OUTPUT_FILE>, do NOT print the review contents. Print ONLY these four lines (counts let the orchestrator record style metrics without re-reading the report):

Written <OUTPUT_FILE>
Fixes applied: N
Warnings: N
Suggestions: N

Prompt for MkDocs (--format mkdocs):

Review the Material for MkDocs Markdown documentation drafts for ticket <TICKET>.

<SOURCE_FILES_BLOCK>

Report output: <OUTPUT_FILE> — you MUST save the review report to exactly this path. Do NOT write to any other location.

For each file:

1. Run Vale linting once (use the lint-with-vale skill)
2. Fix obvious errors where the fix is clear and unambiguous
3. Run documentation review skills:
   • Content quality: docs-review-content-quality
   • IBM Style Guide: ibm-sg-audience-and-medium, ibm-sg-language-and-grammar, ibm-sg-punctuation, ibm-sg-numbers-and-measurement, ibm-sg-structure-and-format, ibm-sg-references, ibm-sg-technical-elements, ibm-sg-legal-information
   • Red Hat SSG: rh-ssg-grammar-and-language, rh-ssg-formatting, rh-ssg-structure, rh-ssg-technical-examples, rh-ssg-gui-and-links, rh-ssg-legal-and-support, rh-ssg-accessibility
4. Skip ambiguous issues requiring broader context

After writing the report to <OUTPUT_FILE>, do NOT print the review contents. Print ONLY these four lines (counts let the orchestrator record style metrics without re-reading the report):

Written <OUTPUT_FILE>
Fixes applied: N
Warnings: N
Suggestions: N

Note: MkDocs review omits docs-review-modular-docs (AsciiDoc-specific) and rh-ssg-release-notes.

4. Verify output

After the agent completes, verify the review report exists and is non-empty:

test -f "$OUTPUT_FILE" && test -s "$OUTPUT_FILE" && echo "OK" || echo "MISSING_OR_EMPTY"

HARD GATE — if the file is missing or empty, do NOT write the sidecar or report completion. Treat this as a step failure. The orchestrator will handle the failure per its standard step-failure logic.

5. Write step-result.json

Do not hand-author the sidecar — a hand-written sidecar drifts from the schema and uses an orchestrator-delayed timestamp instead of a real wall-clock one. Run the script, passing the Fixes applied: N, Warnings: N, and Suggestions: N counts the docs-reviewer agent printed (do not re-read the full report to recount). Default any missing count to 0.

python3 ${CLAUDE_SKILL_DIR}/scripts/write_step_result.py \
  --ticket "<TICKET>" \
  --fixes <N> \
  --warnings <N> \
  --suggestions <N> \
  --sidecar "${OUTPUT_DIR}/step-result.json"

The script writes the conformant step-result.json with a real wall-clock completed_at. If the script exits non-zero, fix the arguments and re-run; do not substitute a stub.