agentleFS
nledfordnledford/engineering-review-board/skills/performance-review/SKILL.md

performance-review

Skill11 starsChanged 11 days agoMITView on GitHub

Review performance and scalability using workload, baseline, profiling, query-plan, rendering, concurrency, and resource evidence. Use for bottleneck audits, benchmark plans, capacity risks, or performance-sensitive changes; do not use for active unexplained regressions or implementation mechanics alone.

26 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use ci-cd-pipeline.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • nanvixSkill

    ci-cd-pipeline

    Guide for Nanvix CI and GitHub Actions workflow behavior, including local pipeline execution and matrix coverage. Use this when asked about CI checks, workflow failures, or release flow.

    Also in 3 projects that use this

The file

We split this skill into the rules it gives an agent

7 rules. 0 are common, 1 is distinctive, and 6 are very specific to this project.

  • 0

    Common

    Most of the 22 edited versions we read keep these.

  • 1

    Distinctive

    This author's own choices. Worth a look.

  • 6

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Very specific:

    Use this skill as a cross-stack review lens.

    line 8
  2. Very specific:

    Use systematic-debugging first when an active regression has not been reproduced or narrowed.

    line 13
  3. Very specific:

    When a performance-sensitive implementation needs a new local CPU-bound data or task decomposition, compose with parallelism-engineering …

    line 26
  4. Very specific:

    Do not route a benchmark, profile, scalability audit, or other evidence-only performance review to parallelism-engineering.

    line 33
  5. Very specific:

    When profiles, traces, logs, responses, or production evidence may expose secrets, credentials, PII, tenant data, payloads, or private …

    line 39
  6. Distinctive:

    Verify each finding against repository evidence and distinguish measured bottlenecks from plausible risks that still require an experiment.

    line 56
  7. Very specific:

    Before z.compile() or z.validate(), benchmark representative valid, invalid-with-diagnostics, boolean-validation, construction/reuse, …

    line 73

“Common” is measured: kept by at least 6 in 10 of the 22 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Performance Review

Use this skill as a cross-stack review lens. Always load review-verification-protocol before reporting findings. For repository changes, also load code-review.

Use systematic-debugging first when an active regression has not been reproduced or narrowed. Use language, runtime, browser, and SQL skills for implementation mechanics. Use observability-engineering when the work changes durable production signals, dashboards, alerts, or SLOs.

For photo/video DAM workloads, compose with digital-asset-management to define representative catalog sizes, media fixtures, rendition/cache states, and viewer workflows before measuring performance.

Local CPU Parallelism Routing

When a performance-sensitive implementation needs a new local CPU-bound data or task decomposition, compose with parallelism-engineering and the matching language owner. That skill owns partitioning, worker bounds, reductions, cancellation, and nested-parallelism design; this skill evaluates the workload, baseline, profiles, and resulting evidence.

Do not route a benchmark, profile, scalability audit, or other evidence-only performance review to parallelism-engineering; it remains here unless an implementation design actually changes. Routine async I/O, event-loop/runtime concurrency, and Spark/PySpark execution likewise remain with their existing runtime or data-platform owners rather than becoming local CPU-parallelism work.

When profiles, traces, logs, responses, or production evidence may expose secrets, credentials, PII, tenant data, payloads, or private paths, also load security-review and security-review-evidence. Keep raw artifacts local and ignored; report sanitized measurements and summaries only. This routing is unnecessary for non-sensitive evidence.

Workflow

  1. Define the supported workload, data size, traffic or concurrency shape, environment, user-visible impact, and target threshold.
  2. Establish a representative baseline from benchmarks, profiles, traces, browser measurements, query plans, production-safe telemetry, or reproducible timing. Label estimates and missing measurements explicitly.
  3. Identify the hot path and scaling variable before reviewing allocations, cloning, I/O, query count and shape, serialization, rendering, caching, contention, queueing, backpressure, and resource bounds.
  4. Verify each finding against repository evidence and distinguish measured bottlenecks from plausible risks that still require an experiment.
  5. Recommend the smallest change that addresses the demonstrated cause, plus the benchmark, load test, query-plan comparison, or runtime measurement that would prove the improvement and catch regressions.
  6. Report environment limits, skipped measurements, assumptions, tradeoffs, and residual capacity risk.

Output

Return prioritized findings with workload and baseline evidence, expected user or operational impact, a concrete remedy, a measurement plan, skipped checks, and residual risk. Do not claim an optimization without a way to compare before and after behavior.

Zod Hot-Path Evidence

Before z.compile() or z.validate(), benchmark representative valid, invalid-with-diagnostics, boolean-validation, construction/reuse, transform, depth, and async workloads. Load zod-engineering for version-specific limits.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.