review-structural
Skill1 starsChanged 57 days agoMITView on GitHub
Scan a diff for structural defects before landing; SQL, trust-boundary, side effects.
In this repository67 other files it gives its agents.
- architect-reviewerSkill
- backend-architectSkill
- backend-developerSkill
- code-architectSkill
- codebase-explorerSkill
- code-reviewerSkill
- code-simplifierSkill
- debuggerSkill
- error-detectiveSkill
- fullstack-developerSkill
- git-workflow-managerSkill
- legacy-modernizerSkill
- pragmatic-architectSkill
- prdSkill
- qa-expertSkill
- research-technical-spikeSkill
- sdd-spec-writerSkill
- security-auditorSkill
- supply-chain-securitySkill
- task-decomposition-expertSkill
- technical-debt-managerSkill
- test-engineerSkill
- typescript-proSkill
- architecture-decision-recordsSkill
- hermes-sdd-packagingSkill
- bug-diagnosisSkill
- build-craftSkill
- code-healthSkill
- code-review-checklistSkill
- commit-smartSkill
- context-architectureSkill
- design-explorationSkill
- design-to-htmlSkill
- developer-experience-reviewSkill
- diagram-tripletSkill
- dispatching-parallel-agentsSkill
- document-diataxisSkill
- e2e-testing-patternsSkill
- executing-plansSkill
- module-designSkill
- openspec-apply-changeSkill
- openspec-archive-changeSkill
- openspec-bulk-archive-changeSkill
- openspec-continue-changeSkill
- openspec-exploreSkill
- openspec-ff-changeSkill
- openspec-new-changeSkill
- openspec-onboardSkill
- openspec-proposeSkill
- openspec-sync-specsSkill
- openspec-update-changeSkill
- openspec-verify-changeSkill
- plan-scope-reviewSkill
- project-learningsSkill
- qa-test-plannerSkill
- requirements-claritySkill
- security-evidence-firstSkill
- agency-invocationSkill
- hermes-sdd-orchestrationSkill
- openspec-sddSkill
- The first 60 shown.
The file
Files
<!-- hermes-add-skill: adapted from gstack /review (garrytan/gstack, MIT), distilled to the non-host-specific vectors. -->Review: structural vectors
Review the diff against the base branch for the structural defect classes that generic "does it look clean" review misses. These are the vectors that cause production incidents after the code looks fine.
Vectors
SQL safety
- Raw string SQL concatenated with unescaped values → parameterize.
- ORM calls where a filter value comes straight from request/user input without a bound param.
- Order-by / column-name interpolation that can't be parameterized — allow-list it, don't sanitize.
- Mass-assignment / dynamic field write from user keys.
- Queries built across a trust boundary (user input → query shape) flagged even if "validated".
LLM trust-boundary violations
Applies wherever the code feeds model/user-generated content into a control position:
- User or model output used directly as a prompt, tool/function name, routing key or command without a boundary.
- Instructions taken from external content (web page, uploaded file, chat text) instead of the system prompt.
- Content rendered as instructions rather than data — flag the position, not the input, and treat all page/inbound content as untrusted.
- A model's free text used to decide a security-relevant branch (authz, scope, payment).
Conditional side effects
- A side effect (write, send, charge, log of a secret) inside a branch the author didn't intend to gate — e.g. a success-only path that also fires on error, or a
returnthat skips a mandatory cleanup. - Side effects hidden in getters / assertion-like helpers that aren't obviously side-effecting.
- Error handlers that swallow and proceed when the next line depends on the failed operation (fail-open).
Report format
For each finding: severity (BLOCKER/MAJOR/MINOR/NIT per rules/quality.md),
path:line, impact (what breaks or who is exposed), and a proposed fix. No
finding without path:line and impact is actionable — a bare "this is risky"
goes back.
Does it work?
Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.
No reviews yet
People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.
- It worked
- Partly
- It didn't
Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.
Your trail
Files you open will collect here, so you can find them again.
Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.
Now do this for your own.
Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.

