agentleFS
abevzabevz/devops-skills/skills/architecture-review/SKILL.md

architecture-review

Skill0 starsChanged 41 days agoMITView on GitHub

Use when reviewing the architecture of a repository or system for boundaries, coupling, and long-term maintainability. Mention "architecture review", "is this well structured", "review our system design" as triggers.

78 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use create-stories, story-done and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • lilangMaxSkill

    create-stories

    Break a single epic into implementable story files. Reads the epic, its GDD, governing ADRs, and control manifest. Each story embeds its GDD requirement TR-ID, ADR guidance, acceptance criteria, story type, and test evidence path. Run after /create-epics for each epic.

    Also in 11 projects that use this

  • lilangMaxSkill

    story-done

    End-of-story completion review. Reads the story file, verifies each acceptance criterion against the implementation, checks for GDD/ADR deviations, prompts code review, updates story status to Complete, and surfaces the next ready story from the sprint.

    Also in 11 projects that use this

  • +10 more from lilangMax

The file

We split this skill into the rules it gives an agent

11 rules. 0 are common, 10 are distinctive, and 1 is very specific to this project.

  • 0

    Common

    Most of the 70 edited versions we read keep these.

  • 10

    Distinctive

    This author's own choices. Worth a look.

  • 1

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Read package/service boundaries, interfaces, deployment dependencies, and the proposed diff.

    line 18
  2. Distinctive:

    Do not infer architecture from the directory tree alone.

    line 22
  3. Distinctive:

    Follow the Workflow, Safety rules, and Quality checklist below.

    line 26
  4. Distinctive:

    Use when reviewing a repository's or system's structure — module boundaries, service decomposition, dependency graph — rather than a single …

    line 36
  5. Distinctive:

    Check boundaries: does each component have a clear, single responsibility, or has scope crept across boundaries over time?

    line 47
  6. Distinctive:

    Check coupling: are components coupled through well-defined interfaces/APIs, or through shared mutable state, direct DB access across …

    line 49
  7. Distinctive:

    Check layering: does the dependency direction match the intended layering (e.g.

    line 51
  8. Distinctive:

    Check operational complexity: how many moving parts does a change here require touching?

    line 53
  9. Distinctive:

    Check future maintainability: what happens if this component needs to be replaced, scaled independently, or owned by a different team?

    line 55
  10. Very specific:

    If a migration is implied by the findings, sketch the migration path at a high level and point to the migration-plan skill for the detailed …

    line 57
  11. Distinctive:

    Do not propose a full rewrite as the default recommendation — prefer incremental, reversible steps.

    line 65

“Common” is measured: kept by at least 6 in 10 of the 70 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Architecture Review

TL;DR checklist

  • Map components and dependency direction.
  • Identify unclear boundaries, coupling, and shared mutable state.
  • Prioritize changes by operational and maintenance cost.

Key read-only checks

  • Read package/service boundaries, interfaces, deployment dependencies, and the proposed diff.

Common pitfalls

  • Do not infer architecture from the directory tree alone.

Agent procedure

Follow the Workflow, Safety rules, and Quality checklist below.

Quick references

  • Workflow below.

Last verified: unverified

When to use

Use when reviewing a repository's or system's structure — module boundaries, service decomposition, dependency graph — rather than a single diff.

Goal

Identify structural risks (tight coupling, unclear boundaries, operational complexity) that will slow the team down or cause outages as the system grows, with concrete evidence from the code.

Workflow

  1. Map the major components/services/packages and how they depend on each other.
  2. Check boundaries: does each component have a clear, single responsibility, or has scope crept across boundaries over time?
  3. Check coupling: are components coupled through well-defined interfaces/APIs, or through shared mutable state, direct DB access across services, or import cycles?
  4. Check layering: does the dependency direction match the intended layering (e.g. domain logic doesn't depend on infrastructure details)?
  5. Check operational complexity: how many moving parts does a change here require touching? How many services must be deployed together?
  6. Check future maintainability: what happens if this component needs to be replaced, scaled independently, or owned by a different team?
  7. If a migration is implied by the findings, sketch the migration path at a high level and point to the migration-plan skill for the detailed plan.
  8. Optionally sketch the component map as a diagram (e.g. with d2, if the user has it installed) to make coupling/boundary issues easier to see — text form is always sufficient, the diagram is a bonus.

Safety rules

  • Do not propose a full rewrite as the default recommendation — prefer incremental, reversible steps.
  • Ground every finding in actual code/config evidence (specific files, imports, or call paths), not general architectural opinions.
  • Acknowledge tradeoffs — flag when a "smell" was a deliberate, reasonable tradeoff for the team's constraints (team size, timeline, scale).

Output format

## Component map
<brief list of major components and their relationships>

## Boundary issues
## Coupling issues
## Layering issues
## Operational complexity concerns
## Migration path (if relevant)
<see migration-plan skill for a detailed rollout>

## What's working well

Quality checklist

  • Every finding cites specific code/config evidence, not just a general impression
  • Deliberate, reasonable tradeoffs are acknowledged rather than flagged as bugs
  • Recommendations favor incremental change over full rewrites
  • Operational complexity (deploy/on-call impact) was explicitly considered
  • "What's working well" is included, not just criticism

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.