agentleFS
ChristopherAlphonseChristopherAlphonse/calphonse-skills/qa-review/SKILL.md

qa-review

Skill1 starsChanged yesterdayMITView on GitHub

Run an extremely strict maintainability review of the author's own changes: abstraction quality, giant files, and spaghetti-condition growth. Use for a deep code quality audit, a strict QA review, or a harsh maintainability review of a diff or PR. Never reviews code the author did not touch.

14 other projects use a version of this.

Adopted by

Most recently taken up by

The file

We split this skill into the rules it gives an agent

4 rules. 0 are common, 4 are distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 11 edited versions we read keep these.

  • 4

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    If a pre-existing problem blocks a clean implementation, say so in one sentence tied to the author's change and recommend the smallest …

    line 21
  2. Distinctive:

    If the diff cannot be obtained, stop and ask.

    line 22
  3. Distinctive:

    Read the reference for each step when you reach it.

    line 26
  4. Distinctive:

    No findings about code the author did not change.

    line 40

“Common” is measured: kept by at least 6 in 10 of the 11 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

QA Review

An unusually strict review of the quality and maintainability of the code the author changed. Be ambitious about how the author's change is structured: look for "code judo" moves that keep behavior and make the change dramatically simpler, smaller, and more direct.

Scope: the author's changes only

Review what the author wrote or modified in this change. Nothing else.

  • Get the change set from the diff against the base branch. Every finding must point to a line the diff adds or modifies, or to code whose behavior the diff directly changes.
  • Never report a problem that already existed in code the author did not touch. This includes old spaghetti, oversized files, missing types, duplicated helpers, and outdated patterns. Do not mention them as "side notes", "while I was here", or "for a follow-up". Unbounded scope is the failure this rule prevents.
  • Touching a file does not put the whole file in scope. Only the changed lines, and what those lines do to their immediate surroundings, are in scope.
  • Read untouched code only to judge the author's change: to check whether a canonical helper already exists, whether a layer boundary is respected, or how the new code interacts with its callers. What you learn there is evidence for a finding about the author's code, never a finding in itself.
  • Suggested fixes must be edits to the author's own changes: simplify them, move them, split them, or replace them with an existing helper. Do not ask the author to refactor, rename, or clean up code they did not write in this change.
  • A change counts as making the surrounding code worse only when the diff itself introduced the problem, for example a new branch added to an existing function, or a file pushed over the size limit by the new lines.
  • If a pre-existing problem blocks a clean implementation, say so in one sentence tied to the author's change and recommend the smallest local workaround. Do not recommend fixing the pre-existing problem in this change.
  • If the diff cannot be obtained, stop and ask. Do not fall back to reviewing the whole codebase.

Steps

Read the reference for each step when you reach it. Do not load them all up front.

StepWhat you doRead
1. ScopeGet the diff against the base branch. Fix the set of changed lines.this file
2. StandardsApply the baseline prompt and the eight rules to the changed code.references/standards.md
3. InspectGo through the diff with the review questions. Flag what matches.references/flags.md
4. WriteTurn findings into direct, actionable comments with a remedy each.references/feedback.md
5. DecideApprove or block against the approval bar.references/approval.md

Output

  • Findings ordered by severity, each tied to a line the diff changed, with a concrete remedy.
  • A verdict: approve, or block with the presumptive blockers that apply.
  • No findings about code the author did not change.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.