sova-review-full
Skill3 starsChanged 8 days agoApache-2.0View on GitHub
Full pre-push pipeline (simplify changed code, review as senior engineer, organize commits). Run before the `sova-pr` skill.
In this repository44 other files it gives its agents.
- AGENTS.mdAGENTS.md
- templates/AGENTS.mdAGENTS.md
- CLAUDE.mdCLAUDE.md
- templates/CLAUDE.mdCLAUDE.md
- dashboard-designSkill
- database-patternsSkill
- design-systemSkill
- design-tasteSkill
- issue-templateSkill
- sova-address-prSkill
- sova-after-mergeSkill
- sova-agent-readinessSkill
- sova-audit-instructionsSkill
- sova-debugSkill
- sova-develop-explainSkill
- sova-develop-fullSkill
- sova-developSkill
- sova-extract-knowledgeSkill
- sova-find-taskSkill
- sova-health-auditSkill
- sova-ingest-reviewSkill
- sova-integrate-prSkill
- sova-issueSkill
- sova-new-featureSkill
- sova-optimize-knowledgeSkill
- sova-prSkill
- sova-rearrange-commitsSkill
- sova-researchSkill
- sova-review-prSkill
- sova-reviewSkill
- sova-simplifySkill
- sova-specSkill
- sova-standupSkill
- sova-statusSkill
- sova-testSkill
- sova-update-docsSkill
- testing-patternsSkill
- visual-auditSkill
- dashboard-designSkill
- database-patternsSkill
- design-tasteSkill
- issue-templateSkill
- testing-patternsSkill
- visual-auditSkill
The file
We split this skill into the rules it gives an agent
12 rules. About 0 are common, 8 are distinctive, and 4 are very specific to this project.
≈0
Common · estimate
Many files like this have a rule of this kind.
≈8
Distinctive · estimate
This author's own choices. Worth a look.
4
Very specific
Tied to their project's names, files or tools. Probably skip.
- Common
- Distinctive
- Very specific
- Distinctive: line 8
Run a complete pre-push quality pipeline: simplify code, review for issues, then organize commits into clean history.
- Very specific: line 14
Follow the sova-simplify skill workflow.
- Distinctive: line 36
If no simplifications are needed, state that and move on.
- Very specific: line 40
Follow the sova-review skill workflow:
- Very specific: line 44
Run the full CI-equivalent checks: make check.
- Distinctive: line 54
Create small, logical, atomic commits in dependency order.
- Distinctive: line 55
Verify: all changes committed, each commit atomic, total diff matches the backup branch.
- Very specific: line 77
After this command completes, run the sova-pr skill to create the pull request.
- Distinctive: line 86
All findings are addressed by default: fix or acknowledge with justification (false positive, not applicable, requires human decision).
- Distinctive: line 88
Do NOT reformat code that wasn't changed in this branch.
- Distinctive: line 89
If a simplification or fix is risky, flag it for human review instead of applying.
- Distinctive: line 91
NEVER use emojis in any output.
≈ “Common” is an estimate: at least 1 in 5 of the 364,980 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.
Files
Full Review Pipeline
Run a complete pre-push quality pipeline: simplify code, review for issues, then organize commits into clean history.
Scope: the arguments provided when this skill is invoked
Phase 1: Simplify
Follow the sova-simplify skill workflow. Review all changed code for opportunities to reduce complexity:
- Get the diff scope:
BASE=$(git symbolic-ref --short refs/remotes/origin/HEAD 2>/dev/null | sed 's#^origin/##') BASE=${BASE:-main} git fetch --quiet origin "$BASE" git diff "origin/$BASE"...HEAD --stat git diff --cached --stat git diff --stat - For each changed file, read the entire file and check:
- Code reuse: does new code duplicate existing utilities or helpers? Search the codebase.
- Over-engineering: unnecessary abstractions, premature generalization, excessive configurability
- Dead code: unused imports, unreachable branches, commented-out code
- Redundancy: repeated logic that could be a shared helper (only if 3+ occurrences)
- Complexity: can any function be simplified without losing clarity?
- Efficiency: redundant computations, repeated file reads, duplicate API calls
- Apply simplifications directly. After each change, verify tests still pass (see CLAUDE.md for commands).
- If no simplifications are needed, state that and move on.
Phase 2: Review
Follow the sova-review skill workflow:
- Review all changed files for bugs, security, performance, test coverage, consistency, doc freshness, and scout rule (fix pre-existing issues in touched files).
- Score each finding (1-10 priority). Address all findings (fix or acknowledge with justification).
- Run the full CI-equivalent checks:
make check. Fix any failures before proceeding. - Report findings in the standard review format.
See the sova-review skill for the full review checklist and scoring criteria.
Phase 3: Organize Commits
Follow the sova-rearrange-commits skill workflow:
- Snapshot uncommitted work as a WIP commit and create a backup branch, then soft reset to the fork point (
git merge-base HEAD "origin/$BASE"), exactly as thesova-rearrange-commitsskill Step 2 does. Never reset toorigin/$BASEitself: re-committing this branch's tree on top of a base that moved silently reverts everything the base gained. Never usegit stash: the stash stack is shared by every worktree and session. - Create small, logical, atomic commits in dependency order.
- Verify: all changes committed, each commit atomic, total diff matches the backup branch.
See the sova-rearrange-commits skill for the full commit organization process.
Phase 4: Summary
## Review-Full Summary
**Simplifications**: N changes applied
**Review findings**: N total (N fixed, N acknowledged)
**Commits**: reorganized into N clean commits
**Assessment**: ready to push / needs human reviewWorkflow Chain
This command orchestrates:
- Simplify: reduce complexity and duplication
- the
sova-reviewskill: senior-engineer code review with auto-fix - the
sova-rearrange-commitsskill: organize into logical commits
After this command completes, run the sova-pr skill to create the pull request.
Cross-References
- Came from: the
sova-develop-fullskill (as an alternative to its built-in Phase 2-3) or manual pre-push check - Next step: the
sova-prskill to create the pull request
Rules
- All findings are addressed by default: fix or acknowledge with justification (false positive, not applicable, requires human decision).
- Be thorough but not pedantic. Don't flag things that are correct and clear.
- Do NOT reformat code that wasn't changed in this branch.
- If a simplification or fix is risky, flag it for human review instead of applying.
- Each phase builds on the previous: Phase 2 reviews the state after Phase 1's changes.
- NEVER use emojis in any output.
Does it work?
Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.
No reviews yet
People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.
- It worked
- Partly
- It didn't
Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.
Your trail
Files you open will collect here, so you can find them again.
Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.
Now do this for your own.
Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.

