agentleFS
unlockers-aiunlockers-ai/unlockers-skills-library/skills/review-testing/SKILL.md

review-testing

Skill4 starsChanged 3 months agoMITView on GitHub

Review PR/MR changes for test quality and coverage against project testing standards. Use when reviewing a branch or pull request for whether its tests are well-written and cover the new code.

6 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use review-performance.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • MrCipherSmithSkill

    review-performance

    Use when a performance review is requested, checking for N+1 queries, unnecessary re-renders, memory leaks, missing indexes, large bundle imports, and synchronous blocking in changed code. NOT for security, logic correctness, style, or architecture.

    Also in 3 projects that use this

The file

We split this skill into the rules it gives an agent

3 rules. 0 are common, 3 are distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 4 edited versions we read keep these.

  • 3

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    No mocks — No fixed sleeps — Naming convention — Parametrize/table-drive appropriately

    line 34
  2. Distinctive:

    Check whether corresponding test coverage exists.

    line 39
  3. Distinctive:

    If the PR is a bug fix, verify a failing test was added (fails without the fix, passes with it).

    line 43

“Common” is measured: kept by at least 6 in 10 of the 4 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Testing Review Skill

Reviews PR changes to ensure tests meet project standards. Focus: does this PR maintain or improve our testing quality?

Rules: docs/testing-rules.md — Reviewer tips: docs/testing-review-guide.md

Protocol: docs/review-protocol.md — arguments, ref resolution, exhaustiveness, severity levels, report shape. Read it first. Its § 4 Be exhaustive is mandatory; the lens steps it refers to are steps 3–5 (Review test files, Review coverage, Check bug-fix discipline) below.

Process

  1. Resolve refs and gather the diff — per review-protocol.md.
  2. Split the diff into (a) new/modified test files, (b) new/modified production code.
  3. Review test files — check each against the criteria in the guide:
    • No mocks — No fixed sleeps — Naming convention — Parametrize/table-drive appropriately
    • Assert whole objects — No trivial tests — Short with clear intent.
  4. Review coverage — for each production file:
    • Identify public functions/methods/classes added or modified.
    • Check whether corresponding test coverage exists.
    • Flag untested code paths.
  5. Check bug-fix discipline
    • If the PR is a bug fix, verify a failing test was added (fails without the fix, passes with it).
  6. Confirm § 4 of the protocol is satisfied, then generate report → reviews/testing-review-issues.md

Output Format

# Testing Review: {branch-name}

**Compare:** {sha} ({ref})  ·  **Base:** {sha} ({ref})  ·  **Merge base:** {sha}

## Critical
### {N}. {title}
**Location:** {test_file}:{line}
**Issue:** …

## Major
### {N}. {title}
…

### Missing coverage

| Production File | Untested Code |
|-----------------|---------------|
| path/to/file    | `function_name()`, `ClassName.method()` |

## Minor
…

## Positive Observations
- {What was done well}

## Summary
{X} Critical, {Y} Major, {Z} Minor — overall assessment

Severity, per the protocol: Critical — a test that cannot fail, reaches the network, or asserts nothing about the change; Major — a rule of testing-rules.md broken, or a changed code path with no test when that path carries a business rule, a security guard or error handling that keeps or loses user data; Minor — naming, size or structure, and any other untested branch or surviving mutation. Without this bar the testing lens found new Majors on every one of nine rounds of one PR: there is always one more thing that could be pinned.

Example Usage

review-testing              # Current branch vs main
review-testing feat/foo     # Specific branch
review-testing feat/foo dev # Different base
review-testing 3574         # PR/MR by number

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.