review-testing
Skill4 starsChanged 3 months agoMITView on GitHub
Review PR/MR changes for test quality and coverage against project testing standards. Use when reviewing a branch or pull request for whether its tests are well-written and cover the new code.
6 other projects use a version of this.
Adopted by
Most recently taken up by
- dotnet/orleanstheir own version, first seen Nov 1, 2026
- AgnesAI-Labs/agnet-skills-cntheir own version, first seen Nov 1, 2026
- nesnilnehc/ai-cortextheir own version, first seen Oct 25, 2026
- apache/pinottheir own version, first seen Oct 8, 2026
- ba0918/claude-skillstheir own version, first seen Jul 9, 2026
- worldbank/geoPovLearntheir own version, first seen Jun 1, 2026
Used with
Projects with it also use review-performance.
Other files people use alongside this one.
Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
MrCipherSmithSkillreview-performance
Use when a performance review is requested, checking for N+1 queries, unnecessary re-renders, memory leaks, missing indexes, large bundle imports, and synchronous blocking in changed code. NOT for security, logic correctness, style, or architecture.
Also in 3 projects that use this
Other versions6 projects use a version of this.
Word for word · 0
None found.
Edited · 0
None found.
Wrote their own version · 6
- dotnet/orleans★ 11ksame name
- apache/pinot★ 6.2ksame name
- nesnilnehc/ai-cortex★ 8same name
- worldbank/geoPovLearn★ 2same name
- AgnesAI-Labs/agnet-skills-cn★ 1same name
- ba0918/claude-skills★ 0same name
How matches are found. Word for word: the exact same text. Edited: shares passages with this file (“99% same” means 99% of its five-word phrases also appear here; 10% or more counts). Their own version: similar meaning, or, weakest, the same name. We can’t tell which project had it first. Projects are counted among the 200 most-starred candidates, and mentions are links to the repository we found, up to 50 per site, so both counts are a floor.
In this repository19 other files it gives its agents.
- AGENTS.mdAGENTS.md
- adapter-contract-testingSkill
- azure-devops-prSkill
- bugszero-root-causeSkill
- legacy-3pSkill
- port-refactoringSkill
- quality-gateSkill
- review-ai-writingSkill
- review-allSkill
- review-architectureSkill
- review-complexitySkill
- review-driftSkill
- review-impactSkill
- review-prSkill
- review-securitySkill
- review-slopSkill
- scope-challengeSkill
- teams-local-messagesSkill
- write-testsSkill
The file
We split this skill into the rules it gives an agent
3 rules. 0 are common, 3 are distinctive, and 0 are very specific to this project.
0
Common
Most of the 4 edited versions we read keep these.
3
Distinctive
This author's own choices. Worth a look.
0
Very specific
Tied to their project's names, files or tools. Probably skip.
- Common
- Distinctive
- Very specific
- Distinctive: line 34
No mocks — No fixed sleeps — Naming convention — Parametrize/table-drive appropriately
- Distinctive: line 39
Check whether corresponding test coverage exists.
- Distinctive: line 43
If the PR is a bug fix, verify a failing test was added (fails without the fix, passes with it).
“Common” is measured: kept by at least 6 in 10 of the 4 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.
Files
Testing Review Skill
Reviews PR changes to ensure tests meet project standards. Focus: does this PR maintain or improve our testing quality?
Rules: docs/testing-rules.md —
Reviewer tips: docs/testing-review-guide.md
Protocol: docs/review-protocol.md — arguments, ref resolution, exhaustiveness, severity levels, report shape. Read it first.
Its § 4 Be exhaustive is mandatory; the lens steps it refers to are steps 3–5 (Review test files, Review coverage, Check bug-fix discipline) below.
Process
- Resolve refs and gather the diff — per
review-protocol.md. - Split the diff into (a) new/modified test files, (b) new/modified production code.
- Review test files — check each against the criteria in the guide:
- No mocks — No fixed sleeps — Naming convention — Parametrize/table-drive appropriately
- Assert whole objects — No trivial tests — Short with clear intent.
- Review coverage — for each production file:
- Identify public functions/methods/classes added or modified.
- Check whether corresponding test coverage exists.
- Flag untested code paths.
- Check bug-fix discipline
- If the PR is a bug fix, verify a failing test was added (fails without the fix, passes with it).
- Confirm § 4 of the protocol is satisfied, then generate report →
reviews/testing-review-issues.md
Output Format
# Testing Review: {branch-name}
**Compare:** {sha} ({ref}) · **Base:** {sha} ({ref}) · **Merge base:** {sha}
## Critical
### {N}. {title}
**Location:** {test_file}:{line}
**Issue:** …
## Major
### {N}. {title}
…
### Missing coverage
| Production File | Untested Code |
|-----------------|---------------|
| path/to/file | `function_name()`, `ClassName.method()` |
## Minor
…
## Positive Observations
- {What was done well}
## Summary
{X} Critical, {Y} Major, {Z} Minor — overall assessmentSeverity, per the protocol: Critical — a test that cannot fail, reaches the network,
or asserts nothing about the change; Major — a rule of
testing-rules.md broken, or a changed code path with no
test when that path carries a business rule, a security guard or error handling that
keeps or loses user data; Minor — naming, size or structure, and any other untested
branch or surviving mutation. Without this bar the testing lens found new Majors on every
one of nine rounds of one PR: there is always one more thing that could be pinned.
Example Usage
review-testing # Current branch vs main
review-testing feat/foo # Specific branch
review-testing feat/foo dev # Different base
review-testing 3574 # PR/MR by numberDoes it work?
Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.
No reviews yet
People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.
- It worked
- Partly
- It didn't
Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.
Your trail
Files you open will collect here, so you can find them again.
Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.
Now do this for your own.
Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.

