agentleFS
unlockers-aiunlockers-ai/unlockers-skills-library/skills/review-pr/SKILL.md

review-pr

Skill4 starsChanged 3 months agoMITView on GitHub

Perform a comprehensive code review of branch or pull-request changes — bugs, design, security, test coverage. Use when you want a broad review rather than the focused testing/complexity passes.

185 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use diagnose-ci-failures, review-delta and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • zerx-labSkill

    diagnose-ci-failures

    Diagnose CI failures for a PR using the GitHub CLI, extract error logs, and generate a plan to fix them. Use when the user asks to check CI status, pull CI issues, triage test failures, or investigate PR build failures.

    Also in 3 projects that use this

  • n24q02mSkill

    review-delta

    Review only changes since last commit using impact analysis. Token-efficient delta review with automatic blast-radius detection.

    Also in 3 projects that use this

  • GeiserXSkill

    docs-loop

    Use when the user asks to audit docs, check documentation for stale claims, or verify docs against the code.

    Also in 3 projects that use this

  • GeiserXSkill

    full-loop

    Drive a repository to done with sergio-loop, then keep improving it with refine-loop at a descending theta. Use only when the user explicitly invokes full-loop.

    Also in 3 projects that use this

  • n24q02mSkill

    build-graph

    Build or update the code review knowledge graph. Run this first to initialize, or let hooks keep it updated automatically.

    Also in 3 projects that use this

  • +7 more from GeiserX

The file

We split this skill into the rules it gives an agent

1 rule. 0 are common, 1 is distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 178 edited versions we read keep these.

  • 1

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Test quality (missing tests, weak assertions)

    line 67

“Common” is measured: kept by at least 6 in 10 of the 178 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Code Review Skill

Performs a comprehensive AI-powered code review of changes between refs. For deeper focused passes, also run review-complexity and review-testing.

Protocol: docs/review-protocol.md — arguments, ref resolution, exhaustiveness, severity levels, report shape. Read it first. Its § 4 Be exhaustive is mandatory; the lens steps it refers to are step 2 (Analyze changes) below.

Standards to review against, so a finding cites a rule rather than a preference: code-design-rules.md (types and exceptions), hexagonal-architecture-rules.md (where code goes — only where the codebase is actually hexagonal), testing-rules.md (what a test must look like), and the project's conventions doc for what it has already decided on purpose.

Process

  1. Resolve refs and gather the diff — per review-protocol.md.
  2. Analyze changes
    • Review all modified files for bugs, design issues, and quality problems.
    • Evaluate test coverage, identify security concerns, assess architectural decisions.
  3. Categorize issues by severity (Critical / Major / Minor — see criteria below).
  4. Confirm § 4 of the protocol is satisfied, then generate report → reviews/code-review-issues.md with file locations, line numbers, clear problem descriptions, concrete fixes, and summary statistics.

Review Criteria

Critical Issues

  • Logic errors and incorrect implementations
  • Security vulnerabilities
  • Breaking changes
  • Missing error handling for critical paths
  • Race conditions or concurrency bugs
  • Resource leaks

Major Issues

  • Architecture violations (layering, dependency direction)
  • Tight coupling between modules
  • Missing abstractions
  • Incomplete implementations
  • Significant performance concerns
  • Poor error-handling patterns

Minor Issues

  • Code duplication
  • Dead code
  • Inconsistent naming or patterns
  • Test quality (missing tests, weak assertions)
  • Missing documentation for complex logic
  • Minor performance optimizations

Exclusions

  • Style/formatting (assumed handled by linters)
  • Personal preferences without technical merit
  • Issues already flagged by automated tools

Output Format

# Code Review Issues: branch-name

## Critical Issues
### 1. Title
**Location:** path/to/file:123
**Issue:** Clear description
**Fix:** Concrete suggestion

## Major Issues
...

## Minor Issues
...

## Summary
- X Critical, Y Major, Z Minor issues
- Overall assessment and recommendations

Example Usage

review-pr              # Current branch vs main
review-pr feat/foo     # Specific branch
review-pr feat/foo dev # Different base
review-pr 3574         # PR/MR by number

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.