agentleFS
serhiilenivserhiileniv/ccs/skills/review/SKILL.md

review

Skill0 starsChanged 12 days agoMITView on GitHub

Read-only. Review a PR or branch for real bugs and rule violations: parallel finders in fresh context, one verifier per finding, only verified findings reported. Use before asking a human to review, or when asked to review a PR.

193 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use close-spec, design-with-images and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • dzhngSkill

    close-spec

    When a spec under specs/<feature>/ is done shipping (a write-spec build, or any planned task that produced a spec), archive it to specs/done/ and rewrite it from a build-plan into a durable rationale — the why, the principles, the invariants — pointing back to the real code for the how. Use when implementation has landed and the plan no longer matches what shipped, or the user says a feature/spec is finished. Pairs with [write-spec](../write-spec/SKILL.md) (the plan this closes) and [review](../review/SKILL.md) (run before closing).

    Also in 5 projects that use this

  • dzhngSkill

    design-with-images

    Explore UI and visual design with image generation, then iterate the real implementation against the user-selected concept. Use when brainstorming visual directions, offering mockup variants, or implementing an approved generated design; do not stop at the mockups or the first code approximation.

    Also in 5 projects that use this

  • LambenthanSkill

    daily-arxiv

    每日从 arXiv 拉取新论文,过滤相关性,auto-ingest 高优先级论文,检测 SOTA 更新

    Also in 5 projects that use this

  • LambenthanSkill

    exp-eval

    实验判决门:Review LLM 独立评判实验结果 → 4 种判决路径 → 自动更新 claims confidence、ideas status、graph edges

    Also in 5 projects that use this

  • +3 more from dzhng
  • +5 more from Lambenthan

The file

We split this skill into the rules it gives an agent

6 rules. 0 are common, 3 are distinctive, and 3 are very specific to this project.

  • 0

    Common

    Most of the 157 edited versions we read keep these.

  • 3

    Distinctive

    This author's own choices. Worth a look.

  • 3

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Very specific:

    Read-only: No edits, no commits, no push, no gh pr comment or review.

    line 13
  2. Very specific:

    Never approve or block: a human does.

    line 16
  3. Very specific:

    Run every command under REVIEW.md ## Checks, each with .

    line 35
  4. Distinctive:

    Every finder and verifier gets this list:

    line 67
  5. Distinctive:

    test coverage, unless a rule demands it

    line 74
  6. Distinctive:

    Not certain it is real → don't flag it.

    line 78

“Common” is measured: kept by at least 6 in 10 of the 157 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

/ccs:review

Report only what a verifier confirmed. A review people stop reading is worse than none.

The hard rule

Read-only. No edits, no commits, no push, no gh pr comment or review. Checks and tests that don't write are fine. The one write is this run's report.

Never approve or block: a human does. Fixes go to /ccs:implement.

Step 0 — scope

  • PR number → gh pr view <n> (title, body, base, draft) and gh pr diff <n>.
  • Branch or empty → git fetch, then diff origin/<base>...HEAD.
  • Base = the Base: line in REVIEW.md, else the repo default branch.
  • Empty diff → say so, stop. Draft → note it, continue.

Step 1 — rules

Collect paths, not contents:

  • root CLAUDE.md / AGENTS.md, plus any in a directory holding a changed file
  • REVIEW.md, read with git show origin/<base>:REVIEW.md: a PR can't relax its own review. Missing on base, present in the tree → use the tree copy and say so.

Step 2 — checks

Run every command under REVIEW.md ## Checks, each with ; echo "rc=$?" appended so the exit code is seen. Non-zero exit or non-empty output = a failed check, reported as fact, no verifier. Finders get the list and skip those subjects.

Step 3 — find

Launch finders in parallel, as subagents with fresh context: they never saw the code being written. Each gets only: the diff, PR title and body, rule paths, the do-not-flag list.

FinderLooks for
rulesA violation of a rule in the collected files. Must quote the exact rule and its path.
bugsFrom the diff alone: won't parse, compile or import; wrong for every input; a security hole provable from the changed lines.
one per ## Lenses itemThat item, in the changed code only.

Each finding: file:line, problem, trigger (the input or path that hits it), fix.

Step 4 — verify

One subagent per finding, in parallel. It reads the code around the finding and returns confirmed or rejected with evidence. A claim about behaviour needs a file:line citation, not an inference from a name. Rejected → dropped.

Step 5 — rank

Dedupe, then:

  • 🔴 Important: fix before merge
  • 🟡 Nit: worth fixing, not blocking. At most 5.
  • 🟣 Pre-existing: real, not introduced here; only when the diff touches that code

Do not flag

Every finder and verifier gets this list:

  • a pre-existing issue as 🔴
  • style or taste
  • anything a linter, type checker or CI catches
  • "might fail" without a concrete input that makes it fail
  • nits a senior engineer would skip
  • test coverage, unless a rule demands it
  • code silenced on purpose (noqa, lint-ignore)
  • anything under REVIEW.md ## Do not report

Not certain it is real → don't flag it.

REVIEW.md

Optional, at the reviewed repo's root. All sections optional.

# Review rules

Base: develop

## Checks
- `uv run ruff check src tests scripts`

## Lenses
- Docs chain: a change under `src/engine/` has its card and History line

## Do not report
- Generated files, lockfiles

## Cannot check
- Whether geometry is clinically right

Output

Review: <PR #n | branch> vs <base> · <files> files, +<a>/-<d>

Verdict: fix first | ready for human review

Checks: <n> run, <failed> failed
  ✗ <command> — <one line>

🔴 file.py:42 — <problem>
   Trigger: <input or path that hits it>
   Fix: <one line>
🟡 …
🟣 …

Dropped by verifier: <n>
Cannot check: <REVIEW.md ## Cannot check, verbatim, plus what this run could not see>

No findings → No issues found. Checked: <finders run>. fix first when any check failed or any 🔴 exists.

Writing

One line where one line does. Answer first. State the fact, not the story behind it — no narrating what was tried, no paragraph restating the line above. Two things always stay: why a non-obvious decision was made, and what a check cannot do. Caveats and risks still get said, one line each.

Outcome: success = review completed · partial = a step could not run (say which) · failed = no diff reviewed.

Report

Last step, every run, whatever the outcome: write .ccs/reports/<skill>/<YYYY-MM-DD>-<slug>.md at the repo root, and add .ccs/ to .git/info/exclude if missing. One line per field, no secrets, tokens or customer data. Print the path.

---
skill: <skill>
date: <YYYY-MM-DD>
repo: <owner/name>
target: <argument, one line>
outcome: success | partial | failed
learned: false
---

Used: <tools, CLIs, MCPs, files that did the work>
Found: <the result, one or two lines>
Friction: <what slowed or blocked it; a user correction; "none">

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.