agentleFS
diriendirien/yet-another-agent-harness/.claude/skills/review/SKILL.md

review

Skill19 starsChanged 8 months agoMITView on GitHub

Review code changes for quality, security, and correctness

192 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use close-spec, design-with-images and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • dzhngSkill

    close-spec

    When a spec under specs/<feature>/ is done shipping (a write-spec build, or any planned task that produced a spec), archive it to specs/done/ and rewrite it from a build-plan into a durable rationale — the why, the principles, the invariants — pointing back to the real code for the how. Use when implementation has landed and the plan no longer matches what shipped, or the user says a feature/spec is finished. Pairs with [write-spec](../write-spec/SKILL.md) (the plan this closes) and [review](../review/SKILL.md) (run before closing).

    Also in 5 projects that use this

  • dzhngSkill

    design-with-images

    Explore UI and visual design with image generation, then iterate the real implementation against the user-selected concept. Use when brainstorming visual directions, offering mockup variants, or implementing an approved generated design; do not stop at the mockups or the first code approximation.

    Also in 5 projects that use this

  • LambenthanSkill

    daily-arxiv

    每日从 arXiv 拉取新论文,过滤相关性,auto-ingest 高优先级论文,检测 SOTA 更新

    Also in 5 projects that use this

  • LambenthanSkill

    exp-eval

    实验判决门:Review LLM 独立评判实验结果 → 4 种判决路径 → 自动更新 claims confidence、ideas status、graph edges

    Also in 5 projects that use this

  • +3 more from dzhng
  • +5 more from Lambenthan

The file

We split this skill into the rules it gives an agent

4 rules. 0 are common, 3 are distinctive, and 1 is very specific to this project.

  • 0

    Common

    Most of the 156 edited versions we read keep these.

  • 3

    Distinctive

    This author's own choices. Worth a look.

  • 1

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    When the user runs /review or asks to review changes/PR.

    line 9
  2. Very specific:

    If a PR number is given: gh pr diff <number>

    line 14
  3. Distinctive:

    Read each changed file fully for context

    line 16
  4. Distinctive:

    Don't nitpick formatting if a linter is configured

    line 32

“Common” is measured: kept by at least 6 in 10 of the 156 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

/review — Code Review

When to use

When the user runs /review or asks to review changes/PR.

Steps

  1. Identify what to review:
    • If a PR number is given: gh pr diff <number>
    • Otherwise: git diff for unstaged, git diff --staged for staged
  2. Read each changed file fully for context
  3. Check for:
    • Security: injection, XSS, hardcoded secrets, OWASP top 10
    • Correctness: edge cases, off-by-one, null handling, race conditions
    • Quality: naming, complexity, duplication, dead code
    • Performance: N+1 queries, unnecessary allocations, missing indexes
    • Tests: adequate coverage, meaningful assertions
  4. Report findings grouped by severity:
    • CRITICAL: security issues, data loss risks
    • WARNING: bugs, correctness issues
    • SUGGESTION: style, refactoring opportunities

Rules

  • Be specific: reference file:line
  • Suggest fixes, don't just point out problems
  • Acknowledge what's done well
  • Don't nitpick formatting if a linter is configured

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.