agentleFS
renky1025renky1025/agent-skills/clean-code/SKILL.md

clean-code

Skill11 starsChanged 48 days agoMITView on GitHub

Knowledge base distilled from "Clean Code: A Handbook of Agile Software Craftsmanship" by Robert C. Martin (Uncle Bob): all 17 chapters plus a decision cheat sheet, a technique and pattern catalogue, a glossary, and a cross-language map. Use it to apply Uncle Bob's frameworks for meaningful names, small functions, comments, formatting, objects vs data structures, error handling, boundaries, unit tests / TDD, class design (SRP), systems, concurrency, refactoring, and code smells — while writing code, reviewing a diff, cleaning up, or doing TDD. Trigger phrases: clean code, 整洁代码, 代码整洁, 重构, refactor, 代码质量; naming, 命名, meaningful names, 变量名, 函数名, 命名规范; 函数设计, 小函数, do one thing, 函数拆分; 注释, comments, 该不该写注释; TDD, 单元测试, unit test, 测试驱动, clean tests; 异常处理, error handling, 异常设计; 代码味道, code smell, 坏味道, 反模式, code review; SRP, 面向对象, 类设计, 对象与数据结构, 并发.

108 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use intelligent-routing, nextjs-react-expert and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • SKB3002Skill

    intelligent-routing

    Automatic agent selection and intelligent task routing. Analyzes user requests and automatically selects the best specialist agent(s) without requiring explicit user mentions.

    Also in 5 projects that use this

  • SKB3002Skill

    nextjs-react-expert

    React and Next.js performance optimization from Vercel Engineering. Use when building React components, optimizing performance, eliminating waterfalls, reducing bundle size, reviewing code for performance issues, or implementing server/client-side optimizations.

    Also in 3 projects that use this

  • xfstudioSkill

    bash-pro

    Master of defensive Bash scripting for production automation, CI/CD

    Also in 4 projects that use this

  • xfstudioSkill

    code-refactoring-tech-debt

    You are a technical debt expert specializing in identifying, quantifying, and prioritizing technical debt in software projects. Analyze the codebase to uncover debt, assess its impact, and create acti

    Also in 4 projects that use this

  • flying-diceSkill

    clean-code-review

    Multi-agent clean code audit — each principle gets its own agent

    Also in 3 projects that use this

  • goca-seSkill

    batch-operations

    Apply a change safely across many files — refactors touching more than 5 files, library or API migrations, project-wide renames of symbols/imports/paths, or adding boilerplate to many files. Use when "do it all at once" risks context overflow or silent failures.

    Also in 3 projects that use this

  • +4 more from xfstudio

The file

We split this skill into the rules it gives an agent

6 rules. 0 are common, 4 are distinctive, and 2 are very specific to this project.

  • 0

    Common

    Most of the 101 edited versions we read keep these.

  • 4

    Distinctive

    This author's own choices. Worth a look.

  • 2

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Very specific:

    Read that one file; preloading references/ defeats the routing table.

    line 51
  2. Distinctive:

    Follow a chapter's cross-reference only when the question actually needs it.

    line 52
  3. Very specific:

    Read references/cheatsheet.md — it is the review lens.

    line 59
  4. Distinctive:

    Pass all tests: before any other design improvement — Simple Design rule 1 (Ch 12).

    line 107
  5. Distinctive:

    Stop once the routed file answers the question.

    line 115
  6. Distinctive:

    Do not chase a framework past the one linked chapter unless the user wants the derivation.

    line 116

“Common” is measured: kept by at least 6 in 10 of the 101 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Clean Code

Author: Robert C. Martin (Uncle Bob) | Pages: ~462 | Chapters: 17 | Generated: 2026-08-24

Purpose

A synthesised study aid for Clean Code: it maps every named framework, principle, anti-pattern, and heuristic in the book to a reference file, then routes a question or a review finding to the file that answers it. It produces grounded advice with chapter citations — not the book text, and not a linting tool.

When to Use

  • Naming, functions, comments, formatting, objects vs data structures, error handling, boundaries, tests/TDD, classes/SRP, systems, concurrency, refactoring, code smells.
  • A live review or cleanup where you must name why something is a smell and what to do.
  • Studying the book, or asking "what does Uncle Bob say about X".
  • Trigger phrases: 整洁代码, 重构, 代码质量, 命名, 函数设计, 注释, 代码味道, 反模式, 测试驱动; clean code, naming, TDD, error handling, code smell, code review, SRP.

When NOT to Use

  • Review-and-fix of a diff -> claude-simplify runs the review and applies fixes; this skill only supplies the justification the review cites.
  • Beyond the book — design patterns, architecture, framework idioms -> say it is out of scope; do not extrapolate book positions.
  • Untrusted third-party code safety -> skill-security-check.
  • Language tooling (linters, formatters, rule configs) -> not covered.

Workflow

A. Look something up

  1. Classify the question into a topic in the Decision Rules table.
  2. Read that one file; preloading references/ defeats the routing table.
  3. Follow a chapter's cross-reference only when the question actually needs it.
  4. Answer from the loaded content, citing chapter and heuristic ids (Ch 3, G5, F1).
  5. For a non-Java language, read references/appendix-lang-map.md and translate rather than quoting Java syntax.

B. Apply the book to a live code review

  1. Read references/cheatsheet.md — it is the review lens.
  2. Tag each diff finding with its C/E/F/G/J/N/T heuristic id; load references/chapters/ch17-smells-and-heuristics.md for tags absent from the cheat sheet.
  3. Name the fixing framework, then load the chapter that owns it via the routing table.
  4. Load references/patterns.md when the fix is a technique and you need its trade-offs.
  5. Report each finding as: id -> why -> fix -> citation.

Decision Rules

Route by topic; load exactly one row's file:

TopicFileTopicFile
Boy Scout Rule, LeBlanc's law, professionalismreferences/chapters/ch01-clean-code.mdClasses, SRP, cohesionreferences/chapters/ch10-classes.md
Naming: intent-revealing, no encodingsreferences/chapters/ch02-meaningful-names.mdSystems: construction vs use, DI, factoryreferences/chapters/ch11-systems.md
Functions: Do One Thing, step-down, CQS, argsreferences/chapters/ch03-functions.mdFour Rules of Simple Design, emergencereferences/chapters/ch12-emergence.md
Comments: good vs badreferences/chapters/ch04-comments.mdConcurrency: isolation, shared statereferences/chapters/ch13-concurrency.md
Formatting: newspaper metaphor, orderingreferences/chapters/ch05-formatting.mdArgs case study, festering pile, refinementreferences/chapters/ch14-successive-refinement.md
Objects vs data, Law of Demeterreferences/chapters/ch06-objects-and-data-structures.mdExtract Method, Collecting Parameterreferences/chapters/ch15-junit-internals.md
Errors, null, Special Casereferences/chapters/ch07-error-handling.mdenum over int, Feature Envy fix, factoryreferences/chapters/ch16-refactoring-serialdate.md
Boundaries, learning tests, adaptersreferences/chapters/ch08-boundaries.mdSmells (C/E/F/G/J/N/T), DRY, ONE SWITCHreferences/chapters/ch17-smells-and-heuristics.md
TDD three laws, F.I.R.S.T., BUILD-OPERATE-CHECKreferences/chapters/ch09-unit-tests.md

Cross-chapter topics: Demeter / Feature Envy -> ch06 + ch17; DRY -> ch12 + ch17; refactoring -> ch14 + ch16; Boy Scout Rule -> ch01 + ch15.

Other routing:

  • One-line definition only -> references/core-frameworks.md; escalate to the chapter after.
  • Concrete technique or pattern + trade-offs -> references/patterns.md.
  • A term you cannot place -> references/glossary.md, which names its chapter.
  • A "what should I decide" question -> references/cheatsheet.md.
  • Conflict between two answers -> apply Priority below.

Constraints

  • Never present this skill as the book's verbatim text. It is a study aid; attribute paraphrases as "the book's argument", never as a quotation.
  • Cite chapter and heuristic ids whenever you assert a principle.
  • Do not summarise detail away. One-liners orient only; when reasoning or edge cases matter, read the chapter and answer from it.
  • Principles are language-agnostic. Java examples are carriers, not the rule.
  • Stay in scope. Outside Clean Code, say so instead of inventing book positions.

Priority

When rules compete:

  1. Pass all tests before any other design improvement — Simple Design rule 1 (Ch 12).
  2. Then, in the book's order: remove duplication, polish expressiveness, minimise the number of classes/methods (Ch 12).
  3. Project conventions and language idioms override the Java-specific J-series heuristics.
  4. Name the smell before proposing the fix — an unnamed finding cannot be checked.

Stop Conditions

  • Stop once the routed file answers the question; never read all 17 chapters.
  • Do not chase a framework past the one linked chapter unless the user wants the derivation.
  • Topic outside the book -> stop and say so.

Verification

  • The answer cites at least one chapter or heuristic id.
  • Only the routed file(s) were loaded, not the whole references/ directory.
  • Non-Java requests were translated via references/appendix-lang-map.md.
  • Nothing is presented as a verbatim book quotation.
  • Review findings are reported as id -> why -> fix -> citation.

Output

  • Outcome: Clean Code guidance with chapter citations, or a coded review of a diff.
  • Done when: the question is classified, the routed reference was read, and the answer cites its source.
  • Evidence: the framework or smell id, its chapter, and the concrete change to make.

References

Load only when needed:

  • references/core-frameworks.md — read for a one-line definition before escalating.
  • references/cheatsheet.md — read first for any live review or "what should I decide" case.
  • references/glossary.md — read when a term is unfamiliar; it gives the owning chapter.
  • references/patterns.md — read when the fix needs a technique and its trade-offs.
  • references/appendix-lang-map.md — read before quoting Java syntax to a non-Java user.
  • references/chapters/ — read only the single chapter named by the routing table.

Related Skills

  • claude-simplify — runs a diff review and fixes findings; pair with this skill for the taxonomy behind each finding.
  • skill-security-check — pre-install safety review, a different concern.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.