agentleFS
qyndexqyndex/claude-init/.claude/skills/review/SKILL.md

review

Skill2 starsChanged 5 months agoMITView on GitHub

Run code review and (optionally) security review on the current diff. Phase 7 of the eight-phase workflow. Delegates to reviewer + security agents. Multi-pass — each finding is re-verified to filter false positives (Anthropic pattern).

192 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use close-spec, daily-arxiv and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • dzhngSkill

    close-spec

    When a spec under specs/<feature>/ is done shipping (a write-spec build, or any planned task that produced a spec), archive it to specs/done/ and rewrite it from a build-plan into a durable rationale — the why, the principles, the invariants — pointing back to the real code for the how. Use when implementation has landed and the plan no longer matches what shipped, or the user says a feature/spec is finished. Pairs with [write-spec](../write-spec/SKILL.md) (the plan this closes) and [review](../review/SKILL.md) (run before closing).

    Also in 5 projects that use this

  • LambenthanSkill

    daily-arxiv

    每日从 arXiv 拉取新论文,过滤相关性,auto-ingest 高优先级论文,检测 SOTA 更新

    Also in 5 projects that use this

  • dzhngSkill

    design-with-images

    Explore UI and visual design with image generation, then iterate the real implementation against the user-selected concept. Use when brainstorming visual directions, offering mockup variants, or implementing an approved generated design; do not stop at the mockups or the first code approximation.

    Also in 5 projects that use this

  • LambenthanSkill

    exp-eval

    实验判决门:Review LLM 独立评判实验结果 → 4 种判决路径 → 自动更新 claims confidence、ideas status、graph edges

    Also in 5 projects that use this

  • +5 more from Lambenthan
  • +3 more from dzhng

The file

We split this skill into the rules it gives an agent

3 rules. 0 are common, 3 are distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 156 edited versions we read keep these.

  • 3

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Re-verify each finding: before reporting (anti-false-positive pass).

    line 20
  2. Distinctive:

    Block /ship: if any blocker or high remains.

    line 22
  3. Distinctive:

    After save: "Review complete — <blocker> blockers, <high> highs.

    line 56

“Common” is measured: kept by at least 6 in 10 of the 156 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Review

Two-pass review on the current diff: code-quality first, security second.

Process

  1. Determine the diff — default to git diff main...HEAD. Override with --diff <ref>.
  2. Delegate to reviewer agent for code-quality review.
  3. Delegate to security agent for security review (always if --security, automatic if the diff touches auth/data/network/secrets/deps).
  4. Collate findings into a single severity-sorted list.
  5. Re-verify each finding before reporting (anti-false-positive pass).
  6. Post results as a structured comment (PR or chat).
  7. Block /ship if any blocker or high remains.

Trigger conditions for automatic security pass

  • Diff touches **/auth/**, **/login/**, **/session/**, **/token/**
  • Diff touches database queries (SQL files, ORM definitions, migrations)
  • Diff touches network code (fetch, axios, requests, http handlers)
  • Diff modifies package.json, requirements.txt, Cargo.toml, go.mod
  • Diff includes new env var reads
  • Diff includes user-input handlers (forms, parsing, deserialization)

Output

# Review — <feature> — <date>

## Code review
### Blockers (0)
### Highs (1)
- [H-1] login.ts:42 — race condition between session lookup and update; use SELECT FOR UPDATE.

### Mediums (2) / Lows (3) / Nits (5)
- ...

## Security review
### Critical (0)
### High (0)
### Medium (1)
- [M-1] User-controlled `redirect_uri` not allowlisted (open redirect). Fix: validate against config.

## Verdict
PASS-WITH-CHANGES — address H-1 and M-1 before /ship.

After save: "Review complete — <blocker> blockers, <high> highs. /ship blocked." OR "Review clean. Ready for /ship."

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.