agentleFS
pfeffpfeff/claude-skills/skills/review/SKILL.md

review

Skill3 starsChanged 3 months agoMITView on GitHub

Spawn parallel specialist review agents (security, simplicity, architecture, correctness) against a PR or branch diff. Synthesizes findings by severity. Use when the user requests a code review or invokes /claude-skills:review.

192 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use close-spec, design-with-images and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • dzhngSkill

    close-spec

    When a spec under specs/<feature>/ is done shipping (a write-spec build, or any planned task that produced a spec), archive it to specs/done/ and rewrite it from a build-plan into a durable rationale — the why, the principles, the invariants — pointing back to the real code for the how. Use when implementation has landed and the plan no longer matches what shipped, or the user says a feature/spec is finished. Pairs with [write-spec](../write-spec/SKILL.md) (the plan this closes) and [review](../review/SKILL.md) (run before closing).

    Also in 5 projects that use this

  • dzhngSkill

    design-with-images

    Explore UI and visual design with image generation, then iterate the real implementation against the user-selected concept. Use when brainstorming visual directions, offering mockup variants, or implementing an approved generated design; do not stop at the mockups or the first code approximation.

    Also in 5 projects that use this

  • LambenthanSkill

    daily-arxiv

    每日从 arXiv 拉取新论文,过滤相关性,auto-ingest 高优先级论文,检测 SOTA 更新

    Also in 5 projects that use this

  • LambenthanSkill

    exp-eval

    实验判决门:Review LLM 独立评判实验结果 → 4 种判决路径 → 自动更新 claims confidence、ideas status、graph edges

    Also in 5 projects that use this

  • +3 more from dzhng
  • +5 more from Lambenthan

The file

We split this skill into the rules it gives an agent

1 rule. 0 are common, 0 are distinctive, and 1 is very specific to this project.

  • 0

    Common

    Most of the 157 edited versions we read keep these.

  • 0

    Distinctive

    This author's own choices. Worth a look.

  • 1

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Very specific:

    When the target is a PR, findings are also rendered into the sticky verdict comment (see Post Review) — grouped under 🚫 Blocking and 💡 …

    line 135

“Common” is measured: kept by at least 6 in 10 of the 157 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Review Skill

Parallel multi-agent code review. Spawns security, simplicity, architecture, and correctness agents against a diff, then consolidates findings.

Invocation

/claude-skills:review              # Current branch vs main
/claude-skills:review 42           # PR #42
/claude-skills:review feature-xyz  # Branch feature-xyz vs main

Out-of-repo anchors (optional)

By default the skill assumes the current working directory is the target git repo. Two optional anchors let it review a target that lives elsewhere — for example reviewing a PR from a non-git workspace, or a branch in a different worktree. When neither anchor is given, behavior is exactly as above.

/claude-skills:review 42 --repo <owner>/<repo>       # PR #42 in another repo
/claude-skills:review pfeff/dotfiles#247             # PR #247 in another repo (shorthand)
/claude-skills:review feature-xyz --worktree <path>  # branch in another worktree
  • --repo <owner>/<repo> — threads the repo through every gh call (gh pr diff and gh pr view via --repo; gh repo view takes it positionally) so a bare PR-number target resolves against the named repo instead of cwd. Use when reviewing an out-of-repo PR.
  • <owner>/<repo>#<number> — shorthand equivalent to <number> --repo <owner>/<repo>; the standard GitHub cross-reference syntax for a PR in another repo, parsed into the same $REPO and PR-number values. A token of this exact shape always wins over a same-named branch (see the Precedence note in operations/run-review.md). Passing both a --repo flag and the owner/repo#N shorthand that disagree is a conflicting-input error.
  • --worktree <path> — anchors git diff calls via git -C <path> so a branch or current-branch target diffs against that worktree instead of cwd. Use when the target branch lives in a different checkout. --repo may be combined to also anchor the verdict-comment posting step.

The anchors only change where the diff is fetched from; the target itself is still a PR number, a git ref, or the owner/repo#number shorthand. Plain PR numbers and branch names are passed through without a character allowlist — a branch target beginning with - is rejected (option-injection guard) and any metacharacters are passed to git inertly as one quoted argument rather than evaluated; only the owner/repo#number shorthand is matched by shape, via an anchored regex that admits only that safe form.

Execution Flow

  1. Determine diff source from $ARGUMENTS
  2. Check diff size — diffs >1000 lines trigger degraded-mode (see Limits)
  3. Spawn 4 review agents in parallel using Task tool (skipped in degraded-mode)
  4. Synthesize and classify findings (blocking vs advisory)
  5. Persist results to .claude/reviews/latest.md
  6. Display results to user
  7. Post sticky verdict comment — when reviewing a PR, upsert a single review comment (edited in place on re-run, never appended) and, unless it is the reviewer's own PR, submit a formal REQUEST_CHANGES/APPROVE event

Implementation: Load operations/run-review.md for full orchestration logic.

Worktree discipline: this skill only ever reads the diff (git diff, gh pr diff) — it never checks out, stashes, resets, or otherwise mutates the worktree. Keep it that way; see lN-review-doctrine's "Reviewer worktree discipline" for the non-mutating recipe if a review ever needs to inspect another revision.

Limits

Diff-size degradation

Diffs exceeding 1000 lines skip the multi-agent pass. The orchestrator performs a single inline review using a condensed checklist (security, correctness, data-loss, architecture, simplicity). The output is labeled:

> **Degraded-mode review** — diff is N lines (threshold: 1000). Multi-agent pass skipped. Coverage may be incomplete.

agents: 1 and degraded: true are set in the frontmatter.

Timeout

The multi-agent pass has a 10-minute wall-clock timeout. If agents do not return within 10 minutes, the review emits a structured timeout failure and stops — no partial results are persisted.

BLOCKING Tier

BLOCKING is restricted to correctness failures, security vulnerabilities, and data-loss risks. Style, naming, ergonomics, and structural preferences are always ADVISORY regardless of agent severity label.

Operations

Run Review

File: operations/run-review.md When: User invokes /claude-skills:review with any arguments

Post Review

File: operations/post-review.md When: Automatically called at the end of run-review when the target is a PR number. Can also be invoked independently after PR creation. Requires $PR_NUMBER.

Posts a single sticky verdict comment (marked with <!-- review:metadata -->) that is edited in place on every re-run — never appended. When the reviewer is not the PR author, it also submits a lightweight REQUEST_CHANGES/APPROVE event carrying the same marker, dismissing its own prior blocking review so nothing stacks; that event, on the reviews API, is the authoritative cross-operator artifact (l1-review reads the marker there — the sticky comment is a visibility mirror). On a self-PR the event is skipped (GitHub blocks it); the comment stands alone.

Agent Prompts

Loaded by the orchestrator and passed to Task tool agents:

  • operations/agents/security.md — OWASP top 10, credential exposure, injection, input validation
  • operations/agents/simplicity.md — YAGNI violations, over-engineering, unnecessary abstractions
  • operations/agents/architecture.md — Pattern adherence, separation of concerns, coupling, naming
  • operations/agents/correctness.md — DESIGN.md conformance, requirement coverage, test coverage

Findings Format

Each agent returns a markdown report with findings organized by severity (critical > warning > info). The orchestrator classifies findings as blocking (critical) or advisory (warning/info), saves structured output to .claude/reviews/latest.md with YAML frontmatter, then displays results to the user.

When the target is a PR, findings are also rendered into the sticky verdict comment (see Post Review) — grouped under 🚫 Blocking and 💡 Advisory headings for readability, one entry per finding as **`file:line`** · category followed by the description.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.