agentleFS
owainlewisowainlewis/blueprint/skills/architecture-review/SKILL.md

architecture-review

Skill423 starsChanged 3 months agoMITView on GitHub

Reviews a technical proposal before any code is written: an architecture, spec, RFC, ADR, or design issue. Finds choices that would make it wrong, unsafe, or impossible to prove, and the open questions that block building it.

78 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use create-stories, story-done and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • lilangMaxSkill

    create-stories

    Break a single epic into implementable story files. Reads the epic, its GDD, governing ADRs, and control manifest. Each story embeds its GDD requirement TR-ID, ADR guidance, acceptance criteria, story type, and test evidence path. Run after /create-epics for each epic.

    Also in 11 projects that use this

  • lilangMaxSkill

    story-done

    End-of-story completion review. Reads the story file, verifies each acceptance criterion against the implementation, checks for GDD/ADR deviations, prompts code review, updates story status to Complete, and surfaces the next ready story from the sprint.

    Also in 11 projects that use this

  • +10 more from lilangMax

The file

We split this skill into the rules it gives an agent

5 rules. 0 are common, 4 are distinctive, and 1 is very specific to this project.

  • 0

    Common

    Most of the 70 edited versions we read keep these.

  • 4

    Distinctive

    This author's own choices. Worth a look.

  • 1

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Very specific:

    Read the proposal, REQUIREMENTS.md, ARCHITECTURE.md, and the code, schemas, and config it touches.

    line 19
  2. Distinctive:

    Write down the problem, who it affects, the intended outcome, and the main tradeoff.

    line 20
  3. Distinctive:

    Check data ownership, interfaces, migrations, rollback, security (auth, untrusted input, secrets), and the scale the proposal claims.

    line 22
  4. Distinctive:

    Look for a simpler design that gets the same result with less state or fewer moving parts.

    line 23
  5. Distinctive:

    Check that each important rule and failure has an acceptance check.

    line 24

“Common” is measured: kept by at least 6 in 10 of the 70 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Architecture review

Find the choices that would make a design wrong, unsafe, or impossible to prove, while they are still cheap to change. Judge the decisions, not the document's length or format.

Reviewer

Someone who did not write the proposal: a fresh subagent, or another agent CLI run read-only (codex exec "<prompt>" or claude -p "<prompt>"). If neither is available, say review is blocked. The reviewer changes nothing.

Steps

  1. Read the proposal, REQUIREMENTS.md, ARCHITECTURE.md, and the code, schemas, and config it touches. Check every claim about the current system against them.
  2. Write down the problem, who it affects, the intended outcome, and the main tradeoff. Flag any the proposal leaves unclear.
  3. Walk one real request from input to what the user sees, including what happens when a step fails, is retried, or runs twice at once.
  4. Check data ownership, interfaces, migrations, rollback, security (auth, untrusted input, secrets), and the scale the proposal claims.
  5. Look for a simpler design that gets the same result with less state or fewer moving parts.
  6. Check that each important rule and failure has an acceptance check.

Findings

Report only what could change the design:

  • Blocker: unsafe, contradicts the goal or the current system, or cannot recover from a likely failure.
  • Important: two capable engineers could build it in ways that differ for users, data, or security.

For each: where it is, what goes wrong and when, the evidence, and the smallest fix or your recommended answer. Skip wording preferences and questions that cannot change the design.

Verdict

End with Approve, Request changes, or Blocked (missing context or reviewer), then what you could not verify. A detailed document is not a reason to approve.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.