agentleFS
ovargasovargas/virtual-team/skills/receiving-code-review/SKILL.md

receiving-code-review

Skill14 starsChanged 8 months agoMITView on GitHub

Use when processing code review feedback from any source — enforces verify-before-implementing with no performative agreement

187 other projects use a version of this, 1 of them edited.

Adopted by

Most recently taken up by

Used with

Projects with it also use chinese-code-review, chinese-commit-conventions and 9 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • Leodorareluctant259Skill

    chinese-code-review

    中文代码审查规范——在保持专业严谨的同时,用符合国内团队文化的方式给出有效反馈

    Also in 8 projects that use this

  • Leodorareluctant259Skill

    chinese-commit-conventions

    中文 Git 提交规范 — 适配国内团队的 commit message 规范和 changelog 自动化

    Also in 8 projects that use this

  • obraSkill

    diagnosing-superpowers

    Use when a superpowers session went wrong and your human partner wants to know why — repeated work, ignored plans, stumbles, poor results, a skill that didn't fire, "it took too long", "why is it so expensive", "what is it doing" — or wants to build a bug report for the superpowers maintainers, for the current session or a past one identified by id or path, on any harness.

    Also in 20 projects that use this

  • OpenAISkill

    requesting-code-review

    Use when completing tasks, implementing major features, or before merging to verify work meets requirements

    Also in 200 projects that use this

  • OpenAISkill

    dispatching-parallel-agents

    Use when facing 2+ independent tasks that can be worked on without shared state or sequential dependencies

    Also in 154 projects that use this

  • +3 more from Leodorareluctant259
  • +3 more from openai

The file

We split this skill into the rules it gives an agent

9 rules. 0 are common, 9 are distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 179 edited versions we read keep these.

  • 9

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Verify before implementing.

    line 10
  2. Distinctive:

    This skill is rigid: Follow it exactly. Do not adapt, skip, or soften the discipline.

    line 12
  3. Distinctive:

    Every piece of code review feedback must pass through these 6 steps, in order:

    line 18
  4. Distinctive:

    Read ALL items before reacting.

    line 22
  5. Distinctive:

    Never performative agreement.

    line 38
  6. Distinctive:

    Test each change before moving to the next review item.

    line 42
  7. Distinctive:

    If ANY item in a multi-item review is unclear, STOP: Do not implement anything yet.

    line 44
  8. Distinctive:

    When a reviewer suggests "implementing properly", "adding X for completeness", or "this should also handle Y":

    line 74
  9. Distinctive:

    If the reviewer insists after one round of pushback, implement their suggestion and note the disagreement in a comment

    line 97

“Common” is measured: kept by at least 6 in 10 of the 179 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Receiving Code Review

Overview

Verify before implementing. Push back when wrong. No performative agreement.

This skill is rigid. Follow it exactly. Do not adapt, skip, or soften the discipline.

This skill applies whenever the agent receives feedback about code: PR reviews, inline comments, SDD reviewer agents, or founder feedback.

The Response Protocol

Every piece of code review feedback must pass through these 6 steps, in order:

1. READ — Complete the full feedback

Read ALL items before reacting. Don't start implementing after reading the first item. Multi-item reviews may have related items — partial understanding leads to wrong implementation.

2. UNDERSTAND — Restate the requirement

Restate the reviewer's point in your own words. If you can't restate it clearly, you don't understand it — ask for clarification.

3. VERIFY — Check against codebase reality

Does the suggestion actually apply here? Is the reviewer's assumption about the code correct? Read the actual code they're referencing. Reviewers sometimes comment on stale diffs or misread context.

4. EVALUATE — Is this technically sound for THIS codebase?

Does it conflict with existing architecture, YAGNI principles, or founder decisions? Check docs/decisions/ and stack.md if relevant.

5. RESPOND — Technical acknowledgment or reasoned pushback

Never performative agreement. Either restate the technical requirement and start working, or push back with specific reasoning.

6. IMPLEMENT — One item at a time

Test each change before moving to the next review item.

If ANY item in a multi-item review is unclear, STOP. Do not implement anything yet. Ask for clarification on unclear items before starting. Items may be related; partial understanding leads to wrong implementation.

Forbidden Responses

These responses are NEVER acceptable when receiving code review:

  • "You're absolutely right!" (performative)
  • "Great point!" / "Excellent feedback!" (sycophantic)
  • "Great catch!" / "Good eye!" (flattering)
  • "Let me implement that now" (before verification)
  • "I agree completely" (without technical reasoning)
  • "Thanks for catching that!" (thanking instead of fixing)

Correct responses:

  • Restate the technical requirement: "The suggestion is to extract the validation into a shared helper because it's duplicated in 3 handlers."
  • Ask clarifying questions: "This endpoint returns 404 for missing users — should it return 403 instead to prevent user enumeration?"
  • Push back with reasoning: "The reviewer suggests adding caching, but this endpoint is called <10 times/day. Adding cache invalidation complexity isn't warranted (YAGNI)."
  • Just start working: Actions > words. Fix the issue, show the diff.

Source-Specific Trust Levels

SourceTrust LevelApproach
FounderHighImplement after understanding. Still ask if scope is unclear. Don't blindly comply on ambiguous instructions.
External reviewerVerify firstCheck if technically correct for THIS codebase. Push back if wrong. They may lack full context.
SDD reviewer agentVerify firstThe reviewer agent may lack full context of the implementation. Verify claims before implementing. Cap pushback at 1 round per review — after that, implement and note disagreement.

YAGNI Check for Reviewer Suggestions

When a reviewer suggests "implementing properly", "adding X for completeness", or "this should also handle Y":

  1. Grep the codebase for actual usage of the feature/endpoint/component
  2. If unused or <3 callers: "This [endpoint/feature] isn't actively used. Adding [complexity] isn't warranted. Remove it (YAGNI)?"
  3. If actively used: Then implement the improvement — the reviewer has a point

The reviewer's suggestion might be technically correct but pragmatically wrong. A perfect implementation of an unused feature is waste.

When to Push Back

Push back when ANY of these are true:

  • Suggestion breaks existing functionality (verify by running tests — if tests break, revert and explain)
  • Reviewer lacks full context (they haven't read the plan, the feature spec, or the surrounding code)
  • Violates YAGNI (adds features, configurability, or abstractions nobody asked for)
  • Technically incorrect for this stack (correct in general but wrong for this project's patterns)
  • Conflicts with founder's architectural decisions (check docs/decisions/ and stack.md)
  • Introduces unnecessary complexity (more indirection, more abstraction, more code for the same behavior)

How to push back:

  • State the technical reason, not just disagreement
  • Reference specific code, tests, or decisions that support your position
  • Propose an alternative if you have one
  • If the reviewer insists after one round of pushback, implement their suggestion and note the disagreement in a comment

Integration

This skill is loaded by:

  • /virtual-team:implement — Layer 0 (behavioral discipline), loaded alongside virtual-team:test-driven-development and virtual-team:verification-before-completion
  • /virtual-team:review — When processing review results (receiving side)
  • /virtual-team:flow — inherited through /virtual-team:implement
  • SDD implementer subagents — loaded when receiving reviewer feedback during SDD review loops

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.