agentleFS
ovargasovargas/virtual-team/skills/architecture-vocabulary/SKILL.md

architecture-vocabulary

Skill14 starsChanged 8 months agoMITView on GitHub

Use when evaluating architecture in tech-review — provides formal vocabulary (Depth, Seam, Leverage, Locality, Adapter, Pass-through) with diagnostic heuristics that produce precise, falsifiable findings instead of generic descriptions

The file

We split this skill into the rules it gives an agent

2 rules. About 0 are common, 2 are distinctive, and 0 are very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈2

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Use these terms and heuristics when evaluating architecture.

    line 8
  2. Distinctive:

    When forming architecture findings, follow this protocol:

    line 23

≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Architecture Vocabulary

Use these terms and heuristics when evaluating architecture. Every architecture finding should reference at least one vocabulary term. Replace generic language with precise claims.

Terms

TermDefinitionDiagnostic Heuristic
DepthDeep module: simple interface, rich functionality. Shallow module: interface nearly as complex as its implementation.Count public methods vs lines of meaningful logic. Ratio near 1:1 = shallow.
SeamA point where behavior can be swapped without changing surrounding code.One adapter = hypothetical seam. Two adapters = real seam. Zero = no seam yet.
AdapterA thin translation layer at a seam boundary. Contains no business logic.If your adapter has business logic, it's a service pretending to be an adapter.
LeverageHow much behavior a module provides per unit of interface complexity.Deletion test: imagine deleting the module. If complexity reappears across callers, it was earning its keep (high leverage). If callers barely notice, it was unnecessary indirection (low leverage).
LocalityRelated changes stay together. Modifying one behavior touches one file, not five.A single conceptual change requiring edits in 3+ files = poor locality. The concept is scattered across wrong boundaries.
Pass-throughA method or layer that receives arguments, adds nothing, and forwards them.If you can describe it as "calls X with the same arguments," it's a pass-through. Adds stack depth and maintenance cost without value.

Applying the Vocabulary

When forming architecture findings, follow this protocol:

  1. Identify which term applies to the observation
  2. Measure using the term's diagnostic heuristic
  3. State the finding as a falsifiable claim with evidence

Findings: Before and After

Before: "This module has poor separation of concerns." After: "This module is shallow — 14 public methods, each a thin wrapper over the database client (ratio ~1:1). Consider consolidating into fewer, deeper methods."

Before: "The code is tightly coupled." After: "No seam exists between the notification service and the email provider (zero adapters). Adding a second provider would require modifying the service internals."

Before: "There's unnecessary abstraction here." After: "The EventDispatcher has low leverage — deletion test shows callers would each add one direct call, replacing the dispatcher's 200-line interface with ~3 lines each. The indirection isn't earning its complexity."

Before: "Changes to billing touch too many files." After: "Billing logic has poor locality — updating the tax calculation requires edits in models/order.ts, services/billing.ts, utils/tax.ts, and api/checkout.ts (4 files). Consider co-locating tax logic."

Integration

This skill is loaded by:

  • commands/tech-review.md — used during the Architecture & Structure evaluation dimension

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.