ds-ts-review
Skill20 starsChanged 46 days agoMITView on GitHub
Review TypeScript code with Tiger Style constraints and TypeScript/Workers idioms.
In this repository52 other files it gives its agents.
- ds-dev-skill-benchSkill
- ds-agent-reviewSkill
- ds-architecture-planSkill
- ds-arenaSkill
- ds-blast-radiusSkill
- ds-blueprintSkill
- ds-bug-reviewSkill
- ds-clarity-reviewSkill
- ds-code-quality-reviewSkill
- ds-comment-reviewSkill
- ds-data-modeSkill
- ds-data-reviewSkill
- ds-debugSkill
- ds-deslopSkill
- ds-doc-quality-reviewSkill
- ds-exploreSkill
- ds-git-modeSkill
- ds-go-reviewSkill
- ds-grill-meSkill
- ds-handoffSkill
- ds-howSkill
- ds-humanizeSkill
- ds-interaction-modeSkill
- ds-java-reviewSkill
- ds-notebook-reviewSkill
- ds-onboardingSkill
- ds-osvSkill
- ds-perf-planSkill
- ds-project-checkpointSkill
- ds-project-resumeSkill
- ds-python-reviewSkill
- ds-quality-gateSkill
- ds-reflectSkill
- ds-retroSkill
- ds-roadmapSkill
- ds-rust-reviewSkill
- ds-security-reviewSkill
- ds-semgrepSkill
- ds-shell-reviewSkill
- dsSkill
- ds-specSkill
- ds-step-modeSkill
- ds-tdd-modeSkill
- ds-test-modeSkill
- ds-test-quality-reviewSkill
- ds-tiger-style-modeSkill
- ds-tldtSkill
- ds-ui-modeSkill
- ds-ui-quality-reviewSkill
- ds-verify-thisSkill
- ds-zig-reviewSkill
- ds-zoom-outSkill
The file
We split this skill into the rules it gives an agent
1 rule. About 0 are common, 0 are distinctive, and 1 is very specific to this project.
≈0
Common · estimate
Many files like this have a rule of this kind.
≈0
Distinctive · estimate
This author's own choices. Worth a look.
1
Very specific
Tied to their project's names, files or tools. Probably skip.
- Common
- Distinctive
- Very specific
- Very specific: line 22
Use the checklist as a lens, not a scorecard: reason about the actual change, report real violations anchored to file:line, and flag issues …
≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.
Files
Applies to: TypeScript 5.5+. Cloudflare Workers, Next.js, React, edge runtimes.
Arguments
Scan the invocation for the --no-tiger, --fix, and --full flags. Treat every other argument as review scope (files or directories); if no scope is given, review the changed files on the current branch.
--no-tigerpresent → skip the Tiger Style section; run the remaining sections only.--no-tigerabsent → run all sections (default).--fix→ after reporting, apply only the violations whose fix is mechanical and unambiguous (a rename to the idiom, a missing error check the review is certain about). Anything that changes logic or rests on an unverified assumption — especially security and correctness findings — stays report-only. After applying, re-run any build/test/lint check already in the loop and revert any fix that breaks it — or that touched more than the intended mechanical edit. End with a summary of what was applied and what was left.--full→ review the entire codebase instead of just the branch's changes. Explicit positional scope still wins;--fullonly replaces the no-scope default.
Example: /ds-ts-review --no-tiger src/ worker/ reviews src/ and worker/ without Tiger Style.
Review Checklist
Use the checklist as a lens, not a scorecard: reason about the actual change, report real violations anchored to file:line, and flag issues even when they aren't listed. Don't manufacture findings to fill a category. Report only violations — no praise, no summary.
Tiger Style
Skip this section entirely if --no-tiger was passed. Otherwise it is mandatory.
- No unbounded loops over user-controlled data
- All promises awaited or explicitly handled — no floating promises
- Error values propagated explicitly — no silent catch-and-ignore
- Functions under 70 lines
- Variable names include units/qualifiers where applicable (
_ms,_bytes,_count)
TypeScript
strict: truein tsconfig — noanyunless explicitly justified with comment- No
as Typecasts that bypass runtime checks — validate at boundaries satisfiesto check a value against a type without widening it, instead of an annotation that erases the literal type or anascast- Discriminated unions used for state modeling, not boolean flags
- No optional chaining (
?.) used to hide missing error handling - Prefer unions of string literals over enums entirely (
const enumbreaks underisolatedModules/verbatimModuleSyntaxand most bundlers) - Return types explicit on all exported functions
- No
namespace— use ES modules using/await usingfor scoped cleanup (TS 5.2) where a resource implements[Symbol.dispose]/[Symbol.asyncDispose], instead of hand-written try/finally
Cloudflare Workers (when applicable)
- No Node.js-only APIs (
fs,path,cryptowith Node semantics) — use Web APIs envbindings typed viaEnvinterface, notany- Durable Objects: state mutations wrapped in
this.state.storage.transaction() - CPU time budget respected — no long synchronous computation in request handler
- Secrets accessed via
env.SECRET_NAME, not hardcoded wrangler.tomlbindings match runtimeEnvinterface
React / Frontend (when applicable)
- No state mutation —
setStateor dispatch with a new object useEffectdependency arrays complete — no stale-closure bugs — and effects reserved for real external synchronization, not derived state- With the React Compiler enabled, hand-written
useMemo/useCallback/React.memoare dropped in new code — kept only where a measured need survives the compiler refpassed as an ordinary prop (React 19) — noforwardRefwrapper- Promises/context read with
use()where it fits; forms built onuseActionState/useFormStatusrather than a bespoke state library - Data fetching co-located with its loading/error state
- Unsafe HTML rendering avoided; content sanitized before DOM insertion
- Keys on lists are stable identifiers, not array indices
Performance
Idiom-level checks only — for a ranked, costed optimization plan, use /ds-perf-plan.
- No database/network calls issued inside loops; N+1 patterns absent
- Independent async work runs concurrently (
Promise.all), not awaited one-by-one - Large payloads streamed, not fully buffered — Workers have a tight memory budget
Security
- No dynamic code execution from untrusted strings
- Raw HTML insertion avoided unless content is sanitized through a trusted library
- CORS headers explicitly configured, not wildcard
*on sensitive routes - Auth tokens not stored in localStorage (prefer httpOnly cookies or memory)
- No secrets in client-side bundles
- All user input validated and bounded at the entry point
Testing
- Unit tests for pure functions
- Integration tests for Worker routes (use Miniflare or
wrangler dev) - No
anytype in test assertions
Output Format
<file>:<line>: <severity>: <problem>. <fix>.Severity: critical, major, minor.
Does it work?
Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.
No reviews yet
People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.
- It worked
- Partly
- It didn't
Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.
Your trail
Files you open will collect here, so you can find them again.
Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.
Now do this for your own.
Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.

