agentleFS
davidscotttuftsdavidscotttufts/hyvemind/skills/design-review/SKILL.md

design-review

Skill0 starsChanged 20 days agoApache-2.0View on GitHub

Senior architecture review of a spec, a design, or a set of competing options before code is written: boundaries, duplication and naming collisions, coupling, data flow, failure modes, authorization, migration/rollback, testability. Produces severity-ordered findings with concrete failure scenarios, or a recommendation between options.

155 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use project-stage-detect, team-audio and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • CoralGameSkill

    project-stage-detect

    Automatically analyze project state, detect stage, identify gaps, and recommend next steps based on existing artifacts.

    Also in 16 projects that use this

  • CoralGameSkill

    team-audio

    Orchestrate audio team: audio-director + sound-designer + technical-artist + gameplay-programmer for full audio pipeline from direction to implementation.

    Also in 13 projects that use this

  • julianoczkowskiSkill

    brief-to-tasks

    Break a design brief into an ordered checklist of independently buildable tasks using vertical slices. Saves as a markdown checklist. Use when user wants to break down work, create tasks from a brief, plan implementation order, or mentions "tasks" or "breakdown".

    Also in 7 projects that use this

  • lilangMaxSkill

    asset-spec

    Generate per-asset visual specifications and AI generation prompts from GDDs, level docs, or character profiles. Produces structured spec files and updates the master asset manifest. Run after art bible and GDD/level design are approved, before production begins.

    Also in 10 projects that use this

  • lilangMaxSkill

    create-control-manifest

    After architecture is complete, produces a flat actionable rules sheet for programmers — what you must do, what you must never do, per system and per layer. Extracted from all Accepted ADRs, technical preferences, and engine reference docs. More immediately actionable than ADRs (which explain why).

    Also in 10 projects that use this

  • +4 more from CoralGame
  • +3 more from lilangMax

The file

We split this skill into the rules it gives an agent

1 rule. 0 are common, 1 is distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 129 edited versions we read keep these.

  • 1

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Generator scan: When the design fixes a problem (duplicates, orphans, drift), find the code that generates it, not just its instances: the …

    line 22

“Common” is measured: kept by at least 6 in 10 of the 129 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Design review

Review it like the person who will be paged when it breaks. Every finding has to name a concrete failure scenario: inputs or state, then the wrong outcome. A finding without one is a style preference, and you leave it out.

Inputs

The spec or design doc, the code it touches, and any earlier decision records in specs.dir. If you are choosing between options, read all of them before judging any.

Checklist

  1. Duplication and collisions. Does this already exist under another name? Search for the domain nouns, route paths, table and collection names, config keys and event names. A second system that does the same job will drift from the first.
  2. Generator scan. When the design fixes a problem (duplicates, orphans, drift), find the code that generates it, not just its instances: the writer that duplicates, the id that isn't idempotent on re-run, the hand-kept list that falls behind. A fix for instances only comes back.
  3. Boundaries. Does a module reach into another's internals? Would the new dependencies create a cycle? Does each piece of state have exactly one owner?
  4. Data flow and integrity. Where is each piece of data created, changed and deleted? What happens to dependents on delete? Is an operation that runs twice idempotent? Who wins when two writers collide?
  5. Failure modes. Timeouts, partial failure, retries, a dependency that is down. Does an error ever look like success (an empty list or a default value standing in for a failure)?
  6. Authorization and tenancy. Is every new read and write checked by the same rule the existing route uses? Fail closed. Never trust a caller-supplied owner, tenant or role.
  7. Model-facing surfaces (if AI is involved): apply {{skill:ai-exchange}}'s dimensions to each new model call.
  8. Migration and rollback. Can it ship dark? Can it roll back without data loss? What happens to existing data?
  9. Testability. Can each acceptance criterion become a test that would fail if the behaviour broke?

Output

VERDICT: GO | GO-WITH-CHANGES | NO-GO

[BLOCKER] <title> — <file/section>
  Scenario: <inputs/state> → <wrong outcome>
  Fix: <specific change>
[MAJOR] …
[MINOR] …

For competing options, always include do nothing. Score options × debt, foreclosure (what it rules out later) and reversibility, then make one recommendation with the deciding reason and what would change your mind. Don't present a survey without a decision. Never recommend cutting scope because the work is big; recommend phases. A finding the spec can't close goes in its risk register.

⛔ Any BLOCKER stops the pipeline until the spec is corrected.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.