agentleFS
colasamacolasama/MahoShojo-Generator/.agents/skills/ui-review/SKILL.md

ui-review

Skill168 starsChanged 29 days agoApache-2.0View on GitHub

Use when reviewing MahoShojo-Generator 的 UI/UX 改动(组件、样式、token、样板间、视觉一致性),对照视觉基线 spec 与契约门禁判断是否达标。不用于纯逻辑/协议审查(用 code-review)。

22 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use accessibility and grill-me.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • ElasticSkill

    accessibility

    Accessibility guidance for Kibana. Use this skill when working with or reviewing EUI components, resolving a11y-related (@elastic/eui) ESLint issues, and ensuring proper use of ARIA attributes, focus management, keyboard interactions, and accessible naming conventions.

    Also in 3 projects that use this

  • GoogleSkill

    grill-me

    A relentless interview to sharpen a plan or design.

    Also in 3 projects that use this

The file

Files
SKILL.md

UI Review

审查基准

  1. docs/decisions/2026-10-19_215000_双端视觉治理体系决策.md(已接受治理决策);
  2. docs/specs/2026-10-19_215200_双端视觉基线与工程契约规格.md 的 VIS-* MUST/MUST NOT;
  3. 机器守卫的登记表:tests/design-tokens.test.ts(变量声明/兜底/字重/离网格 baseline)、tests/design-contrast.test.ts(配对矩阵与已知缺口)、tests/visual-showroom.test.ts(分区覆盖与入口约束)。

重点检查

  • 视觉值是否走 --app-* token/共享类:新增未声明 var()、逗号兜底、数字字重、离网格字面量属违约(baseline 只能降不能增);
  • 是否绕过共享组件另写"本端一套",或跨包深挖 src/* 私有路径;
  • 新增/变更共享组件是否同单元更新样板分区与 SHOWROOM_SECTIONS,分区是否渲染生产组件而非另写示例;
  • 写法政策:增量 styled-jsx/CSS Module/inline style 是否为零,遗留清理是否顺手但未混入无关重构;
  • a11y:是否新增 jsx-a11y warn、focus-visible 与键盘可达是否保持、新控件是否处理 forced-colors 或登记缺口;
  • 变更权限:B/C 级改动是否有先行说明/授权,是否存在"借修 UI 之名"改产品语义。

证据要求

  • 不接受"看起来对":要求列明实际运行的 lint/typecheck/test 与结果;
  • 视觉面变化可要求 pnpm review:visual(含 --screenshots)的 .tmp/visual-review/ 证据,但它是本地辅助而非硬门槛;
  • Desktop 真 WebView2、原生高对比主题、读屏等人工验收项按 runbook 口径列为未验项即可,不要求本工具冒充。

结论

按严重度排序列出发现(文件/行为证据、影响、闭合标准),区分确认缺陷、设计问题与可选清理;收尾给出 Block、Changes required 或 Looks good with minor follow-ups。

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.