agentleFS
bordenetbordenet/superpowers-plus/skills/engineering/requesting-code-review/skill.md

requesting-code-review

Skill8 starsChanged 6 months agoMITView on GitHub

Use when presenting code changes to a human for review — dispatches code-review-battery. Self-fires on intent to present (see Cardinal Rule in skill body). Resolves current content/context coverage before presentation; reuses valid review evidence and reviews only missing or affected scope.

187 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use chinese-code-review, chinese-commit-conventions and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • Leodorareluctant259Skill

    chinese-code-review

    中文代码审查规范——在保持专业严谨的同时,用符合国内团队文化的方式给出有效反馈

    Also in 8 projects that use this

  • Leodorareluctant259Skill

    chinese-commit-conventions

    中文 Git 提交规范 — 适配国内团队的 commit message 规范和 changelog 自动化

    Also in 8 projects that use this

  • obraSkill

    diagnosing-superpowers

    Use when a superpowers session went wrong and your human partner wants to know why — repeated work, ignored plans, stumbles, poor results, a skill that didn't fire, "it took too long", "why is it so expensive", "what is it doing" — or wants to build a bug report for the superpowers maintainers, for the current session or a past one identified by id or path, on any harness.

    Also in 20 projects that use this

  • math-incSkill

    heartmula

    Set up and run HeartMuLa, the open-source music generation model family (Suno-like). Generates full songs from lyrics + tags with multilingual support.

    Also in 9 projects that use this

  • Tommy-ywSkill

    webhook-subscriptions

    Create and manage webhook subscriptions for event-driven agent activation, or for direct push notifications (zero LLM cost). Use when the user wants external services to trigger agent runs OR push notifications to chats.

    Also in 5 projects that use this

  • john-data-chenSkill

    touchdesigner-mcp

    Control a running TouchDesigner instance via twozero MCP — create operators, set parameters, wire connections, execute Python, build real-time visuals. 36 native tools.

    Also in 7 projects that use this

  • +3 more from Leodorareluctant259

The file

We split this skill into the rules it gives an agent

8 rules. 0 are common, 3 are distinctive, and 5 are very specific to this project.

  • 0

    Common

    Most of the 173 edited versions we read keep these.

  • 3

    Distinctive

    This author's own choices. Worth a look.

  • 5

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Use the repository's review router and native clearance parser before dispatch.

    line 49
  2. Very specific:

    Before every automated review or test/check pass, resolve a snapshot-bound REUSE, WAIT, RUN_MINIMAL, REVIEW_REQUIRED or STOP decision at …

    line 55
  3. Very specific:

    Use the actual target snapshot, including relevant staged/unstaged changes.

    line 64
  4. Distinctive:

    Never infer staleness from HEAD alone or parse a guessed sentinel format.

    line 67
  5. Distinctive:

    Keep review evidence in its native artifact.

    line 85
  6. Very specific:

    Follow the code-review-battery procedure:

    line 100
  7. Very specific:

    Dispatch: all activated reviewers in parallel via sub-agent-code-reviewer

    line 103
  8. Very specific:

    Only proceed to presenting work as "ready" when battery verdict is PASS or PASS_WITH_NITS (with nits fixed).

    line 118

“Common” is measured: kept by at least 6 in 10 of the 173 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
skill.md

Wrong skill? Pre-commit/push → unified-commit-gate. Reviewing someone else's PR → providing-code-review. Implementing feedback you received → receiving-code-review. Inter-agent file handoff → inter-agent-review-protocol.

Requesting Code Review

Use the repository's review router and native clearance parser before dispatch. Review missing or invalidated classes; preserve an existing clean independent review while its content, coverage, dependencies and guidance remain valid.

Strategy before execution

Before every automated review or test/check pass, resolve a snapshot-bound REUSE, WAIT, RUN_MINIMAL, REVIEW_REQUIRED or STOP decision at its supported execution/dispatch boundary. Reuse valid coverage or join its active producer. Missing/stale decisions refuse; unknown coverage stays conservative. No model calls or recursive checks inside strategy. Status/HEAD changes, clean reviews and score targets alone never justify another expensive pass.

Before presenting completed work

Use the actual target snapshot, including relevant staged/unstaged changes. In superpowers-plus, run tools/review.sh route <paths> and read tools/push-readiness.sh --json or tools/review-preflight.py --staged. Never infer staleness from HEAD alone or parse a guessed sentinel format.

  • Valid content-scoped clearance: reuse it, including after tree-identical merges, amends or history-only commits. Do not dispatch another reviewer.
  • Missing/invalidated clearance: obtain the required initial or affected-delta review and use the native writer after genuine review judgment.
  • Failed/malformed evidence: STOP and diagnose; preserve it rather than deleting the sentinel to force a clean slate.
  • Uncommitted relevant changes: review that exact snapshot. Do not stash or commit merely to make the status look clean.

One initial independent review is sufficient when clean and above the required floor. Reopen for material changed scope, an unresolved actionable finding, invalidated evidence or an explicitly justified independent safety lens. Report a low score without new actionable evidence; never chase it by redispatching.

Progress updates may report existing results without launching tests or review. A final completion claim needs valid evidence for the actual presented scope. Keep review evidence in its native artifact; do not force process banners into every human-facing message or treat publication permission as review clearance.

How to Request

1. Gather context

BASE_SHA=$(git merge-base HEAD main)   # or origin/dev, origin/main
HEAD_SHA=$(git rev-parse HEAD)
git diff $BASE_SHA..$HEAD_SHA          # the diff to review

2. Dispatch code-review-battery

Follow the code-review-battery procedure:

  1. Triage the diff → select relevant specialist reviewers
  2. Dispatch all activated reviewers in parallel via sub-agent-code-reviewer
  3. Each reviewer gets: reviewer prompt + full diff + source context (callers, field readers, state types)
  4. Aggregate findings → triple-filter → classify Implement/Defer/Reject

3. Act on findings

SeverityAction
CriticalFix immediately; validate the fix and review only its affected delta when required.
ImportantFix before proceeding; reopen only affected scope with an actionable basis.
MinorFix now or document for follow-up.
Reviewer wrongPush back with technical reasoning and evidence.

4. Confirm verdict

Only proceed to presenting work as "ready" when battery verdict is PASS or PASS_WITH_NITS (with nits fixed).

Integration with Workflows

WorkflowWhen to Review
Subagent-driven developmentAt the approved review boundary; new scope/findings select the required delta
Feature developmentAfter implementation, before presenting options
Ad-hoc developmentBefore merge or when stuck
Finishing a branchResolve native strategy first; dispatch only missing/invalidated review coverage

Anti-Patterns

WrongRight
Skipping review because "it's simple"Complexity doesn't determine risk
Ignoring Critical findingsCritical = broken if shipped
Proceeding with unfixed Important findingsFix first, then re-dispatch
Arguing with valid technical feedbackPush back only with evidence
Presenting work as "ready" then reviewingReview first, present second

Companion Skills

  • code-review-battery: The review engine this skill dispatches
  • progressive-code-review-gate: Fires at commit time (uses battery) — handles "ready to commit/push" triggers
  • verification-before-completion: Completion gate that requires review evidence
  • providing-code-review: Engineering rigor checklist (informs reviewer focus)

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.