agentleFS
bordenetbordenet/superpowers-plus/skills/engineering/receiving-code-review/skill.md

receiving-code-review

Skill8 starsChanged 6 months agoMITView on GitHub

Use when receiving code review feedback, before implementing suggestions, especially if feedback seems unclear or technically questionable - requires technical rigor and verification, not performative agreement or blind implementation

187 other projects use a version of this, 152 of them edited.

Adopted by

Most recently taken up by

Used with

Projects with it also use chinese-code-review, chinese-commit-conventions and 4 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • Leodorareluctant259Skill

    chinese-code-review

    中文代码审查规范——在保持专业严谨的同时,用符合国内团队文化的方式给出有效反馈

    Also in 8 projects that use this

  • Leodorareluctant259Skill

    chinese-commit-conventions

    中文 Git 提交规范 — 适配国内团队的 commit message 规范和 changelog 自动化

    Also in 8 projects that use this

  • obraSkill

    diagnosing-superpowers

    Use when a superpowers session went wrong and your human partner wants to know why — repeated work, ignored plans, stumbles, poor results, a skill that didn't fire, "it took too long", "why is it so expensive", "what is it doing" — or wants to build a bug report for the superpowers maintainers, for the current session or a past one identified by id or path, on any harness.

    Also in 20 projects that use this

  • +3 more from Leodorareluctant259

The file

Show its rules and text

We split this skill into the rules it gives an agent

21 rules. 1 is common, 18 are distinctive, and 2 are very specific to this project.

  • 1

    Common

    Most of the 179 edited versions we read keep these.

  • 18

    Distinctive

    This author's own choices. Worth a look.

  • 2

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Very specific:

    Before every automated review or test/check pass, resolve a snapshot-bound REUSE, WAIT, RUN_MINIMAL, REVIEW_REQUIRED or STOP decision at …

    line 33
  2. Distinctive:

    After receiving PR/MR review comments from any reviewer

    line 42
  3. Distinctive:

    When review feedback seems unclear, contradictory, or technically questionable

    line 43
  4. Distinctive:

    Before implementing any suggested changes from code review

    line 44
  5. Common:

    Core principle: Verify before implementing.

    line 50
  6. Distinctive:

    WHEN receiving code review feedback:

    line 54
  7. Distinctive:

    READ: Complete feedback without reacting

    line 56
  8. Distinctive:

    VERIFY: Check against codebase reality

    line 58
  9. Distinctive:

    AFTER implementing all items:

    line 70
  10. Very specific:

    SEARCH for OTHER instances of the same pattern: grep -rn "pattern" --include="*.ts" .

    line 73
  11. Distinctive:

    VERIFY the GOAL is achieved, not just the checklist

    line 75
  12. Distinctive:

    Only caught by adversarial self-review asking "are there OTHER places?"

    line 85
  13. Distinctive:

    BEFORE claiming code review changes are complete:

    line 91
  14. Distinctive:

    If ANY box is unchecked → you're not done

    line 98
  15. Distinctive:

    Search: grep -rn "userRole.*||.*'guest'" .

    line 108
  16. Distinctive:

    Verify: grep returns nothing

    line 111
  17. Distinctive:

    Unclear feedback: STOP — clarify ALL items before implementing.

    line 120
  18. Distinctive:

    External reviewers: Check: correct for THIS codebase?

    line 125
  19. Distinctive:

    Test each individually → verify no regressions → SYSTEMIC CHECK

    line 131
  20. Distinctive:

    Verify. Question. Then implement.

    line 151
  21. Distinctive:

    No performative agreement.

    line 153

“Common” is measured: kept by at least 6 in 10 of the 179 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
skill.md

Code Review Reception

Wrong skill? Reviewing someone's PR → providing-code-review. Sending to reviewer agent → code-review. Acting as reviewer → code-review-respond.

Strategy before execution

Before every automated review or test/check pass, resolve a snapshot-bound REUSE, WAIT, RUN_MINIMAL, REVIEW_REQUIRED or STOP decision at its supported execution/dispatch boundary. Reuse valid coverage or join its active producer. Missing/stale decisions refuse; unknown coverage stays conservative. No model calls or recursive checks inside strategy. Status/HEAD changes, clean reviews and score targets alone never justify another expensive pass.

When to Use

  • After receiving PR/MR review comments from any reviewer
  • When review feedback seems unclear, contradictory, or technically questionable
  • Before implementing any suggested changes from code review

Overview

Code review requires technical evaluation, not emotional performance.

Core principle: Verify before implementing. Ask before assuming. Technical correctness over social comfort.

The Response Pattern

WHEN receiving code review feedback:

  1. READ: Complete feedback without reacting
  2. UNDERSTAND: Restate requirement in own words (or ask)
  3. VERIFY: Check against codebase reality
  4. EVALUATE: Technically sound for THIS codebase?
  5. RESPOND: Technical acknowledgment or reasoned pushback
  6. IMPLEMENT: One item at a time; strategy selects affected coverage and reuses valid prior checks
  7. SYSTEMIC CHECK: Search for OTHER instances (see below)

🚨 Systemic Verification (MANDATORY)

After implementing all feedback items, BEFORE claiming done: The reviewer's feedback identifies SYMPTOMS. Your job is to fix the DISEASE, not just the symptoms.

AFTER implementing all items:

  1. EXTRACT the underlying principle/goal — e.g., "Remove all silent defaults" not "fix these 3 lines"
  2. SEARCH for OTHER instances of the same pattern: grep -rn "pattern" --include="*.ts" .
  3. FIX additional instances within the authorized boundary; report unrelated findings without expanding scope
  4. VERIFY the GOAL is achieved, not just the checklist

Why This Exists

Common failure pattern:

  • Reviewer identified 3 instances of a problematic pattern
  • Agent fixed all 3 listed items ✓
  • Agent claimed "Done!" ✓
  • A 4th instance existed that wasn't in the reviewer's list
  • Only caught by adversarial self-review asking "are there OTHER places?"

Root cause: Treated feedback as finite checklist, not systemic issue.

The Gate

BEFORE claiming code review changes are complete:

☐ Did I extract the underlying GOAL from the feedback? ☐ Did I search for OTHER instances of the same pattern? ☐ Did I verify the GOAL is achieved (not just items checked off)? ☐ Would a harsh reviewer find more instances I missed?

If ANY box is unchecked → you're not done

Example

Reviewer says: "Remove hardcoded defaults at lines 96, 127, and 81"

❌ WRONG: Fix lines 96, 127, 81 → "Done!"

✅ RIGHT: 1. Goal: "No hardcoded defaults for userRole" 2. Search: grep -rn "userRole.||.'guest'" . 3. Find: Lines 96, 127, 81 (listed) + line 2199 (NOT listed) 4. Fix ALL four 5. Verify: grep returns nothing 6. "Done - fixed 4 instances (3 listed + 1 additional in data import)"

Response Rules

Never performative ("You're absolutely right!", "Great point!"). Instead: restate requirement, ask questions, push back with reasoning, or just fix it.

Correct feedback: "Fixed. [what changed]" or "Good catch — [issue]. Fixed in [location]." or just fix and show.

Unclear feedback: STOP — clarify ALL items before implementing. Partial understanding = wrong implementation.

Source-Specific Handling

Human partner: Trusted — implement after understanding. Still ask if scope unclear. External reviewers: Check: correct for THIS codebase? Breaks functionality? Reason for current approach? Push back if wrong. Conflicts with partner's decisions → discuss with partner first.

Implementation Order

  1. Clarify unclear items FIRST
  2. Blocking (breaks, security) → simple (typos, imports) → complex (refactoring)
  3. Test each individually → verify no regressions → SYSTEMIC CHECK

Push Back When

Breaks functionality · reviewer lacks context · YAGNI · technically wrong · legacy reasons · conflicts with partner's architecture.

Common Mistakes

MistakeFix
Performative agreementState requirement or just act
Blind implementationVerify against codebase first
Batch without testingOne at a time, test each
Checklist ≠ goal achievedSearch for OTHER instances
Fixing symptoms not diseaseExtract underlying goal
❌ ANY gratitude expressionBan completely

The Bottom Line

External feedback = suggestions to evaluate, not orders to follow. Verify. Question. Then implement. Then verify the GOAL, not just the checklist.

No performative agreement. Technical rigor always.

Anti-Patterns

Anti-PatternDetectionCorrection
Defensive dismissal"That's by design" without evidenceAssume reviewer saw something real
Blind acceptanceFix everything without evaluationEvaluate each: agree/disagree/discuss
Scope deflection"Out of scope for this PR" for real issuesFix if <30 min, else log TODO
Silent disagreementIgnore comment, don't respondEvery comment gets a response
Fix without understandingMechanical fix, same pattern recursUnderstand root cause first

Failure Modes

  • Blind implementation: Implementing every suggestion without evaluating whether it's correct for THIS codebase
  • Performative agreement: Saying "great catch!" instead of technically verifying the feedback is accurate
  • Fixing symptoms only: Addressing the specific line a reviewer flagged without checking for the same pattern elsewhere

Example: Systemic Check After Review

# Reviewer says: "This null check is missing"
# WRONG: Add null check to just this line
# RIGHT: Search for ALL similar patterns in the codebase
grep -rn "\.getData()" --include="*.ts" src/ | grep -v "?." | grep -v "!= null"
# Then fix ALL instances, not just the one the reviewer spotted

Companion Skills

  • providing-code-review: How the reviewer should structure feedback
  • inter-agent-review-protocol: File-protocol review (may generate the feedback you're processing)
  • systematic-debugging: For investigating complex review findings
  • code-review-respond: Review response workflow
  • code-review-battery: Multi-reviewer orchestration

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.