agentleFS
ariaxhanariaxhan/kernel-claude/skills/review/SKILL.md

review

Skill15 starsChanged 4 months agoMITView on GitHub

Code review for PRs or staged changes. >80% confidence threshold. Verdict: APPROVE, REQUEST CHANGES, or COMMENT. Triggers: review, pr, code review.

192 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use close-spec, design-with-images and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • dzhngSkill

    close-spec

    When a spec under specs/<feature>/ is done shipping (a write-spec build, or any planned task that produced a spec), archive it to specs/done/ and rewrite it from a build-plan into a durable rationale — the why, the principles, the invariants — pointing back to the real code for the how. Use when implementation has landed and the plan no longer matches what shipped, or the user says a feature/spec is finished. Pairs with [write-spec](../write-spec/SKILL.md) (the plan this closes) and [review](../review/SKILL.md) (run before closing).

    Also in 5 projects that use this

  • dzhngSkill

    design-with-images

    Explore UI and visual design with image generation, then iterate the real implementation against the user-selected concept. Use when brainstorming visual directions, offering mockup variants, or implementing an approved generated design; do not stop at the mockups or the first code approximation.

    Also in 5 projects that use this

  • LambenthanSkill

    daily-arxiv

    每日从 arXiv 拉取新论文,过滤相关性,auto-ingest 高优先级论文,检测 SOTA 更新

    Also in 5 projects that use this

  • LambenthanSkill

    exp-eval

    实验判决门:Review LLM 独立评判实验结果 → 4 种判决路径 → 自动更新 claims confidence、ideas status、graph edges

    Also in 5 projects that use this

  • +3 more from dzhng
  • +5 more from Lambenthan

The file

We split this skill into the rules it gives an agent

12 rules. 0 are common, 10 are distinctive, and 2 are very specific to this project.

  • 0

    Common

    Most of the 157 edited versions we read keep these.

  • 10

    Distinctive

    This author's own choices. Worth a look.

  • 2

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Only report issues with >80% confidence.

    line 17
  2. Distinctive:

    Check these FIRST - what AI actually breaks:

    line 69
  3. Distinctive:

    No empty catch blocks?

    line 86
  4. Distinctive:

    Should be extracted to shared utility?

    line 94
  5. Distinctive:

    Run the configured project verify command first.

    line 98
  6. Very specific:

    If a baseline exists, does the diff say regressed=0?

    line 101
  7. Very specific:

    Before a finding enters the report, check it against reference/refutation-patterns.md (11 false-alarm families + 5 refutation moves).

    line 132
  8. Distinctive:

    Use AskUserQuestion when: a finding is between 70-85% confidence (ambiguous) Ask: "Found {issue} at {file:line} (confidence {X}%).

    line 161
  9. Distinctive:

    Ask: "Found {issue} at {file:line} (confidence {X}%).

    line 162
  10. Distinctive:

    APPROVE: no finding clears the block bar.

    line 171
  11. Distinctive:

    Read the acceptance record before reviewing: claims, declared invariants, and tradeoffs already accepted.

    line 202
  12. Distinctive:

    Never ask a reviewer whether criticism is complete.

    line 206

“Common” is measured: kept by at least 6 in 10 of the 157 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md
<skill id="review"><purpose> Review code changes for quality, correctness, security. Only report issues with >80% confidence.

Load: skills/build/reference/testing.md, skills/tearitapart/reference/security.md Reference: _meta/research/ai-code-anti-patterns.md </purpose>

<context> ai_code_stats: buggier: 1.7x more issues than human code security: 40-62% contain vulnerabilities findings: 10.83 per AI PR vs 6.45 human

priority: check Big 5 first (what AI actually breaks) </context>

<on_start>

agentdb read-start

<identify_scope>

gh pr diff {number}        # For PRs
git diff --staged          # For staged
git diff HEAD~1            # For recent

</identify_scope>

<deterministic_lane> Machines first, then judgment. Run before reading a single diff hunk:

"${CLAUDE_PLUGIN_ROOT:-.}/scripts/deterministic-review.sh" <repo-dir> [base-ref]

Parallel gitleaks / semgrep(p/security-audit) / eslint / ruff / shellcheck / actionlint / zizmor / osv-scanner — whatever is installed; diff-scoped when base-ref given; exit 1 on HIGH (secrets, security SAST, high CVEs). Feed findings.tsv into the review as ground truth. Lanes marked SKIPPED are reported as NOT CHECKED, never as clean. </deterministic_lane> </on_start>

<confidence_threshold>

ConfidenceCategoryReport?
95%+Definite bugYES
85-95%Likely issueYES
70-85%Possible issueMAYBE
<70%Style preferenceNO
</confidence_threshold>
<big5 name="BIG 5: AI-SPECIFIC CONCERNS"> Check these FIRST - what AI actually breaks:<check id="1_input_validation"> - Zod/Pydantic schema for every API endpoint? - Parameterized queries (no string concat)? - File uploads validated (size, type, extension)? detection: grep -r "req\.body" | grep -v "parse\|validate\|z\." </check><check id="2_edge_cases"> - Null/undefined handling present? - Empty arrays handled (length check)? - Zero-length strings rejected? - Timeout handling for external calls? </check><check id="3_error_handling"> - No empty catch blocks? - Errors logged with context? - User-facing messages generic? detection: grep -r "catch.*{}" (empty catch) </check><check id="4_duplication"> - Same logic repeated in multiple places? - Should be extracted to shared utility? </check><check id="5_complexity"> - Run the configured project verify command first. If complexity is not on that armed path, report the enforcement gap; a manual measurement is not a gate. - Any function above its `.ccnrc` budget? A number, not a guess. - If a baseline exists, does the diff say `regressed=0`? - For JS/TS, did stderr name `eslint AST`? Lizard's fallback does not see object-literal methods. - Nested ternaries > 2 levels? detection: ${CLAUDE_PLUGIN_ROOT}/scripts/complexity.sh <repo> <base-ref>; ${CLAUDE_PLUGIN_ROOT}/scripts/complexity.sh --diff <baseline.tsv> <repo> fix: /kernel:simplify on the listed functions </check> </big5><checklist> <section name="Logic & Correctness"> - [ ] Edge cases handled - [ ] Error paths covered - [ ] Null checks present - [ ] Type safety </section><section name="Security"> - [ ] Input validation (Zod schema) - [ ] No hardcoded secrets - [ ] SQL injection prevented (parameterized queries) - [ ] XSS prevented (context-aware output encoding / framework auto-escaping first; DOMPurify only where raw HTML is injected, e.g. `dangerouslySetInnerHTML`, `v-html`, `innerHTML`) - [ ] Auth tokens in httpOnly cookies </section><section name="Performance"> - [ ] No N+1 queries - [ ] Appropriate caching </section> </checklist>

<refute_before_report> Before a finding enters the report, check it against reference/refutation-patterns.md (11 false-alarm families + 5 refutation moves). A finding matching a family needs evidence distinguishing it from the refuted precedent. Severity gates from the same file apply: falsification check before CRITICAL, consensus deflation, authority stripping on CVEs, and the judge's own additions get refuted too. Refuted candidates go in the report WITH their refutations; if the project keeps a refutation-corpus file, append new refuted false alarms to it in the same session. </refute_before_report>

<output_format> CODE REVIEW

Files: X changed Findings: Y (Z critical)

CRITICAL

[file:line] Issue (confidence: XX%) → Fix: suggestion

HIGH

[file:line] Issue (confidence: XX%) → Fix: suggestion

Summary: APPROVE | REQUEST CHANGES | COMMENT </output_format>

<ask_user> Use AskUserQuestion when: a finding is between 70-85% confidence (ambiguous) Ask: "Found {issue} at {file:line} (confidence {X}%). Intentional, or should I flag it?" Options: intentional — skip, flag it, investigate deeper </ask_user>

<verdict_rules> Review is finite because its purpose is AUTHORIZATION, not exhaustion. Approve once the change improves the health of the codebase, not once nothing else can be found. Nothing else can ever be found. (#204)

  • APPROVE: no finding clears the block bar. Open non-blocking comments do NOT prevent APPROVE — say the issue number out loud and approve. Forcing another round to re-check a nit costs more than the nit.
  • REQUEST CHANGES: at least one finding clears the block bar below.
  • COMMENT: findings worth saying, none blocking, and the author asked for a read rather than a decision.

<block_bar> A finding blocks only with ALL of:

  1. pasted output, not a described procedure
  2. a distance proof threshold cleared — distance sets how much evidence is needed, never whether a finding may block: d0 changed code fails · d1 violates a declared invariant · d2 pre-existing defect this change exposed, needs a user-visible consequence · d3+ needs outside assumptions, blocks only on an executed demonstration or a cited prior failure. Never auto-close d3; taste never clears it, a real outcome does.
  3. a named observable failure: predict what breaks and how we would see it
  4. violates the acceptance profile: tag the finding's dimension, and let the profile's blocks_at map decide the threshold for that dimension. A production-hardening finding on a demo is not a blocker however real it is, and a privacy finding on a demo IS one when the profile says so. The stage label never decides; the dimensions do.

Everything else is filed with its distance:N label under the quarantine milestone. Recurrence is signal, silence is a verdict.

Complexity clears the block bar only when changed code exceeds a declared budget, a regression diff names the increase, or the acceptance record requires the project gate and that armed path does not run it. A lizard result over JS/TS object-literal methods cannot support APPROVE or FAIL; it is NOT CHECKED until an AST-aware parser runs. </block_bar>

Read the acceptance record before reviewing: claims, declared invariants, and tradeoffs already accepted. If the commit carries one, it is FROZEN and adjudication will refuse a FAIL. Reopening takes new_failing_input, changed_dependency, missed_requirement, disproven_assumption, profile_changed, or owner_promotion. A new reviewer is not a reopen event. Never ask a reviewer whether criticism is complete; it cannot answer and will always say no.

An acceptance-profile review never ships ALONE. Pair it with one outcome-shaped discovery pass (DISCOVERY AXIS: outcome) that never receives the profile, invariants, or ACCEPT WHEN list. Measured (EXP-RTP1 variant M, #206): on a real defect the contract never names, the bounded reviewer caught it 0/20 and returned PASS 18/20, while the open reviewer caught it 18/19. The contract terminates review; alone it certifies what it was never told to see. </verdict_rules>

<on_complete> Emit findings as a kernel.verdict/v1 document and let the acceptance function decide. The reviewer never grades its own completeness.

python3 scripts/adjudicate.py findings.json --text --strict   # 0 PASS · 1 FAIL · 2 INVALID
agentdb write-end '{"command":"review","verdict":"X","critical":N,"high":N,"big5_violations":N,"quarantined":N}'

cannot_falsify is mandatory and non-empty. State what this review structurally could not see (no real device, conformance only, no live data, a suite that did not finish). Silence about coverage reads as coverage. </on_complete>

</skill>

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.