agentleFS
abigaylehabigayleh/claude-workflow-plugin/skills/diff-review/SKILL.md

diff-review

Skill0 starsChanged 46 days agoMITView on GitHub

Use after any code change, before committing. Reviews the working diff for correctness, security (injection, secret and data leaks, auth gaps), and performance (N+1 queries, unbounded fetches).

19 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use test-design.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • shabarabaSkill

    test-design

    Automatically design comprehensive E2E test cases for newly implemented vibing.nvim features. Use immediately after completing feature implementation (Phase 5.4) and before running E2E tests. Generates test scenarios covering Happy paths, Error cases, Edge cases, and Integration points with priority ranking (Critical/High/Medium/Low) and ready-to-use test code templates using e2e_helper.lua.

    Also in 3 projects that use this

The file

We split this skill into the rules it gives an agent

1 rule. 0 are common, 1 is distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 10 edited versions we read keep these.

  • 1

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Run this against every diff before committing.

    line 10

“Common” is measured: kept by at least 6 in 10 of the 10 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Diff review

Run this against every diff before committing.

git diff --staged    # or: git diff

Security

Work through ${CLAUDE_PLUGIN_ROOT}/conventions/security.md — the full checklist lives there so it can't drift between this skill and the code-quality-reviewer agent. Headline items:

  • Injection: SQL, HTML/XSS, command, path traversal
  • Secrets or PII in logs, error messages, client bundles, or committed files
  • Auth: new routes have the access control they should, and verify identity server-side rather than trusting a client-supplied id

Correctness

  • Logic errors, off-by-one, unhandled edge cases
  • Error paths: empty input, null, network failure
  • Does this break callers elsewhere? Grep for usages before deciding it doesn't.

Performance

  • N+1 queries; redundant loops or recomputation; needless re-renders
  • Unbounded fetches — missing pagination or limits
  • Memoization only where clearly warranted; don't over-apply

Scope

  • Files changed that shouldn't have been
  • New dependencies — flag every one, with what it's for
  • Debug leftovers: stray logging, commented-out code, hardcoded test values

Reporting

  • Flag issues with file:line.
  • If nothing is found, say so explicitly — silence reads as "not checked".
  • Call out security issues even when you also fix them. A silent patch means the user never learns the pattern was there.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.