agentleFS
YSAA1YSAA1/harness-workflow/skills/review/SKILL.md

review

Skill3 starsChanged 13 days agoMITView on GitHub

审查 diff、方案或完成声明,检查正确性、风险和验收证据。支持 WIP 的有限范围审阅;简单改动可由 implement 自审,verify 为本技能别名。

192 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use close-spec, design-with-images and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • dzhngSkill

    close-spec

    When a spec under specs/<feature>/ is done shipping (a write-spec build, or any planned task that produced a spec), archive it to specs/done/ and rewrite it from a build-plan into a durable rationale — the why, the principles, the invariants — pointing back to the real code for the how. Use when implementation has landed and the plan no longer matches what shipped, or the user says a feature/spec is finished. Pairs with [write-spec](../write-spec/SKILL.md) (the plan this closes) and [review](../review/SKILL.md) (run before closing).

    Also in 5 projects that use this

  • dzhngSkill

    design-with-images

    Explore UI and visual design with image generation, then iterate the real implementation against the user-selected concept. Use when brainstorming visual directions, offering mockup variants, or implementing an approved generated design; do not stop at the mockups or the first code approximation.

    Also in 5 projects that use this

  • LambenthanSkill

    daily-arxiv

    每日从 arXiv 拉取新论文,过滤相关性,auto-ingest 高优先级论文,检测 SOTA 更新

    Also in 5 projects that use this

  • LambenthanSkill

    exp-eval

    实验判决门:Review LLM 独立评判实验结果 → 4 种判决路径 → 自动更新 claims confidence、ideas status、graph edges

    Also in 5 projects that use this

  • +3 more from dzhng
  • +5 more from Lambenthan

The file

Files
SKILL.md

Review and verification

把问题发现和完成声明的证据核对放在一次评审中。审阅范围来自用户请求;WIP 可报告 findings,不必先完成实现才能审阅。

流程

  1. 明确审阅的 diff/版本、目标行为和所需验收。查看相关源码、测试、文档及已有证据,不以实现者的解释替代检查。同时搜出仓库里所有记载代码应如何写的文件作为标准源清单:CODING_STANDARDS.md、CONTRIBUTING.md 存在即必列,另含 lint/格式约定说明、所涉区域 ADR、CONTEXT.md 术语;工具已强制的规则跳过。
  2. 按具体故障路径检查正确性、合同、边界和回归;对照标准源检查规范,代码改动始终叠加 references/smell-baseline.md 的坏味基线(仓库无任何规范文档时也适用;纯文档改动不适用)。仓库明文规范优先,它认可的写法压制对应坏味;坏味永远是判断级(「疑似 Feature Envy」),不是硬违规,默认按 Minor 列出、不构成阻断。重要风险需要深入调查;无需凑 findings 或固定审查轮数。
  3. 当独立检查有价值且运行时允许时,使用有明确范围的只读 subagent;派多个审查轴(如规范轴与合同/正确性轴)时同一消息并行发出、前台等待,各轴报告分列汇总不合并不重排;缺少 subagent 本身不是失败。若用户或项目明确要求独立审查,该条件未满足需如实标记。环境有 cli-delegate 等外部委派技能时,可跨模型 CLI 做只读独立复核;其 result 是 claim,证据仍回主树复验。
  4. 将必需标准映射到 pass / fail / unknown。fresh evidence 指证据仍适用于当前相关代码、配置和输入;未受后续变更影响的实际输出可复用,不因换技能或已有 commit 自动失效。完成声明只以可运行检查的实际输出为 evidence;实现者复述或口头断言不算。
  5. 只补缺失或失效的检查。冷复核按证据歧义和风险使用,不要求再委派一名代理重跑同样测试。
  6. 判定具体完成声明:无未解决的阻断问题且必需标准全 pass 才可 ready。Critical/Important 的正确性、数据、权限或合同问题均需解决;非阻断建议单独列出。不为通过而删改测试或验收脚本,确需变更验收合同先经用户同意。
  7. findings 持久化(条件化):发现已全部当场处置 → 不落盘。存在跨会话待处置发现且项目有恢复面 → 发现清单(编号/位置/严重度)写进本轨道计划文件,较多或需独立追踪时落 docs/reviews/YYYY-MM-DD--<topic>-review.md;这算一次阶段变化,本轨道 tracks/<id>.md 的 Evidence: 链接清单并写 ready 判定,Next: 写待修项(清单本身不进 .harness/,见 ../writing-for-agents/references/recovery_surface_policy.md)。无恢复面项目维持会话内交接,不新建状态文件。

边界

  • 只要求 review 时不修改代码;用户已授权修复时,记录发现(跨会话时按流程 7 落状态面)后可转 implement 修复,再复核受影响部分,无需重新索要授权。
  • WIP、局部检查或缺环境时给出有限范围结果,不将 unknown 算通过。
  • 低风险修改允许轻量自审完成。

输出

findings 分两节分列,不合并不重排:「正确性与风险」(可行动发现:严重度、位置、触发条件、影响;规范类发现注明出处——标准源文件与条款,或基线坏味名——并区分硬违规与判断级)与「验收证据」(必需标准 pass/fail/unknown 映射);然后给剩余缺口和结论。repo 未文档化验收标准时,正确性轴仍按通用缺陷类别(边界、合同、回归、数据/权限)审,不以「无标准」跳过。需要追踪时使用 REVIEW / VERIFICATION / READY,并注明审查方式为 self、subagent 或外部审阅及其范围;不强制空表。REVIEW / VERIFICATION / READY 是会话 token,不替代持久层——跨会话待处置发现按流程 7 持久化。

按需读取

  • 深入对抗审查:references/adversarial-reviewer-prompt.md、references/attack-taxonomy.md。
  • 坏味基线(第 2 步必读):references/smell-baseline.md。
  • 验收证据:references/evidence-ladder.md;证据解释有争议时读 references/cold-verifier-prompt.md。
  • 对应风险存在时读 references/cross-cutting-anti-patterns.md、references/premature-completion-patterns.md;工具缺口见 references/capability-recommendations.md。

Recommended next skill

  • 已完成:按项目要求提交;仅有本次文档/恢复整理需求时用 cleanup,否则结束。
  • 已授权修复:implement;未知根因:diagnose。
  • 超出目标的建议作为后续事项,不自动开启新任务或 harness-builder。

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.