agentleFS
willianbswillianbs/skills/refactoring-advisor/SKILL.md

refactoring-advisor

Skill0 starsChanged 4 months agoMITView on GitHub

Identifies safe, high-value refactors that preserve externally observable behavior. Use for debt, smells, or “clean this up” asks. Never changes behavior silently or recommends large rewrites without characterization tests and incremental plan.

1 other project uses a version of this.

Adopted by

Most recently taken up by

The file

We split this skill into the rules it gives an agent

4 rules. About 0 are common, 3 are distinctive, and 1 is very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈3

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 1

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Very specific:

    Prefer rename/extract/module boundaries over framework swaps.

    line 46
  2. Distinctive:

    Never mix refactors with unrelated features.

    line 92
  3. Distinctive:

    Never recommend Big Bang rewrites as the default.

    line 93
  4. Distinctive:

    Never claim “safe” without a validation story.

    line 94

≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Purpose

Recommend behavior-preserving improvements prioritized by value × risk.

When to Use / When NOT to Use

Use when: maintainability pain, smells, prep for a feature, explicit refactor ask.

Do not use when: active incident (defect-analyst first); greenfield feature design; user wants a rewrite disguised as cleanup without approval.

Preconditions

Target code accessible. Prefer CONTEXT_PACK for patterns/ADRs.

Inputs / Outputs

Inputs: paths/hotspots, optional defect/debt history, CONTEXT_PACK, ADR_COMPLIANCE.

Outputs: refactor recommendations report (feeds delivery-planner if approved).

Upstream / Downstream

Upstream: code-reviewer, engineering-mentor, quality-gate debt notes.

Downstream: delivery-planner (if work approved), test-strategy-designer (characterization), feature-implementer.

Core Principles

  1. Behavioral equivalence is mandatory.
  2. Value = change frequency × complexity × defect history (qualitative OK if cited).
  3. Characterization tests required before Medium+ risk refactors.
  4. Incremental PR-sized steps.
  5. Respect ADRs.
  6. Reject drive-by cleanup in unrelated PRs.
  7. Prefer rename/extract/module boundaries over framework swaps.

Process

  1. Identify smells that matter (dead code, duplication, god objects, leaky boundaries)—ignore pedantry.
  2. Score value vs risk (Low/Medium/High).
  3. For Medium+ risk: require characterization/golden tests in the plan before structural change.
  4. Propose incremental sequence with validation after each step.
  5. Flag ADR impact → adr-enforcer.
  6. Explicitly reject suggestions that change UX/API contracts unless user approves a behavior change (then it’s a feature, not a refactor).

Evidence Requirements

Cite files and concrete smell. Value claims need a reason (churn, bugs, complexity).

Stop Conditions / Failure Modes

ConditionAction
Cannot preserve behavior safelyBlock / recommend rewrite as feature
ADR conflictHand off adr-enforcer
User wants refactor inside unrelated feature PRReject; separate PR

Severity + Confidence

Align to portfolio severity. Priority: Immediate | Next | Backlog mapped from Critical/High/Medium/Low.

Output Contract

## REFACTOR_ADVICE
Targets: ...
Recommendations (priority ordered):
  - smell, value, risk, characterization needed, steps, validation
ADR impact: ...
Decision: Proceed | ProceedWithConditions | Revise | Block

Handoffs

  • delivery-planner — sequence approved refactors
  • test-strategy-designer — characterization coverage
  • adr-enforcer — architectural moves

Never

  • Never mix refactors with unrelated features.
  • Never recommend Big Bang rewrites as the default.
  • Never claim “safe” without a validation story.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.