agentleFS
weselbenweselben/RooForge/skills/finishing-a-development-branch/SKILL.md

finishing-a-development-branch

Skill4 starsChanged 3 months agoApache-2.0View on GitHub

Finish a development branch — commit, verify, push, open PR. PR is the only path. Load when implementation is complete and tests pass. Triggers: \"finish this branch\", \"wrap up\", \"open a PR\".

  • Commits and pushes

187 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use chinese-code-review, chinese-commit-conventions and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • Leodorareluctant259Skill

    chinese-code-review

    中文代码审查规范——在保持专业严谨的同时,用符合国内团队文化的方式给出有效反馈

    Also in 8 projects that use this

  • Leodorareluctant259Skill

    chinese-commit-conventions

    中文 Git 提交规范 — 适配国内团队的 commit message 规范和 changelog 自动化

    Also in 8 projects that use this

  • obraSkill

    diagnosing-superpowers

    Use when a superpowers session went wrong and your human partner wants to know why — repeated work, ignored plans, stumbles, poor results, a skill that didn't fire, "it took too long", "why is it so expensive", "what is it doing" — or wants to build a bug report for the superpowers maintainers, for the current session or a past one identified by id or path, on any harness.

    Also in 20 projects that use this

  • kntismSkill

    condition-based-waiting

    Use when tests have race conditions, timing dependencies, or inconsistent pass/fail behavior - replaces arbitrary timeouts with condition polling to wait for actual state changes, eliminating flaky tests from timing guesses

    Also in 3 projects that use this

  • MicrosoftSkill

    testing-anti-patterns

    Use when writing or changing tests, adding mocks, or tempted to add test-only methods to production code - prevents testing mock behavior, production pollution with test-only methods, and mocking without understanding dependencies

    Also in 4 projects that use this

  • MicrosoftSkill

    root-cause-tracing

    Use when errors occur deep in execution and you need to trace back to find the original trigger - systematically traces bugs backward through call stack, adding instrumentation when needed, to identify source of invalid data or incorrect behavior

    Also in 5 projects that use this

  • +3 more from Leodorareluctant259

The file

We split this skill into the rules it gives an agent

5 rules. 0 are common, 4 are distinctive, and 1 is very specific to this project.

  • 0

    Common

    Most of the 173 edited versions we read keep these.

  • 4

    Distinctive

    This author's own choices. Worth a look.

  • 1

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Leading word: done when: Every step ends on a checkable criterion.

    line 17
  2. Distinctive:

    Commit list (SHA + subject, one per line)

    line 30
  3. Distinctive:

    Test status (command run, pass/fail)

    line 31
  4. Very specific:

    Run the full suite. If tests fail, report failures and stop — everything below comes after a green suite.

    line 40
  5. Distinctive:

    After all branches merged, run full suite on the merged result.

    line 74

“Common” is measured: kept by at least 6 in 10 of the 173 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Finishing a Development Branch

Pick the variant that matches your role:

RoleVariant
Subagent in an assigned worktreeSubagent Variant — commit, verify, report
Coordinator after swarm completesCoordinator Variant — push + open PR
Solo work, no swarmCoordinator Variant, single branch

Leading word: done when. Every step ends on a checkable criterion.

Hard rule: NEVER merge to main/master. Main receives changes only via pull request.

Subagent Variant

You run inside a worktree the coordinator assigned. You do not merge, push, or present options.

  1. Commit all work. Stage everything; use caveman-commit + conventional-commits.
  2. Verify a clean tree. git status must show nothing to commit, working tree clean.
  3. Run the test suite. npm test / cargo test / pytest / go test ./.... If tests fail, fix or report verbatim — do not claim completion on a red suite.
  4. Report these four items:
    • Branch name
    • Commit list (SHA + subject, one per line)
    • Test status (command run, pass/fail)
    • One-paragraph summary of what changed and why

Done when: the four-item report is delivered. Commits already live in the shared object store — the coordinator handles the rest.

Coordinator Variant

1. Verify tests

Run the full suite. If tests fail, report failures and stop — everything below comes after a green suite. Load verification-before-completion — "tests passed earlier" is not evidence.

Done when: suite is green on the tree you're about to integrate.

2. Detect environment

GIT_DIR=$(cd "$(git rev-parse --git-dir)" 2>/dev/null && pwd -P)
GIT_COMMON=$(cd "$(git rev-parse --git-common-dir)" 2>/dev/null && pwd -P)
WORKTREE_PATH=$(git rev-parse --show-toplevel)
StateMeaning
GIT_DIR == GIT_COMMONNormal repo, no worktree cleanup needed
GIT_DIR != GIT_COMMON, named branchWorktree — cleanup is provenance-based (Step 5)
GIT_DIR != GIT_COMMON, detached HEADExternally managed — leave in place

3. Confirm base branch

The base is whatever the forked work split from — integration branch for swarm work. If unknown, ask: "This branch split from <best guess> — correct?" Confirm before merging.

4. Merge each subagent branch

For each branch a subagent reported (cross-reference subagent-driven-development):

MAIN_ROOT=$(git -C "$(git rev-parse --git-common-dir)/.." rev-parse --show-toplevel)
cd "$MAIN_ROOT"
git checkout <integration-branch>
git merge --squash <task-branch>
git commit -m "<conventional-commit>"

After all branches merged, run full suite on the merged result. Red: stop, leave everything in place, investigate (nothing pushed, local + recoverable).

If merge conflicts occur during merge, load resolving-merge-conflicts — it handles steps 1–3, and for multi-branch conflicts delegates to subagent-driven-development to unblock in parallel.

5. Push and create PR

git push -u origin <integration-branch> (detached: git push origin HEAD:refs/heads/<new>), follow creating-pull-requests. Keep worktrees for PR feedback.

Done when: PR URL returned, AI disclosure in place, worktrees preserved for PR feedback.

6. Cleanup workspaces

Runs only if work is discarded (explicit request). All other paths preserve worktrees.

  • GIT_DIR == GIT_COMMON: nothing to clean.
  • .worktrees/ or worktrees/: git worktree remove "$path" && git worktree prune.
  • Otherwise: host environment owns it — leave in place.

Done when: .worktrees/ holds only in-flight work.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.