agentleFS
tatashbartatashbar/Economic-Modeling-Studio/.agents/skills/code-review/SKILL.md

code-review

Skill4 starsChanged 6 days agoMITView on GitHub

Reviews model and pipeline code for correctness, numerical soundness, reproducibility and standards compliance.

194 other projects use a version of this, 1 of them edited.

Adopted by

Most recently taken up by

Used with

Projects with it also use close-spec, design-with-images and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • dzhngSkill

    close-spec

    When a spec under specs/<feature>/ is done shipping (a write-spec build, or any planned task that produced a spec), archive it to specs/done/ and rewrite it from a build-plan into a durable rationale — the why, the principles, the invariants — pointing back to the real code for the how. Use when implementation has landed and the plan no longer matches what shipped, or the user says a feature/spec is finished. Pairs with [write-spec](../write-spec/SKILL.md) (the plan this closes) and [review](../review/SKILL.md) (run before closing).

    Also in 5 projects that use this

  • dzhngSkill

    design-with-images

    Explore UI and visual design with image generation, then iterate the real implementation against the user-selected concept. Use when brainstorming visual directions, offering mockup variants, or implementing an approved generated design; do not stop at the mockups or the first code approximation.

    Also in 5 projects that use this

  • PydanticSkill

    add-new-model

    Add support for a newly-released language or image generation model in pydantic-ai (e.g. openai:gpt-5.6, anthropic:claude-sonnet-5, openai:gpt-image-2). Use when a provider ships a new model id and you need to wire literals, profile flags, adapters, and tests to recognize it. Handles SDK-lag, gateway list conventions, capability probing, and direct image-model geometry.

    Also in 9 projects that use this

  • transitive-bullshitSkill

    compare-screenshots

    Compare screenshots against the intended design, distinguishing approved references from historical baselines. Use for iterative implementation matching, before/after visual review, objective image telemetry, or checking a lone capture for flat, empty, or badly framed content.

    Also in 5 projects that use this

  • Microsoft AzureSkill

    azsdk-common-apiview-feedback-resolution

    Analyze and resolve APIView review feedback on Azure SDK PRs. **UTILITY SKILL**. USE FOR: APIView comments, API review feedback, SDK API surface changes. DO NOT USE FOR: general code review, non-APIView feedback. INVOKES: azure-sdk-mcp:azsdk_apiview_get_comments, azure-sdk-mcp:azsdk_customized_code_update, azure-sdk-mcp:azsdk_typespec_delegate_apiview_feedback, azure-sdk-mcp:azsdk_run_typespec_validation, azure-sdk-mcp:azsdk_package_generate_code.

    Also in 6 projects that use this

  • Microsoft AzureSkill

    azsdk-common-generate-sdk-locally

    Generate and finalize Azure SDKs locally from TypeSpec, including build, checks, tests, changelog, metadata, and version updates by default. WHEN: "generate SDK locally", "build SDK", "run SDK tests", "run CI checks", "validate package", "run checks", "update changelog", "fix SDK build errors", "resolve SDK generation errors", "customize TypeSpec", "rename SDK client", "rename SDK model", "hide operation from SDK", "fix analyzer errors", "resolve customization drift", "create subclient", "update metadata", "update version". INVOKES: azsdk_verify_setup, azsdk_package_generate_code, azsdk_package_build_code, azsdk_package_run_check, azsdk_package_run_tests, azsdk_customized_code_update, azsdk_package_update_changelog_content, azsdk_package_update_metadata, azsdk_package_update_version.

    Also in 6 projects that use this

  • +4 more from dzhng
  • +2 more from Azure

The file

We split this skill into the rules it gives an agent

10 rules. 0 are common, 7 are distinctive, and 3 are very specific to this project.

  • 0

    Common

    Most of the 183 edited versions we read keep these.

  • 7

    Distinctive

    This author's own choices. Worth a look.

  • 3

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Very specific:

    If a required input is ABSENT, that part is NOT ASSESSED — NO DATA: do not estimate or invent it.

    line 25
  2. Very specific:

    Collaboration: Follow .claude/docs/collaboration-protocol.md: ask questions first, present options, get approval before writing files, and …

    line 27
  3. Very specific:

    Read the code against the spec and .claude/rules/ for the path

    line 44
  4. Distinctive:

    Check numerics: tolerances, conditioning, units, timing conventions

    line 46
  5. Distinctive:

    Check reproducibility: seeds, versions, hard-coded paths and parameters

    line 47
  6. Distinctive:

    Check tests: coverage of identities, steady state and edge cases

    line 48
  7. Distinctive:

    After scope: confirm files and depth

    line 52
  8. Distinctive:

    After findings: agree fixes and owners

    line 53
  9. Distinctive:

    No hard-coded parameters or paths in model code.

    line 67
  10. Distinctive:

    Every finding states its consequence and a concrete fix

    line 68

“Common” is measured: kept by at least 6 in 10 of the 183 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md
<!-- Generated from .claude/skills/code-review/SKILL.md by tools/sync_agents.py. Edit the source, then run the script. -->

/code-review — Code Review

Category: Validation & QA · Primary agent: python-julia-engineer

Reviews model and pipeline code for correctness, numerical soundness, reproducibility and standards compliance.

Arguments: whatever the user wrote after the command name.

Purpose

Review model and pipeline code for what matters in economic modeling: does it implement the specification correctly (equations, timing, units), is it numerically sound, can it be reproduced, and is it tested? The output is a list of findings by severity with concrete fixes.

Use it when model code, data pipelines or analysis scripts change, before validation, or when results look suspicious.

Do not use it when a full independent validation is required (/validate-model).

Before you start

  1. Check required inputs. For each input below record FOUND or ABSENT (never 'assumed'):
    • Code at path If a required input is ABSENT, that part is NOT ASSESSED — NO DATA: do not estimate or invent it; name what is missing and which skill produces it. If all required inputs are absent, stop and say so.
  2. Check confidentiality. Identify the data classification level of the inputs (.claude/docs/confidentiality-and-ai-use.md). Do not proceed with restricted or confidential data in a way the policy does not allow.
  3. Collaboration. Follow .claude/docs/collaboration-protocol.md: ask questions first, present options, get approval before writing files, and update production/session-state/active.md after each approved section.

Agents

  • python-julia-engineer — primary agent; coordinates the work and integrates results
  • numerical-methods-specialist — Specializes in numerical methods
  • reproducibility-engineer — Guarantees reproducibility

Each agent is defined in .claude/agents/<name>.md. If your tool runs subagents, run these agents as subagents, in parallel where the steps are independent; otherwise read each agent's file and apply its instructions in turn. Subagents only write to the paths named in your instructions.

Key design decisions (present options, let the user choose)

DecisionTypical optionsWhat it changes
Scopewhole model, changed files, specific functionEffort
Depthread-through, read plus test runs, partial re-implementationAssurance
Standards.claude/rules/ for the path, project conventionsCriteria

Workflow

  1. Read the code against the spec and .claude/rules/ for the path
    • Equation-by-equation comparison with the specification; timing of stocks
  2. Check numerics: tolerances, conditioning, units, timing conventions
  3. Check reproducibility: seeds, versions, hard-coded paths and parameters
  4. Check tests: coverage of identities, steady state and edge cases
  5. List findings by severity with concrete fixes

Checkpoints with the user

  • After scope: confirm files and depth
  • After findings: agree fixes and owners

Common pitfalls

  • Reviewing style while missing equation errors
  • Ignoring unit and scale conventions
  • Accepting tests that only check that code runs
  • Missing silent failures (solver exits treated as convergence)

Output

validation/code-reviews/<name>.md

The review lists findings by severity, with file and line, the problem, its consequence and the fix.

Gate / verdict

  • No hard-coded parameters or paths in model code; tests exist for identities
  • Every finding states its consequence and a concrete fix

Suggested next steps

  • /validate-model

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.