agentleFS
stjarnstromstjarnstrom/spec-system/skills/review/SKILL.md

review

Skill0 starsChanged 45 days agoMITView on GitHub

Review a branch, PR, or diff on two axes that are never merged — spec (statement IDs) and standards (correctness and code quality) — or work through review comments someone left. Use when the user asks to review changes, a PR, or "since <ref>"; before merging; or when review feedback arrives, from a person or a tool.

192 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use close-spec, design-with-images and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • dzhngSkill

    close-spec

    When a spec under specs/<feature>/ is done shipping (a write-spec build, or any planned task that produced a spec), archive it to specs/done/ and rewrite it from a build-plan into a durable rationale — the why, the principles, the invariants — pointing back to the real code for the how. Use when implementation has landed and the plan no longer matches what shipped, or the user says a feature/spec is finished. Pairs with [write-spec](../write-spec/SKILL.md) (the plan this closes) and [review](../review/SKILL.md) (run before closing).

    Also in 5 projects that use this

  • dzhngSkill

    design-with-images

    Explore UI and visual design with image generation, then iterate the real implementation against the user-selected concept. Use when brainstorming visual directions, offering mockup variants, or implementing an approved generated design; do not stop at the mockups or the first code approximation.

    Also in 5 projects that use this

  • LambenthanSkill

    daily-arxiv

    每日从 arXiv 拉取新论文,过滤相关性,auto-ingest 高优先级论文,检测 SOTA 更新

    Also in 5 projects that use this

  • LambenthanSkill

    exp-eval

    实验判决门:Review LLM 独立评判实验结果 → 4 种判决路径 → 自动更新 claims confidence、ideas status、graph edges

    Also in 5 projects that use this

  • +3 more from dzhng
  • +5 more from Lambenthan

The file

Files
SKILL.md

Two jobs: giving a review, and receiving one.

Giving a review

  1. Pin the fixed point. The base ref: what the user named, else the merge-base with the default branch. The range must hold commits — node ${CLAUDE_PLUGIN_ROOT}/scripts/run.mjs package - <base> writes the package (commits, stat, diff) and refuses an empty range. Uncommitted work gets committed first, or reviewed with the spec-review skill, which reads the working tree.
  2. Two axes, in parallel, in separate subagents — spec-system:reviewer in single-axis mode, both dispatched in one message, each given the package path, its axis, and its procedure file: ${CLAUDE_PLUGIN_ROOT}/skills/spec-review/SKILL.md for the spec axis, ${CLAUDE_PLUGIN_ROOT}/skills/review/standards.md for standards.
    • Spec axis. With a spec layer, the procedure is spec-system:spec-review: owns scopes the diff, and every finding cites a statement ID — CONTRADICTS, DRIFT, RESOLVES. Without one, the spec is the originating plan, issue, or brief: work it asked for that is missing, work it did not ask for, and work that looks done but is wrong — each quoting the line it rests on.
    • Standards axis. Correctness first, then quality, per standards.md. The repo's own documented standards outrank the baseline there. Only what you would block the merge for is Critical or Important; each finding gives file:line, why it is wrong, and how to show it fails.
  3. Report side by side, under ## Spec and ## Standards. The axes are never merged or ranked against each other: a spec contradiction and a race condition are different kinds of wrong, and the user weighs them. End each axis with its count and its worst finding.

A reviewer shares nothing with the author's context — that is the point of a subagent here. Reviewing your own work in the same context is confirmation, not review.

Receiving a review

Review comments are claims to check, not orders.

  1. Read all of them first. Restate any you do not understand, and ask about every unclear one before changing anything — they are often related.
  2. Check each against the code. Does the problem exist? Would the suggestion break something else? Before building out a feature a reviewer asks for, check whether anything uses it; if nothing does, propose removing it instead.
  3. Spec-axis findings are decisions, not tweaks. CONTRADICTS or DRIFT means amend the spec (spec-system:spec-amend) or revert the behaviour. Pick one explicitly; never paper over it.
  4. Answer with substance. Where the reviewer is right, fix it — one item at a time, each behaviour change with its test (spec-system:tdd), the suite green after. Where they are wrong, say why with evidence (file:line, a command's output). State what changed; skip the thanks and the praise.
  5. Posting replies is outward-facing. Draft the replies; post them to the PR (gh api repos/<owner>/<repo>/pulls/<n>/comments/<id>/replies) only when the user says to.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.