agentleFS
sherificansherifican/Agent-FleetOps/skills/generate-review-fix-loop/SKILL.md

generate-review-fix-loop

Skill34 starsChanged 37 days agoMITView on GitHub

Improve a non-trivial code change through separate generation, review, and repair roles.

The file

We split this skill into the rules it gives an agent

3 rules. About 0 are common, 3 are distinctive, and 0 are very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈3

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Use a coding-oriented local model for draft and repair.

    line 18
  2. Distinctive:

    Use a distinct audit-oriented model for review.

    line 19
  3. Distinctive:

    Prefer a more thorough reviewer for high-risk or edge-case-dense changes.

    line 20

≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Generate → Review → Fix Loop

Overview

For non-trivial implementation work, use three distinct stages: a coding model drafts, an independent audit model compares the draft with the contract, and the coding model revises from that review. This reduces the chance that a single model overlooks its own edge cases; it does not replace a real test.

Procedure

  1. Give the generator the full task contract, relevant code, constraints, and expected verification.
  2. Give a different reviewer the task contract and generated diff. Ask for concrete defects, missing cases, and unsupported assumptions. For each finding, state what must be true on that path after the repair, not only the symptom. Mark each finding CONFIRMED only if the reviewer executed the case and recorded observed values, otherwise SUSPECTED (reasoned only, including could-not-execute). Keep suspected findings in the review; do not apply them as repairs until confirmed or shown red by a test. See specs/the-silent-clear-problem.md.
  3. Give the generator the review and require a revised final result. Preserve the review and final output. Repair only concrete defects, missing cases, and unsupported assumptions. Record and leave unapplied findings that are only style or idiom. A same-file fact the change alters remains in scope.
  4. Functionally test the final result in the repository before reporting it as verified.

Role selection

  • Use a coding-oriented local model for draft and repair.
  • Use a distinct audit-oriented model for review; do not have the generator self-review as the only gate.
  • Prefer a more thorough reviewer for high-risk or edge-case-dense changes.

Pitfalls

  • Shipping the draft rather than the repaired output.
  • Treating review as proof of runtime behavior.
  • Spending the multi-stage process on a trivial one-line edit when direct verification is cheaper.
  • Reviewing only the diff when the change alters a fact the same file asserts elsewhere. The reviewer's unit is then the file, and the search covers the old value and the subject's constraint language, not the old value alone. See specs/rigor-spectrum.md lesson F.

Verification checklist

  • Generator and reviewer were separate roles.
  • The repair addressed the review rather than merely restating it.
  • The final revision, not an earlier draft, was tested.
  • Every finding carried its CONFIRMED/SUSPECTED label, and each unapplied finding was recorded as either style or idiom only, or SUSPECTED and not yet confirmed or shown red by a test.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.