agentleFS
ryanportfolioryanportfolio/Harness-Firmware/.agents/skills/external-review/SKILL.md

external-review

Skill1 starsChanged 21 days agoMITView on GitHub

Use on explicit $external-review invocation or when a launcher prompt names this file. Single-context leaf review of an exact diff scope: no agents, nested reviews, or edits.

We split this skill into the rules it gives an agent

5 rules. About 0 are common, 5 are distinctive, and 0 are very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈5

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    If the scope cannot be resolved to exact revisions and content, report that and stop.

    line 21
  2. Distinctive:

    When the diff extracts repeated operations or changes a shared boundary, read selective shared-code refactoring and apply its caller and …

    line 35
  3. Distinctive:

    Read the changed code and its relevant callers before reporting.

    line 41
  4. Distinctive:

    No file edits, no Git writes, no publication (comments, PRs, pushes, messages).

    line 55
  5. Distinctive:

    Keep it concise and in this order, so the launcher can parse it.

    line 63

≈ “Common” is an estimate: at least 1 in 5 of the 308,232 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

External leaf review

One reviewer, one fresh context, one exact scope. The launcher that invoked this skill owns dispatch, verification of findings, and any fixes. Single-context review is the designed mode here, not a gap: do not suggest or mention spawning sub-reviewers as a missing step.

Scope identity

Resolve exact base and head SHAs from the invocation, or from the stated selector (branch, commit, PR, uncommitted changes). When head differs from the checked-out HEAD, read head content with git show <head>:<path> and the change with git diff <base> <head>, not from the working tree. Dirty and untracked content is in scope only when the selector includes the working tree, as in an uncommitted review; then record the relevant paths with content hashes. State the scope before reviewing. If the scope cannot be resolved to exact revisions and content, report that and stop; do not guess a base, widen to unrelated history, or review a different diff.

Review areas

Cover all five areas in this order within the one context:

  1. Correctness and types.
  2. Data flow, compatibility, and failure handling.
  3. Performance, security, and observability.
  4. Missing integration and cleanup: callers, config, docs, tests, and generated files the change should have touched.
  5. Project-specific rules. AGENTS.md governs Codex; shared product constraints apply regardless of author. Do not import Claude-only session policies as Codex obligations.

When the diff extracts repeated operations or changes a shared boundary, read selective shared-code refactoring and apply its caller and invariant checks.

Evidence

Read the changed code and its relevant callers before reporting. Run an affordable reproduction when it resolves uncertainty, using read-only commands only. The run may be in a read-only sandbox: a check that needs writes, installs, or network is reported as unavailable, never as passed. Missing access means a check was unavailable, not that the code passed.

Report credible uncertain findings with their uncertainty. Do not invent issues or promote style preferences into correctness findings. Finding nothing is valid.

Hard limits

  • Leaf reviewer. Spawn no agents and start no subprocess review or nested review; never run codex exec or any other reviewer CLI.
  • Invoke no other skill or review workflow.
  • No file edits, no Git writes, no publication (comments, PRs, pushes, messages).
  • Current system, developer, sandbox, approval, and user instructions win.

This is a fresh-context review by one reviewer. Do not claim multi-reviewer coverage or vendor independence.

Report

Keep it concise and in this order, so the launcher can parse it. If the runtime prescribes an output schema, follow it and include these fields.

  1. Scope: <base>..<head>, plus in-scope dirty or untracked paths with hashes, or clean.
  2. Findings, ordered by severity (P0 critical, blocks release; P1 high; P2 medium; P3 low). Each has: location (path:line), trigger, consequence, evidence, proposed fix, severity, and confidence (high, medium, low). Keep severity separate from confidence.
  3. Checked and fine: areas and specific risks inspected with no finding.
  4. Unavailable checks: what could not be run or read, and why.
  5. Verdict: one line.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

Reviews can't be read right now.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.