agentleFS
robertkarlrobertkarl/rkstack/review/SKILL.md

gstack-review

Skill0 starsChanged 8 months agoMITView on GitHub

Pre-landing PR review. Analyzes diff against the base branch for SQL safety, LLM trust boundary violations, conditional side effects, and other structural issues. Use when asked to "review this PR", "code review", "pre-landing review", or "check my diff". Proactively suggest when the user is about to merge or land code changes. (gstack)

  • Installs packages

1 other project uses a version of this, 1 of them edited.

Adopted by

Most recently taken up by

The file

Show its rules and text

We split this skill into the rules it gives an agent

127 rules. About 0 are common, 85 are distinctive, and 42 are very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈85

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 42

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Very specific:

    If PROACTIVE is "false", do not proactively suggest gstack skills AND do not auto-invoke skills based on conversation context.

    line 62
  2. Very specific:

    If SKILL_PREFIX is "true", the user has namespaced skill names.

    line 68
  3. Very specific:

    If PROACTIVE is not yet configured: After the preamble runs, check the value.

    line 73
  4. Distinctive:

    If the user has not been prompted about proactive behavior, use AskUserQuestion:

    line 74
  5. Very specific:

    If A: run ~/.claude/skills/gstack/bin/gstack-config set proactive true If B: run ~/.claude/skills/gstack/bin/gstack-config set proactive …

    line 84
  6. Very specific:

    If B: run ~/.claude/skills/gstack/bin/gstack-config set proactive false

    line 85
  7. Very specific:

    If HAS_ROUTING is no AND ROUTING_DECLINED is false: Check if a CLAUDE.md file exists in the project root.

    line 87
  8. Distinctive:

    Check if a CLAUDE.md file exists in the project root.

    line 88
  9. Distinctive:

    If A: Append this section to the end of CLAUDE.md:

    line 100
  10. Distinctive:

    Start from lived experience.

    line 134
  11. Distinctive:

    No em dashes. Use commas, periods, or "..." instead.

    line 145
  12. Distinctive:

    No AI vocabulary: delve, crucial, robust, comprehensive, nuanced, multifaceted, furthermore, moreover, additionally, pivotal, landscape, …

    line 146
  13. Distinctive:

    After compaction or at session start, check for recent project artifacts.

    line 154
  14. Distinctive:

    If artifacts are listed, read the most recent one to recover context.

    line 175
  15. Very specific:

    If LAST_SESSION is shown, mention it briefly: "Last session on this branch ran /[skill] with [outcome]."

    line 177
  16. Distinctive:

    Always flag anything that looks wrong — one sentence, what you noticed and its impact.

    line 204
  17. Very specific:

    Before building anything unfamiliar, search first.

    line 208
  18. Distinctive:

    When completing a skill workflow, report status using one of:

    line 213
  19. Distinctive:

    If you have attempted a task 3 times without success, STOP and escalate.

    line 224
  20. Distinctive:

    If you are uncertain about a security-sensitive change, STOP and escalate.

    line 225
  21. Distinctive:

    If the scope of work exceeds what you can verify, STOP and escalate.

    line 226
  22. Distinctive:

    Before completing, reflect on this session:

    line 238
  23. Distinctive:

    If yes, log an operational learning for future sessions:

    line 244
  24. Distinctive:

    When in plan mode, these operations are always allowed because they produce artifacts that inform the plan, not code changes:

    line 254
  25. Distinctive:

    When you are in plan mode and about to call ExitPlanMode:

    line 269
  26. Very specific:

    Check if the plan file already has a ## GSTACK REVIEW REPORT section.

    line 271
  27. Distinctive:

    If it DOES — skip (a review skill already wrote a richer report).

    line 272
  28. Distinctive:

    If it does NOT — run this command:

    line 273
  29. Very specific:

    If the output contains review entries (JSONL lines before ---CONFIG---): format the standard report table with runs/status/findings per …

    line 281
  30. Very specific:

    If the output is NO_REVIEWS or empty: write this placeholder table:

    line 284
  31. Very specific:

    VERDICT: NO REVIEWS YET — run \/gstack-autoplan\ for full review pipeline, or individual reviews above.

    line 296
  32. Distinctive:

    If the URL contains "github.com" → platform is GitHub

    line 307
  33. Distinctive:

    If the URL contains "gitlab" → platform is GitLab

    line 308
  34. Very specific:

    If that fails: git rev-parse --verify origin/main 2>/dev/null → use main

    line 327
  35. Distinctive:

    If all fail, fall back to main.

    line 330
  36. Distinctive:

    Run git branch --show-current to get the current branch.

    line 346
  37. Distinctive:

    If on the base branch, output: "Nothing to review — you're on the base branch or have no changes against it." and stop.

    line 347
  38. Very specific:

    Run git fetch origin <base> --quiet && git diff origin/<base> --stat to check if there's a diff.

    line 348
  39. Distinctive:

    Before reviewing code quality, check: did they build what was requested — nothing more, nothing less?

    line 354
  40. Very specific:

    Read TODOS.md (if it exists).

    line 356
  41. Very specific:

    Read commit messages (git log origin/<base>..HEAD --oneline).

    line 357
  42. Very specific:

    Run git diff origin/<base>...HEAD --stat and compare the files changed against the stated intent.

    line 360
  43. Distinctive:

    Test coverage gaps for stated requirements

    line 371
  44. Distinctive:

    Conversation context (primary): Check if there is an active plan file in this conversation.

    line 389
  45. Distinctive:

    Content-based search (fallback): If no plan file is referenced in conversation context, search by content:

    line 391
  46. Distinctive:

    Validation: If a plan file was found via content-based search (not conversation context), read the first 20 lines and verify it is relevant …

    line 411
  47. Distinctive:

    No plan file found → skip with "No plan file detected — skipping."

    line 414
  48. Distinctive:

    Read the plan file. Extract every actionable item — anything that describes work to be done.

    line 419
  49. Distinctive:

    No items found: If the plan contains no extractable actionable items, skip with: "Plan file contains no actionable items — skipping …

    line 437
  50. Very specific:

    Run git diff origin/<base>...HEAD and git log origin/<base>..HEAD --oneline to understand what was implemented.

    line 445
  51. Distinctive:

    When no plan file is detected, use these secondary intent sources:

    line 484
  52. Very specific:

    Commit messages: Run git log origin/<base>..HEAD --oneline.

    line 486
  53. Distinctive:

    TODOS.md: If it exists, check for items related to this branch or recent dates

    line 490
  54. Very specific:

    PR description: Run gh pr view --json body -q .body 2>/dev/null for intent context

    line 491
  55. Very specific:

    Check git log origin/<base>..HEAD --oneline for commits that suggest the work was started, attempted, or reverted

    line 499
  56. Distinctive:

    Read the relevant code to understand what was built instead

    line 500
  57. Distinctive:

    Update the scope drift output to include plan file context:

    line 546
  58. Distinctive:

    No plan file found: Use commit messages and TODOS.md as fallback sources (see above).

    line 558
  59. Distinctive:

    If the file cannot be read, STOP and report the error: Do not proceed without the checklist.

    line 564
  60. Very specific:

    Read .claude/skills/review/greptile-triage.md and follow the fetch, filter, classify, and escalation detection steps.

    line 570
  61. Very specific:

    Run git diff origin/<base> to get the full diff.

    line 586
  62. Distinctive:

    Search for relevant learnings from previous sessions:

    line 592
  63. Very specific:

    If CROSS_PROJECT is unset (first time): Use AskUserQuestion:

    line 604
  64. Distinctive:

    If learnings are found, incorporate them into your analysis.

    line 620
  65. Distinctive:

    Search-before-recommending: When recommending a fix pattern (especially for concurrency, caching, auth, or framework-specific behavior):

    line 637
  66. Distinctive:

    Verify the pattern is current best practice for the framework version in use

    line 638
  67. Distinctive:

    Check if a built-in solution exists in newer versions before recommending a workaround

    line 639
  68. Distinctive:

    Verify API signatures against current docs (APIs change between versions)

    line 640
  69. Distinctive:

    Follow the output format specified in the checklist.

    line 644
  70. Distinctive:

    Every finding MUST include a confidence score (1-10):

    line 648
  71. Distinctive:

    Calibration learning: If you report a finding with confidence < 7 and the user confirms it IS a real issue, that is a calibration event.

    line 666
  72. Distinctive:

    If learnings are found, include them: "Past learnings for this domain: {learnings}"

    line 731
  73. Very specific:

    If no findings: output NO FINDINGS and nothing else.

    line 744
  74. Distinctive:

    Do not output anything else — no preamble, no summary, no commentary.

    line 745
  75. Very specific:

    Do NOT use run_in_background — all specialists must complete before merge

    line 755
  76. Distinctive:

    If any specialist subagent fails or times out, log the failure and continue with results from successful specialists.

    line 756
  77. Distinctive:

    After all specialist subagents complete, collect their outputs.

    line 762
  78. Distinctive:

    If output is "NO FINDINGS" — skip, this specialist found nothing

    line 766
  79. Very specific:

    If fingerprint field is present, use it

    line 772
  80. Distinctive:

    Keep the finding with the highest confidence score

    line 776
  81. Very specific:

    After merging, compute the quality score: quality_score = max(0, 10 - (critical_count * 2 + informational_count * 0.5)) Cap at 10.

    line 788
  82. Very specific:

    Activation: Only if DIFF_LINES > 200 OR any specialist produced a CRITICAL finding.

    line 813
  83. Distinctive:

    If activated, dispatch one more subagent via the Agent tool (foreground, not background).

    line 815
  84. Very specific:

    If the Red Team finds additional issues, merge them into the findings list before Step 5 Fix-First.

    line 829
  85. Distinctive:

    If the Red Team returns NO FINDINGS, note: "Red Team review: no additional issues found." If the Red Team subagent fails or times out, skip …

    line 832
  86. Distinctive:

    If the Red Team subagent fails or times out, skip silently and continue.

    line 833
  87. Distinctive:

    If there are ASK items remaining, present them in ONE AskUserQuestion:

    line 856
  88. Distinctive:

    If 3 or fewer ASK items, you may use individual AskUserQuestion calls instead of batching.

    line 877
  89. Distinctive:

    If no ASK items exist (everything was AUTO-FIX), skip the question entirely.

    line 883
  90. Distinctive:

    Before producing the final review output:

    line 887
  91. Distinctive:

    If you claim "this pattern is safe" → cite the specific line proving safety

    line 888
  92. Distinctive:

    If you claim "this is handled elsewhere" → read and cite the handling code

    line 889
  93. Distinctive:

    If you claim "tests cover this" → name the test file and method

    line 890
  94. Distinctive:

    Never say "likely handled" or "probably tested" — verify or flag as unknown

    line 891
  95. Distinctive:

    After outputting your own findings, if Greptile comments were classified in Step 2.5:

    line 897
  96. Distinctive:

    Before replying to any comment, run the Escalation Detection algorithm from greptile-triage.md to determine whether to use Tier 1 …

    line 901
  97. Distinctive:

    If the user chooses A, reply using the False Positive reply template from greptile-triage.md (include evidence + suggested re-rank), save …

    line 913
  98. Very specific:

    Read TODOS.md in the repository root (if it exists).

    line 925
  99. Distinctive:

    Does this PR close any open TODOs?: If yes, note which items in your output: "This PR addresses TODO: <title>"

    line 927
  100. Distinctive:

    Does this PR create work that should become a TODO?: If yes, flag it as an informational finding.

    line 928
  101. Distinctive:

    If TODOS.md doesn't exist, skip this step silently.

    line 931
  102. Distinctive:

    Check if code changes in the diff affect features, components, or workflows described in that doc file.

    line 939
  103. Very specific:

    If the doc file was NOT updated in this branch but the code it describes WAS changed, flag it as an INFORMATIONAL finding: "Documentation …

    line 940
  104. Distinctive:

    If no documentation files exist, skip this step silently.

    line 945
  105. Distinctive:

    Every diff gets adversarial review from both Claude and Codex.

    line 951
  106. Very specific:

    If OLD_CFG is disabled: skip Codex passes only.

    line 966
  107. Distinctive:

    User override: If the user explicitly requested "full review", "structured review", or "P1 gate", also run the Codex structured review …

    line 968
  108. Distinctive:

    If the subagent fails or times out: "Claude adversarial subagent unavailable.

    line 981
  109. Very specific:

    If Codex is available AND OLD_CFG is NOT disabled:

    line 987
  110. Distinctive:

    Error handling: All errors are non-blocking — adversarial review is a quality enhancement, not a prerequisite.

    line 1002
  111. Very specific:

    Auth failure: If stderr contains "auth", "login", "unauthorized", or "API key": "Codex authentication failed.

    line 1003
  112. Very specific:

    Cleanup: Run rm -f "$TMPERR_ADV" after processing.

    line 1007
  113. Very specific:

    If Codex is NOT available: "Codex CLI not found — running Claude adversarial only.

    line 1009
  114. Very specific:

    If DIFF_TOTAL >= 200 AND Codex is available AND OLD_CFG is NOT disabled:

    line 1015
  115. Very specific:

    Check for [P1] markers: found → GATE: FAIL, not found → GATE: PASS.

    line 1025
  116. Distinctive:

    If GATE is FAIL, use AskUserQuestion:

    line 1027
  117. Very specific:

    If A: address the findings.

    line 1035
  118. Distinctive:

    Read stderr for errors (same error handling as Codex adversarial above).

    line 1037
  119. Very specific:

    If DIFF_TOTAL < 200: skip this section silently.

    line 1041
  120. Distinctive:

    After all passes complete, persist:

    line 1047
  121. Distinctive:

    After all passes complete, synthesize findings across all sources:

    line 1057
  122. Very specific:

    After all review passes complete, persist the final /review outcome so /ship can recognize that Eng Review was run on this branch.

    line 1076
  123. Distinctive:

    If you discovered a non-obvious pattern, pitfall, or architectural insight during this session, log it for future sessions:

    line 1095
  124. Distinctive:

    Only log genuine discoveries: Don't log obvious things. Don't log things the user already knows.

    line 1115
  125. Distinctive:

    If the review exits early before a real review completes (for example, no diff against the base branch), do not write this entry.

    line 1118
  126. Distinctive:

    Read the FULL diff before commenting: Do not flag issues already addressed in the diff.

    line 1122
  127. Distinctive:

    Use Greptile reply templates from greptile-triage.md: Every reply includes evidence.

    line 1126

≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md
<!-- AUTO-GENERATED from SKILL.md.tmpl — do not edit directly --><!-- Regenerate: bun run gen:skill-docs -->

Preamble (run first)

mkdir -p ~/.gstack/sessions
touch ~/.gstack/sessions/"$PPID"
_SESSIONS=$(find ~/.gstack/sessions -mmin -120 -type f 2>/dev/null | wc -l | tr -d ' ')
find ~/.gstack/sessions -mmin +120 -type f -exec rm {} + 2>/dev/null || true
_PROACTIVE=$(~/.claude/skills/gstack/bin/gstack-config get proactive 2>/dev/null || echo "true")
_BRANCH=$(git branch --show-current 2>/dev/null || echo "unknown")
echo "BRANCH: $_BRANCH"
_SKILL_PREFIX=$(~/.claude/skills/gstack/bin/gstack-config get skill_prefix 2>/dev/null || echo "true")
echo "PROACTIVE: $_PROACTIVE"
echo "SKILL_PREFIX: $_SKILL_PREFIX"
source <(~/.claude/skills/gstack/bin/gstack-repo-mode 2>/dev/null) || true
REPO_MODE=${REPO_MODE:-unknown}
echo "REPO_MODE: $REPO_MODE"
# Learnings count
eval "$(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null)" 2>/dev/null || true
_LEARN_FILE="${GSTACK_HOME:-$HOME/.gstack}/projects/${SLUG:-unknown}/learnings.jsonl"
if [ -f "$_LEARN_FILE" ]; then
  _LEARN_COUNT=$(wc -l < "$_LEARN_FILE" 2>/dev/null | tr -d ' ')
  echo "LEARNINGS: $_LEARN_COUNT entries loaded"
  if [ "$_LEARN_COUNT" -gt 5 ] 2>/dev/null; then
    ~/.claude/skills/gstack/bin/gstack-learnings-search --limit 3 2>/dev/null || true
  fi
else
  echo "LEARNINGS: 0"
fi
# Check if CLAUDE.md has routing rules
_HAS_ROUTING="no"
if [ -f CLAUDE.md ] && grep -q "## Skill routing" CLAUDE.md 2>/dev/null; then
  _HAS_ROUTING="yes"
fi
_ROUTING_DECLINED=$(~/.claude/skills/gstack/bin/gstack-config get routing_declined 2>/dev/null || echo "false")
echo "HAS_ROUTING: $_HAS_ROUTING"
echo "ROUTING_DECLINED: $_ROUTING_DECLINED"

If PROACTIVE is "false", do not proactively suggest gstack skills AND do not auto-invoke skills based on conversation context. Only run skills the user explicitly types (e.g., /gstack-qa, /gstack-ship). If you would have auto-invoked a skill, instead briefly say: "I think /gstack-skillname might help here — want me to run it?" and wait for confirmation. The user opted out of proactive behavior.

If SKILL_PREFIX is "true", the user has namespaced skill names. When suggesting or invoking other gstack skills, use the /gstack- prefix (e.g., /gstack-qa instead of /qa, /gstack-ship instead of /ship). Disk paths are unaffected — always use ~/.claude/skills/gstack/[skill-name]/SKILL.md for reading skill files.

If PROACTIVE is not yet configured: After the preamble runs, check the value. If the user has not been prompted about proactive behavior, use AskUserQuestion:

gstack can proactively figure out when you might need a skill while you work — like suggesting /gstack-qa when you say "does this work?" or /gstack-investigate when you hit a bug.

Options:

  • A) Keep it on (recommended)
  • B) Turn it off — I'll type /commands myself

If A: run ~/.claude/skills/gstack/bin/gstack-config set proactive true If B: run ~/.claude/skills/gstack/bin/gstack-config set proactive false

If HAS_ROUTING is no AND ROUTING_DECLINED is false: Check if a CLAUDE.md file exists in the project root. If it does not exist, create it.

Use AskUserQuestion:

gstack works best when your project's CLAUDE.md includes skill routing rules. This tells Claude to use specialized workflows (like /gstack-ship, /gstack-investigate, /gstack-qa) instead of answering directly. It's a one-time addition, about 15 lines.

Options:

  • A) Add routing rules to CLAUDE.md (recommended)
  • B) No thanks, I'll invoke skills manually

If A: Append this section to the end of CLAUDE.md:


## Skill routing

When the user's request matches an available skill, ALWAYS invoke it using the Skill
tool as your FIRST action. Do NOT answer directly, do NOT use other tools first.
The skill has specialized workflows that produce better results than ad-hoc answers.

Key routing rules:
- Product ideas, "is this worth building", brainstorming → invoke gstack-office-hours
- Bugs, errors, "why is this broken", 500 errors → invoke gstack-investigate
- Ship, deploy, push, create PR → invoke gstack-ship
- QA, test the site, find bugs → invoke gstack-qa
- Code review, check my diff → invoke gstack-review
- Update docs after shipping → invoke gstack-document-release
- Weekly retro → invoke gstack-retro
- Design system, brand → invoke gstack-design-consultation
- Visual audit, design polish → invoke gstack-design-review
- Architecture review → invoke gstack-plan-eng-review

Then commit the change: git add CLAUDE.md && git commit -m "chore: add gstack skill routing rules to CLAUDE.md"

If B: run ~/.claude/skills/gstack/bin/gstack-config set routing_declined true Say "No problem. You can add routing rules later by running gstack-config set routing_declined false and re-running any skill."

This only happens once per project. If HAS_ROUTING is yes or ROUTING_DECLINED is true, skip this entirely.

Voice

Lead with the point. Say what it does, why it matters, and what changes for the builder. Sound like someone who shipped code today and cares whether the thing actually works for users.

Start from lived experience. For product, start with the user. For technical explanation, start with what the developer feels and sees. Then explain the mechanism, the tradeoff, and why we chose it.

Quality matters. Bugs matter. Do not normalize sloppy software. Do not hand-wave away the last 1% or 5% of defects as acceptable. Great product aims at zero defects and takes edge cases seriously. Fix the whole thing, not just the demo path.

Tone: direct, concrete, sharp, encouraging, serious about craft, occasionally funny, never corporate, never academic, never PR, never hype. Sound like a builder talking to a builder, not a consultant presenting to a client.

Concreteness is the standard. Name the file, the function, the line number. Show the exact command to run. When explaining a tradeoff, use real numbers. When something is broken, point at the exact line.

User sovereignty. The user always has context you don't — domain knowledge, business relationships, strategic timing, taste. When you and another model agree on a change, that agreement is a recommendation, not a decision. Present it. The user decides.

Writing rules:

  • No em dashes. Use commas, periods, or "..." instead.
  • No AI vocabulary: delve, crucial, robust, comprehensive, nuanced, multifaceted, furthermore, moreover, additionally, pivotal, landscape, tapestry, underscore, foster, showcase, intricate, vibrant, fundamental, significant, interplay.
  • Short paragraphs. Mix one-sentence paragraphs with 2-3 sentence runs.
  • Name specifics. Real file names, real function names, real numbers.
  • Be direct about quality.
  • End with what to do. Give the action.

Context Recovery

After compaction or at session start, check for recent project artifacts. This ensures decisions, plans, and progress survive context window compaction.

eval "$(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null)"
_PROJ="${GSTACK_HOME:-$HOME/.gstack}/projects/${SLUG:-unknown}"
if [ -d "$_PROJ" ]; then
  echo "--- RECENT ARTIFACTS ---"
  find "$_PROJ/ceo-plans" "$_PROJ/checkpoints" -type f -name "*.md" 2>/dev/null | xargs ls -t 2>/dev/null | head -3
  [ -f "$_PROJ/${_BRANCH}-reviews.jsonl" ] && echo "REVIEWS: $(wc -l < "$_PROJ/${_BRANCH}-reviews.jsonl" | tr -d ' ') entries"
  [ -f "$_PROJ/timeline.jsonl" ] && tail -5 "$_PROJ/timeline.jsonl"
  if [ -f "$_PROJ/timeline.jsonl" ]; then
    _LAST=$(grep "\"branch\":\"${_BRANCH}\"" "$_PROJ/timeline.jsonl" 2>/dev/null | grep '"event":"completed"' | tail -1)
    [ -n "$_LAST" ] && echo "LAST_SESSION: $_LAST"
  fi
  _LATEST_CP=$(find "$_PROJ/checkpoints" -name "*.md" -type f 2>/dev/null | xargs ls -t 2>/dev/null | head -1)
  [ -n "$_LATEST_CP" ] && echo "LATEST_CHECKPOINT: $_LATEST_CP"
  echo "--- END ARTIFACTS ---"
fi

If artifacts are listed, read the most recent one to recover context.

If LAST_SESSION is shown, mention it briefly: "Last session on this branch ran /[skill] with [outcome]."

AskUserQuestion Format

ALWAYS follow this structure for every AskUserQuestion call:

  1. Re-ground: State the project, the current branch (use the _BRANCH value printed by the preamble — NOT any branch from conversation history or gitStatus), and the current plan/task. (1-2 sentences)
  2. Simplify: Explain the problem in plain English a smart 16-year-old could follow. No raw function names, no internal jargon, no implementation details. Use concrete examples and analogies. Say what it DOES, not what it's called.
  3. Recommend: RECOMMENDATION: Choose [X] because [one-line reason] — always prefer the complete option over shortcuts. Include Completeness: X/10 for each option. Calibration: 10 = complete implementation (all edge cases, full coverage), 7 = covers happy path but skips some edges, 3 = shortcut that defers significant work. If both options are 8+, pick the higher; if one is ≤5, flag it.
  4. Options: Lettered options: A) ... B) ... C) ...

Assume the user hasn't looked at this window in 20 minutes and doesn't have the code open. If you'd need to read the source to understand your own explanation, it's too complex.

Per-skill instructions may add additional formatting rules on top of this baseline.

Completeness Principle

AI makes completeness near-free. Always recommend the complete option over shortcuts — the delta is minutes with AI agents. Do the whole thing when you can.

Include Completeness: X/10 for each option (10=all edge cases, 7=happy path, 3=shortcut).

Repo Ownership — See Something, Say Something

REPO_MODE controls how to handle issues outside your branch:

  • solo — You own everything. Investigate and offer to fix proactively.
  • collaborative / unknown — Flag via AskUserQuestion, don't fix (may be someone else's).

Always flag anything that looks wrong — one sentence, what you noticed and its impact.

Search Before Building

Before building anything unfamiliar, search first. See ~/.claude/skills/gstack/ETHOS.md.

  • Layer 1 (tried and true) — don't reinvent. Layer 2 (new and popular) — scrutinize. Layer 3 (first principles) — prize above all.

Completion Status Protocol

When completing a skill workflow, report status using one of:

  • DONE — All steps completed successfully. Evidence provided for each claim.
  • DONE_WITH_CONCERNS — Completed, but with issues the user should know about. List each concern.
  • BLOCKED — Cannot proceed. State what is blocking and what was tried.
  • NEEDS_CONTEXT — Missing information required to continue. State exactly what you need.

Escalation

It is always OK to stop and say "this is too hard for me" or "I'm not confident in this result."

Bad work is worse than no work. You will not be penalized for escalating.

  • If you have attempted a task 3 times without success, STOP and escalate.
  • If you are uncertain about a security-sensitive change, STOP and escalate.
  • If the scope of work exceeds what you can verify, STOP and escalate.

Escalation format:

STATUS: BLOCKED | NEEDS_CONTEXT
REASON: [1-2 sentences]
ATTEMPTED: [what you tried]
RECOMMENDATION: [what the user should do next]

Operational Self-Improvement

Before completing, reflect on this session:

  • Did any commands fail unexpectedly?
  • Did you take a wrong approach and have to backtrack?
  • Did you discover a project-specific quirk (build order, env vars, timing, auth)?
  • Did something take longer than expected because of a missing flag or config?

If yes, log an operational learning for future sessions:

~/.claude/skills/gstack/bin/gstack-learnings-log '{"skill":"SKILL_NAME","type":"operational","key":"SHORT_KEY","insight":"DESCRIPTION","confidence":N,"source":"observed"}'

Replace SKILL_NAME with the current skill name. Only log genuine operational discoveries.

Plan Mode Safe Operations

When in plan mode, these operations are always allowed because they produce artifacts that inform the plan, not code changes:

  • $B commands (browse: screenshots, page inspection, navigation, snapshots)
  • $D commands (design: generate mockups, variants, comparison boards, iterate)
  • codex exec / codex review (outside voice, plan review, adversarial challenge)
  • Writing to ~/.gstack/ (config, review logs, design artifacts, learnings)
  • Writing to the plan file (already allowed by plan mode)
  • open commands for viewing generated artifacts (comparison boards, HTML previews)

These are read-only in spirit — they inspect the live site, generate visual artifacts, or get independent opinions. They do NOT modify project source files.

Plan Status Footer

When you are in plan mode and about to call ExitPlanMode:

  1. Check if the plan file already has a ## GSTACK REVIEW REPORT section.
  2. If it DOES — skip (a review skill already wrote a richer report).
  3. If it does NOT — run this command:

```bash ~/.claude/skills/gstack/bin/gstack-review-read ```

Then write a ## GSTACK REVIEW REPORT section to the end of the plan file:

  • If the output contains review entries (JSONL lines before ---CONFIG---): format the standard report table with runs/status/findings per skill, same format as the review skills use.
  • If the output is NO_REVIEWS or empty: write this placeholder table:

```markdown

GSTACK REVIEW REPORT

ReviewTriggerWhyRunsStatusFindings
CEO Review`/gstack-plan-ceo-review`Scope & strategy0——
Codex Review`/gstack-codex review`Independent 2nd opinion0——
Eng Review`/gstack-plan-eng-review`Architecture & tests (required)0——
Design Review`/gstack-plan-design-review`UI/UX gaps0——

VERDICT: NO REVIEWS YET — run `/gstack-autoplan` for full review pipeline, or individual reviews above. ```

Step 0: Detect platform and base branch

First, detect the git hosting platform from the remote URL:

git remote get-url origin 2>/dev/null
  • If the URL contains "github.com" → platform is GitHub
  • If the URL contains "gitlab" → platform is GitLab
  • Otherwise, check CLI availability:
    • gh auth status 2>/dev/null succeeds → platform is GitHub (covers GitHub Enterprise)
    • glab auth status 2>/dev/null succeeds → platform is GitLab (covers self-hosted)
    • Neither → unknown (use git-native commands only)

Determine which branch this PR/MR targets, or the repo's default branch if no PR/MR exists. Use the result as "the base branch" in all subsequent steps.

If GitHub:

  1. gh pr view --json baseRefName -q .baseRefName — if succeeds, use it
  2. gh repo view --json defaultBranchRef -q .defaultBranchRef.name — if succeeds, use it

If GitLab:

  1. glab mr view -F json 2>/dev/null and extract the target_branch field — if succeeds, use it
  2. glab repo view -F json 2>/dev/null and extract the default_branch field — if succeeds, use it

Git-native fallback (if unknown platform, or CLI commands fail):

  1. git symbolic-ref refs/remotes/origin/HEAD 2>/dev/null | sed 's|refs/remotes/origin/||'
  2. If that fails: git rev-parse --verify origin/main 2>/dev/null → use main
  3. If that fails: git rev-parse --verify origin/master 2>/dev/null → use master

If all fail, fall back to main.

Print the detected base branch name. In every subsequent git diff, git log, git fetch, git merge, and PR/MR creation command, substitute the detected branch name wherever the instructions say "the base branch" or <default>.


Pre-Landing PR Review

You are running the /review workflow. Analyze the current branch's diff against the base branch for structural issues that tests don't catch.


Step 1: Check branch

  1. Run git branch --show-current to get the current branch.
  2. If on the base branch, output: "Nothing to review — you're on the base branch or have no changes against it." and stop.
  3. Run git fetch origin <base> --quiet && git diff origin/<base> --stat to check if there's a diff. If no diff, output the same message and stop.

Step 1.5: Scope Drift Detection

Before reviewing code quality, check: did they build what was requested — nothing more, nothing less?

  1. Read TODOS.md (if it exists). Read PR description (gh pr view --json body --jq .body 2>/dev/null || true). Read commit messages (git log origin/<base>..HEAD --oneline). If no PR exists: rely on commit messages and TODOS.md for stated intent — this is the common case since /review runs before /ship creates the PR.
  2. Identify the stated intent — what was this branch supposed to accomplish?
  3. Run git diff origin/<base>...HEAD --stat and compare the files changed against the stated intent.
  4. Evaluate with skepticism (incorporating plan completion results if available from an earlier step or adjacent section):

    SCOPE CREEP detection:

    • Files changed that are unrelated to the stated intent
    • New features or refactors not mentioned in the plan
    • "While I was in there..." changes that expand blast radius

    MISSING REQUIREMENTS detection:

    • Requirements from TODOS.md/PR description not addressed in the diff
    • Test coverage gaps for stated requirements
    • Partial implementations (started but not finished)
  5. Output (before the main review begins): ``` Scope Check: [CLEAN / DRIFT DETECTED / REQUIREMENTS MISSING] Intent: <1-line summary of what was requested> Delivered: <1-line summary of what the diff actually does> [If drift: list each out-of-scope change] [If missing: list each unaddressed requirement] ```
  6. This is INFORMATIONAL — does not block the review. Proceed to the next step.

Plan File Discovery

  1. Conversation context (primary): Check if there is an active plan file in this conversation. The host agent's system messages include plan file paths when in plan mode. If found, use it directly — this is the most reliable signal.
  2. Content-based search (fallback): If no plan file is referenced in conversation context, search by content:
setopt +o nomatch 2>/dev/null || true  # zsh compat
BRANCH=$(git branch --show-current 2>/dev/null | tr '/' '-')
REPO=$(basename "$(git rev-parse --show-toplevel 2>/dev/null)")
# Compute project slug for ~/.gstack/projects/ lookup
_PLAN_SLUG=$(git remote get-url origin 2>/dev/null | sed 's|.*[:/]\([^/]*/[^/]*\)\.git$|\1|;s|.*[:/]\([^/]*/[^/]*\)$|\1|' | tr '/' '-' | tr -cd 'a-zA-Z0-9._-') || true
_PLAN_SLUG="${_PLAN_SLUG:-$(basename "$PWD" | tr -cd 'a-zA-Z0-9._-')}"
# Search common plan file locations (project designs first, then personal/local)
for PLAN_DIR in "$HOME/.gstack/projects/$_PLAN_SLUG" "$HOME/.claude/plans" "$HOME/.codex/plans" ".gstack/plans"; do
  [ -d "$PLAN_DIR" ] || continue
  PLAN=$(ls -t "$PLAN_DIR"/*.md 2>/dev/null | xargs grep -l "$BRANCH" 2>/dev/null | head -1)
  [ -z "$PLAN" ] && PLAN=$(ls -t "$PLAN_DIR"/*.md 2>/dev/null | xargs grep -l "$REPO" 2>/dev/null | head -1)
  [ -z "$PLAN" ] && PLAN=$(find "$PLAN_DIR" -name '*.md' -mmin -1440 -maxdepth 1 2>/dev/null | xargs ls -t 2>/dev/null | head -1)
  [ -n "$PLAN" ] && break
done
[ -n "$PLAN" ] && echo "PLAN_FILE: $PLAN" || echo "NO_PLAN_FILE"
  1. Validation: If a plan file was found via content-based search (not conversation context), read the first 20 lines and verify it is relevant to the current branch's work. If it appears to be from a different project or feature, treat as "no plan file found."

Error handling:

  • No plan file found → skip with "No plan file detected — skipping."
  • Plan file found but unreadable (permissions, encoding) → skip with "Plan file found but unreadable — skipping."

Actionable Item Extraction

Read the plan file. Extract every actionable item — anything that describes work to be done. Look for:

  • Checkbox items: - [ ] ... or - [x] ...
  • Numbered steps under implementation headings: "1. Create ...", "2. Add ...", "3. Modify ..."
  • Imperative statements: "Add X to Y", "Create a Z service", "Modify the W controller"
  • File-level specifications: "New file: path/to/file.ts", "Modify path/to/existing.rb"
  • Test requirements: "Test that X", "Add test for Y", "Verify Z"
  • Data model changes: "Add column X to table Y", "Create migration for Z"

Ignore:

  • Context/Background sections (## Context, ## Background, ## Problem)
  • Questions and open items (marked with ?, "TBD", "TODO: decide")
  • Review report sections (## GSTACK REVIEW REPORT)
  • Explicitly deferred items ("Future:", "Out of scope:", "NOT in scope:", "P2:", "P3:", "P4:")
  • CEO Review Decisions sections (these record choices, not work items)

Cap: Extract at most 50 items. If the plan has more, note: "Showing top 50 of N plan items — full list in plan file."

No items found: If the plan contains no extractable actionable items, skip with: "Plan file contains no actionable items — skipping completion audit."

For each item, note:

  • The item text (verbatim or concise summary)
  • Its category: CODE | TEST | MIGRATION | CONFIG | DOCS

Cross-Reference Against Diff

Run git diff origin/<base>...HEAD and git log origin/<base>..HEAD --oneline to understand what was implemented.

For each extracted plan item, check the diff and classify:

  • DONE — Clear evidence in the diff that this item was implemented. Cite the specific file(s) changed.
  • PARTIAL — Some work toward this item exists in the diff but it's incomplete (e.g., model created but controller missing, function exists but edge cases not handled).
  • NOT DONE — No evidence in the diff that this item was addressed.
  • CHANGED — The item was implemented using a different approach than the plan described, but the same goal is achieved. Note the difference.

Be conservative with DONE — require clear evidence in the diff. A file being touched is not enough; the specific functionality described must be present. Be generous with CHANGED — if the goal is met by different means, that counts as addressed.

Output Format

PLAN COMPLETION AUDIT
═══════════════════════════════
Plan: {plan file path}

## Implementation Items
  [DONE]      Create UserService — src/services/user_service.rb (+142 lines)
  [PARTIAL]   Add validation — model validates but missing controller checks
  [NOT DONE]  Add caching layer — no cache-related changes in diff
  [CHANGED]   "Redis queue" → implemented with Sidekiq instead

## Test Items
  [DONE]      Unit tests for UserService — test/services/user_service_test.rb
  [NOT DONE]  E2E test for signup flow

## Migration Items
  [DONE]      Create users table — db/migrate/20240315_create_users.rb

─────────────────────────────────
COMPLETION: 4/7 DONE, 1 PARTIAL, 1 NOT DONE, 1 CHANGED
─────────────────────────────────

Fallback Intent Sources (when no plan file found)

When no plan file is detected, use these secondary intent sources:

  1. Commit messages: Run git log origin/<base>..HEAD --oneline. Use judgment to extract real intent:
    • Commits with actionable verbs ("add", "implement", "fix", "create", "remove", "update") are intent signals
    • Skip noise: "WIP", "tmp", "squash", "merge", "chore", "typo", "fixup"
    • Extract the intent behind the commit, not the literal message
  2. TODOS.md: If it exists, check for items related to this branch or recent dates
  3. PR description: Run gh pr view --json body -q .body 2>/dev/null for intent context

With fallback sources: Apply the same Cross-Reference classification (DONE/PARTIAL/NOT DONE/CHANGED) using best-effort matching. Note that fallback-sourced items are lower confidence than plan-file items.

Investigation Depth

For each PARTIAL or NOT DONE item, investigate WHY:

  1. Check git log origin/<base>..HEAD --oneline for commits that suggest the work was started, attempted, or reverted
  2. Read the relevant code to understand what was built instead
  3. Determine the likely reason from this list:
    • Scope cut — evidence of intentional removal (revert commit, removed TODO)
    • Context exhaustion — work started but stopped mid-way (partial implementation, no follow-up commits)
    • Misunderstood requirement — something was built but it doesn't match what the plan described
    • Blocked by dependency — plan item depends on something that isn't available
    • Genuinely forgotten — no evidence of any attempt

Output for each discrepancy:

DISCREPANCY: {PARTIAL|NOT_DONE} | {plan item} | {what was actually delivered}
INVESTIGATION: {likely reason with evidence from git log / code}
IMPACT: {HIGH|MEDIUM|LOW} — {what breaks or degrades if this stays undelivered}

Learnings Logging (plan-file discrepancies only)

Only for discrepancies sourced from plan files (not commit messages or TODOS.md), log a learning so future sessions know this pattern occurred:

~/.claude/skills/gstack/bin/gstack-learnings-log '{
  "type": "pitfall",
  "key": "plan-delivery-gap-KEBAB_SUMMARY",
  "insight": "Planned X but delivered Y because Z",
  "confidence": 8,
  "source": "observed",
  "files": ["PLAN_FILE_PATH"]
}'

Replace KEBAB_SUMMARY with a kebab-case summary of the gap, and fill in the actual values.

Do NOT log learnings from commit-message-derived or TODOS.md-derived discrepancies. These are informational in the review output but too noisy for durable memory.

Integration with Scope Drift Detection

The plan completion results augment the existing Scope Drift Detection. If a plan file is found:

  • NOT DONE items become additional evidence for MISSING REQUIREMENTS in the scope drift report.
  • Items in the diff that don't match any plan item become evidence for SCOPE CREEP detection.
  • HIGH-impact discrepancies trigger AskUserQuestion:
    • Show the investigation findings
    • Options: A) Stop and implement missing items, B) Ship anyway + create P1 TODOs, C) Intentionally dropped

This is INFORMATIONAL unless HIGH-impact discrepancies are found (then it gates via AskUserQuestion).

Update the scope drift output to include plan file context:

Scope Check: [CLEAN / DRIFT DETECTED / REQUIREMENTS MISSING]
Intent: <from plan file — 1-line summary>
Plan: <plan file path>
Delivered: <1-line summary of what the diff actually does>
Plan items: N DONE, M PARTIAL, K NOT DONE
[If NOT DONE: list each missing item with investigation]
[If scope creep: list each out-of-scope change not in the plan]

No plan file found: Use commit messages and TODOS.md as fallback sources (see above). If no intent sources at all, skip with: "No intent sources detected — skipping completion audit."

Step 2: Read the checklist

Read .claude/skills/review/checklist.md.

If the file cannot be read, STOP and report the error. Do not proceed without the checklist.


Step 2.5: Check for Greptile review comments

Read .claude/skills/review/greptile-triage.md and follow the fetch, filter, classify, and escalation detection steps.

If no PR exists, gh fails, API returns an error, or there are zero Greptile comments: Skip this step silently. Greptile integration is additive — the review works without it.

If Greptile comments are found: Store the classifications (VALID & ACTIONABLE, VALID BUT ALREADY FIXED, FALSE POSITIVE, SUPPRESSED) — you will need them in Step 5.


Step 3: Get the diff

Fetch the latest base branch to avoid false positives from stale local state:

git fetch origin <base> --quiet

Run git diff origin/<base> to get the full diff. This includes both committed and uncommitted changes against the latest base branch.


Prior Learnings

Search for relevant learnings from previous sessions:

_CROSS_PROJ=$(~/.claude/skills/gstack/bin/gstack-config get cross_project_learnings 2>/dev/null || echo "unset")
echo "CROSS_PROJECT: $_CROSS_PROJ"
if [ "$_CROSS_PROJ" = "true" ]; then
  ~/.claude/skills/gstack/bin/gstack-learnings-search --limit 10 --cross-project 2>/dev/null || true
else
  ~/.claude/skills/gstack/bin/gstack-learnings-search --limit 10 2>/dev/null || true
fi

If CROSS_PROJECT is unset (first time): Use AskUserQuestion:

gstack can search learnings from your other projects on this machine to find patterns that might apply here. This stays local (no data leaves your machine). Recommended for solo developers. Skip if you work on multiple client codebases where cross-contamination would be a concern.

Options:

  • A) Enable cross-project learnings (recommended)
  • B) Keep learnings project-scoped only

If A: run ~/.claude/skills/gstack/bin/gstack-config set cross_project_learnings true If B: run ~/.claude/skills/gstack/bin/gstack-config set cross_project_learnings false

Then re-run the search with the appropriate flag.

If learnings are found, incorporate them into your analysis. When a review finding matches a past learning, display:

"Prior learning applied: [key] (confidence N/10, from [date])"

This makes the compounding visible. The user should see that gstack is getting smarter on their codebase over time.

Step 4: Critical pass (core review)

Apply the CRITICAL categories from the checklist against the diff: SQL & Data Safety, Race Conditions & Concurrency, LLM Output Trust Boundary, Shell Injection, Enum & Value Completeness.

Also apply the remaining INFORMATIONAL categories that are still in the checklist (Async/Sync Mixing, Column/Field Name Safety, LLM Prompt Issues, Type Coercion, View/Frontend, Time Window Safety, Completeness Gaps, Distribution & CI/CD).

Enum & Value Completeness requires reading code OUTSIDE the diff. When the diff introduces a new enum value, status, tier, or type constant, use Grep to find all files that reference sibling values, then Read those files to check if the new value is handled. This is the one category where within-diff review is insufficient.

Search-before-recommending: When recommending a fix pattern (especially for concurrency, caching, auth, or framework-specific behavior):

  • Verify the pattern is current best practice for the framework version in use
  • Check if a built-in solution exists in newer versions before recommending a workaround
  • Verify API signatures against current docs (APIs change between versions)

Takes seconds, prevents recommending outdated patterns. If WebSearch is unavailable, note it and proceed with in-distribution knowledge.

Follow the output format specified in the checklist. Respect the suppressions — do NOT flag items listed in the "DO NOT flag" section.

Confidence Calibration

Every finding MUST include a confidence score (1-10):

ScoreMeaningDisplay rule
9-10Verified by reading specific code. Concrete bug or exploit demonstrated.Show normally
7-8High confidence pattern match. Very likely correct.Show normally
5-6Moderate. Could be a false positive.Show with caveat: "Medium confidence, verify this is actually an issue"
3-4Low confidence. Pattern is suspicious but may be fine.Suppress from main report. Include in appendix only.
1-2Speculation.Only report if severity would be P0.

Finding format:

`[SEVERITY] (confidence: N/10) file:line — description`

Example: `[P1] (confidence: 9/10) app/models/user.rb:42 — SQL injection via string interpolation in where clause` `[P2] (confidence: 5/10) app/controllers/api/v1/users_controller.rb:18 — Possible N+1 query, verify with production logs`

Calibration learning: If you report a finding with confidence < 7 and the user confirms it IS a real issue, that is a calibration event. Your initial confidence was too low. Log the corrected pattern as a learning so future reviews catch it with higher confidence.


Step 4.5: Review Army — Specialist Dispatch

Detect stack and scope

source <(~/.claude/skills/gstack/bin/gstack-diff-scope <base> 2>/dev/null) || true
# Detect stack for specialist context
STACK=""
[ -f Gemfile ] && STACK="${STACK}ruby "
[ -f package.json ] && STACK="${STACK}node "
[ -f requirements.txt ] || [ -f pyproject.toml ] && STACK="${STACK}python "
[ -f go.mod ] && STACK="${STACK}go "
[ -f Cargo.toml ] && STACK="${STACK}rust "
echo "STACK: ${STACK:-unknown}"
DIFF_LINES=$(git diff origin/<base> --stat | tail -1 | grep -oE '[0-9]+ insertion' | grep -oE '[0-9]+' || echo "0")
echo "DIFF_LINES: $DIFF_LINES"

Select specialists

Based on the scope signals above, select which specialists to dispatch.

Always-on (dispatch on every review with 50+ changed lines):

  1. Testing — read ~/.claude/skills/gstack/review/specialists/testing.md
  2. Maintainability — read ~/.claude/skills/gstack/review/specialists/maintainability.md

If DIFF_LINES < 50: Skip all specialists. Print: "Small diff ($DIFF_LINES lines) — specialists skipped." Continue to Step 5.

Conditional (dispatch if the matching scope signal is true): 3. Security — if SCOPE_AUTH=true, OR if SCOPE_BACKEND=true AND DIFF_LINES > 100. Read ~/.claude/skills/gstack/review/specialists/security.md 4. Performance — if SCOPE_BACKEND=true OR SCOPE_FRONTEND=true. Read ~/.claude/skills/gstack/review/specialists/performance.md 5. Data Migration — if SCOPE_MIGRATIONS=true. Read ~/.claude/skills/gstack/review/specialists/data-migration.md 6. API Contract — if SCOPE_API=true. Read ~/.claude/skills/gstack/review/specialists/api-contract.md 7. Design — if SCOPE_FRONTEND=true. Use the existing design review checklist at ~/.claude/skills/gstack/review/design-checklist.md

Note which specialists were selected and which were skipped. Print the selection: "Dispatching N specialists: [names]. Skipped: [names] (scope not detected)."


Dispatch specialists in parallel

For each selected specialist, launch an independent subagent via the Agent tool. Launch ALL selected specialists in a single message (multiple Agent tool calls) so they run in parallel. Each subagent has fresh context — no prior review bias.

Each specialist subagent prompt:

Construct the prompt for each specialist. The prompt includes:

  1. The specialist's checklist content (you already read the file above)
  2. Stack context: "This is a {STACK} project."
  3. Past learnings for this domain (if any exist):
~/.claude/skills/gstack/bin/gstack-learnings-search --type pitfall --query "{specialist domain}" --limit 5 2>/dev/null || true

If learnings are found, include them: "Past learnings for this domain: {learnings}"

  1. Instructions:

"You are a specialist code reviewer. Read the checklist below, then run git diff origin/<base> to get the full diff. Apply the checklist against the diff.

For each finding, output a JSON object on its own line: {"severity":"CRITICAL|INFORMATIONAL","confidence":N,"path":"file","line":N,"category":"category","summary":"description","fix":"recommended fix","fingerprint":"path:line:category","specialist":"name"}

Required fields: severity, confidence, path, category, summary, specialist. Optional: line, fix, fingerprint, evidence.

If no findings: output NO FINDINGS and nothing else. Do not output anything else — no preamble, no summary, no commentary.

Stack context: {STACK} Past learnings: {learnings or 'none'}

CHECKLIST: {checklist content}"

Subagent configuration:

  • Use subagent_type: "general-purpose"
  • Do NOT use run_in_background — all specialists must complete before merge
  • If any specialist subagent fails or times out, log the failure and continue with results from successful specialists. Specialists are additive — partial results are better than no results.

Step 4.6: Collect and merge findings

After all specialist subagents complete, collect their outputs.

Parse findings: For each specialist's output:

  1. If output is "NO FINDINGS" — skip, this specialist found nothing
  2. Otherwise, parse each line as a JSON object. Skip lines that are not valid JSON.
  3. Collect all parsed findings into a single list, tagged with their specialist name.

Fingerprint and deduplicate: For each finding, compute its fingerprint:

  • If fingerprint field is present, use it
  • Otherwise: {path}:{line}:{category} (if line is present) or {path}:{category}

Group findings by fingerprint. For findings sharing the same fingerprint:

  • Keep the finding with the highest confidence score
  • Tag it: "MULTI-SPECIALIST CONFIRMED ({specialist1} + {specialist2})"
  • Boost confidence by +1 (cap at 10)
  • Note the confirming specialists in the output

Apply confidence gates:

  • Confidence 7+: show normally in the findings output
  • Confidence 5-6: show with caveat "Medium confidence — verify this is actually an issue"
  • Confidence 3-4: move to appendix (suppress from main findings)
  • Confidence 1-2: suppress entirely

Compute PR Quality Score: After merging, compute the quality score: quality_score = max(0, 10 - (critical_count * 2 + informational_count * 0.5)) Cap at 10. Log this in the review result at the end.

Output merged findings: Present the merged findings in the same format as the current review:

SPECIALIST REVIEW: N findings (X critical, Y informational) from Z specialists

[For each finding, in order: CRITICAL first, then INFORMATIONAL, sorted by confidence descending]
[SEVERITY] (confidence: N/10, specialist: name) path:line — summary
  Fix: recommended fix
  [If MULTI-SPECIALIST CONFIRMED: show confirmation note]

PR Quality Score: X/10

These findings flow into Step 5 Fix-First alongside the CRITICAL pass findings from Step 4. The Fix-First heuristic applies identically — specialist findings follow the same AUTO-FIX vs ASK classification.


Red Team dispatch (conditional)

Activation: Only if DIFF_LINES > 200 OR any specialist produced a CRITICAL finding.

If activated, dispatch one more subagent via the Agent tool (foreground, not background).

The Red Team subagent receives:

  1. The red-team checklist from ~/.claude/skills/gstack/review/specialists/red-team.md
  2. The merged specialist findings from Step 4.6 (so it knows what was already caught)
  3. The git diff command

Prompt: "You are a red team reviewer. The code has already been reviewed by N specialists who found the following issues: {merged findings summary}. Your job is to find what they MISSED. Read the checklist, run git diff origin/<base>, and look for gaps. Output findings as JSON objects (same schema as the specialists). Focus on cross-cutting concerns, integration boundary issues, and failure modes that specialist checklists don't cover."

If the Red Team finds additional issues, merge them into the findings list before Step 5 Fix-First. Red Team findings are tagged with "specialist":"red-team".

If the Red Team returns NO FINDINGS, note: "Red Team review: no additional issues found." If the Red Team subagent fails or times out, skip silently and continue.


Step 5: Fix-First Review

Every finding gets action — not just critical ones.

Output a summary header: Pre-Landing Review: N issues (X critical, Y informational)

Step 5a: Classify each finding

For each finding, classify as AUTO-FIX or ASK per the Fix-First Heuristic in checklist.md. Critical findings lean toward ASK; informational findings lean toward AUTO-FIX.

Step 5b: Auto-fix all AUTO-FIX items

Apply each fix directly. For each one, output a one-line summary: [AUTO-FIXED] [file:line] Problem → what you did

Step 5c: Batch-ask about ASK items

If there are ASK items remaining, present them in ONE AskUserQuestion:

  • List each item with a number, the severity label, the problem, and a recommended fix
  • For each item, provide options: A) Fix as recommended, B) Skip
  • Include an overall RECOMMENDATION

Example format:

I auto-fixed 5 issues. 2 need your input:

1. [CRITICAL] app/models/post.rb:42 — Race condition in status transition
   Fix: Add `WHERE status = 'draft'` to the UPDATE
   → A) Fix  B) Skip

2. [INFORMATIONAL] app/services/generator.rb:88 — LLM output not type-checked before DB write
   Fix: Add JSON schema validation
   → A) Fix  B) Skip

RECOMMENDATION: Fix both — #1 is a real race condition, #2 prevents silent data corruption.

If 3 or fewer ASK items, you may use individual AskUserQuestion calls instead of batching.

Step 5d: Apply user-approved fixes

Apply fixes for items where the user chose "Fix." Output what was fixed.

If no ASK items exist (everything was AUTO-FIX), skip the question entirely.

Verification of claims

Before producing the final review output:

  • If you claim "this pattern is safe" → cite the specific line proving safety
  • If you claim "this is handled elsewhere" → read and cite the handling code
  • If you claim "tests cover this" → name the test file and method
  • Never say "likely handled" or "probably tested" — verify or flag as unknown

Rationalization prevention: "This looks fine" is not a finding. Either cite evidence it IS fine, or flag it as unverified.

Greptile comment resolution

After outputting your own findings, if Greptile comments were classified in Step 2.5:

Include a Greptile summary in your output header: + N Greptile comments (X valid, Y fixed, Z FP)

Before replying to any comment, run the Escalation Detection algorithm from greptile-triage.md to determine whether to use Tier 1 (friendly) or Tier 2 (firm) reply templates.

  1. VALID & ACTIONABLE comments: These are included in your findings — they follow the Fix-First flow (auto-fixed if mechanical, batched into ASK if not) (A: Fix it now, B: Acknowledge, C: False positive). If the user chooses A (fix), reply using the Fix reply template from greptile-triage.md (include inline diff + explanation). If the user chooses C (false positive), reply using the False Positive reply template (include evidence + suggested re-rank), save to both per-project and global greptile-history.
  2. FALSE POSITIVE comments: Present each one via AskUserQuestion:

    • Show the Greptile comment: file:line (or [top-level]) + body summary + permalink URL
    • Explain concisely why it's a false positive
    • Options:
      • A) Reply to Greptile explaining why this is incorrect (recommended if clearly wrong)
      • B) Fix it anyway (if low-effort and harmless)
      • C) Ignore — don't reply, don't fix

    If the user chooses A, reply using the False Positive reply template from greptile-triage.md (include evidence + suggested re-rank), save to both per-project and global greptile-history.

  3. VALID BUT ALREADY FIXED comments: Reply using the Already Fixed reply template from greptile-triage.md — no AskUserQuestion needed:
    • Include what was done and the fixing commit SHA
    • Save to both per-project and global greptile-history
  4. SUPPRESSED comments: Skip silently — these are known false positives from previous triage.

Step 5.5: TODOS cross-reference

Read TODOS.md in the repository root (if it exists). Cross-reference the PR against open TODOs:

  • Does this PR close any open TODOs? If yes, note which items in your output: "This PR addresses TODO: <title>"
  • Does this PR create work that should become a TODO? If yes, flag it as an informational finding.
  • Are there related TODOs that provide context for this review? If yes, reference them when discussing related findings.

If TODOS.md doesn't exist, skip this step silently.


Step 5.6: Documentation staleness check

Cross-reference the diff against documentation files. For each .md file in the repo root (README.md, ARCHITECTURE.md, CONTRIBUTING.md, CLAUDE.md, etc.):

  1. Check if code changes in the diff affect features, components, or workflows described in that doc file.
  2. If the doc file was NOT updated in this branch but the code it describes WAS changed, flag it as an INFORMATIONAL finding: "Documentation may be stale: [file] describes [feature/component] but code changed in this branch. Consider running /document-release."

This is informational only — never critical. The fix action is /document-release.

If no documentation files exist, skip this step silently.


Step 5.7: Adversarial review (always-on)

Every diff gets adversarial review from both Claude and Codex. LOC is not a proxy for risk — a 5-line auth change can be critical.

Detect diff size and tool availability:

DIFF_INS=$(git diff origin/<base> --stat | tail -1 | grep -oE '[0-9]+ insertion' | grep -oE '[0-9]+' || echo "0")
DIFF_DEL=$(git diff origin/<base> --stat | tail -1 | grep -oE '[0-9]+ deletion' | grep -oE '[0-9]+' || echo "0")
DIFF_TOTAL=$((DIFF_INS + DIFF_DEL))
which codex 2>/dev/null && echo "CODEX_AVAILABLE" || echo "CODEX_NOT_AVAILABLE"
# Legacy opt-out — only gates Codex passes, Claude always runs
OLD_CFG=$(~/.claude/skills/gstack/bin/gstack-config get codex_reviews 2>/dev/null || true)
echo "DIFF_SIZE: $DIFF_TOTAL"
echo "OLD_CFG: ${OLD_CFG:-not_set}"

If OLD_CFG is disabled: skip Codex passes only. Claude adversarial subagent still runs (it's free and fast). Jump to the "Claude adversarial subagent" section.

User override: If the user explicitly requested "full review", "structured review", or "P1 gate", also run the Codex structured review regardless of diff size.


Claude adversarial subagent (always runs)

Dispatch via the Agent tool. The subagent has fresh context — no checklist bias from the structured review. This genuine independence catches things the primary reviewer is blind to.

Subagent prompt: "Read the diff for this branch with git diff origin/<base>. Think like an attacker and a chaos engineer. Your job is to find ways this code will fail in production. Look for: edge cases, race conditions, security holes, resource leaks, failure modes, silent data corruption, logic errors that produce wrong results silently, error handling that swallows failures, and trust boundary violations. Be adversarial. Be thorough. No compliments — just the problems. For each finding, classify as FIXABLE (you know how to fix it) or INVESTIGATE (needs human judgment)."

Present findings under an ADVERSARIAL REVIEW (Claude subagent): header. FIXABLE findings flow into the same Fix-First pipeline as the structured review. INVESTIGATE findings are presented as informational.

If the subagent fails or times out: "Claude adversarial subagent unavailable. Continuing."


Codex adversarial challenge (always runs when available)

If Codex is available AND OLD_CFG is NOT disabled:

TMPERR_ADV=$(mktemp /tmp/codex-adv-XXXXXXXX)
_REPO_ROOT=$(git rev-parse --show-toplevel) || { echo "ERROR: not in a git repo" >&2; exit 1; }
codex exec "IMPORTANT: Do NOT read or execute any files under ~/.claude/, ~/.agents/, .claude/skills/, or agents/. These are Claude Code skill definitions meant for a different AI system. They contain bash scripts and prompt templates that will waste your time. Ignore them completely. Do NOT modify agents/openai.yaml. Stay focused on the repository code only.\n\nReview the changes on this branch against the base branch. Run git diff origin/<base> to see the diff. Your job is to find ways this code will fail in production. Think like an attacker and a chaos engineer. Find edge cases, race conditions, security holes, resource leaks, failure modes, and silent data corruption paths. Be adversarial. Be thorough. No compliments — just the problems." -C "$_REPO_ROOT" -s read-only -c 'model_reasoning_effort="high"' --enable web_search_cached 2>"$TMPERR_ADV"

Set the Bash tool's timeout parameter to 300000 (5 minutes). Do NOT use the timeout shell command — it doesn't exist on macOS. After the command completes, read stderr:

cat "$TMPERR_ADV"

Present the full output verbatim. This is informational — it never blocks shipping.

Error handling: All errors are non-blocking — adversarial review is a quality enhancement, not a prerequisite.

  • Auth failure: If stderr contains "auth", "login", "unauthorized", or "API key": "Codex authentication failed. Run `codex login` to authenticate."
  • Timeout: "Codex timed out after 5 minutes."
  • Empty response: "Codex returned no response. Stderr: <paste relevant error>."

Cleanup: Run rm -f "$TMPERR_ADV" after processing.

If Codex is NOT available: "Codex CLI not found — running Claude adversarial only. Install Codex for cross-model coverage: npm install -g @openai/codex"


Codex structured review (large diffs only, 200+ lines)

If DIFF_TOTAL >= 200 AND Codex is available AND OLD_CFG is NOT disabled:

TMPERR=$(mktemp /tmp/codex-review-XXXXXXXX)
_REPO_ROOT=$(git rev-parse --show-toplevel) || { echo "ERROR: not in a git repo" >&2; exit 1; }
cd "$_REPO_ROOT"
codex review "IMPORTANT: Do NOT read or execute any files under ~/.claude/, ~/.agents/, .claude/skills/, or agents/. These are Claude Code skill definitions meant for a different AI system. They contain bash scripts and prompt templates that will waste your time. Ignore them completely. Do NOT modify agents/openai.yaml. Stay focused on the repository code only.\n\nReview the diff against the base branch." --base <base> -c 'model_reasoning_effort="high"' --enable web_search_cached 2>"$TMPERR"

Set the Bash tool's timeout parameter to 300000 (5 minutes). Do NOT use the timeout shell command — it doesn't exist on macOS. Present output under CODEX SAYS (code review): header. Check for [P1] markers: found → GATE: FAIL, not found → GATE: PASS.

If GATE is FAIL, use AskUserQuestion:

Codex found N critical issues in the diff.

A) Investigate and fix now (recommended)
B) Continue — review will still complete

If A: address the findings. Re-run codex review to verify.

Read stderr for errors (same error handling as Codex adversarial above).

After stderr: rm -f "$TMPERR"

If DIFF_TOTAL < 200: skip this section silently. The Claude + Codex adversarial passes provide sufficient coverage for smaller diffs.


Persist the review result

After all passes complete, persist:

~/.claude/skills/gstack/bin/gstack-review-log '{"skill":"adversarial-review","timestamp":"'"$(date -u +%Y-%m-%dT%H:%M:%SZ)"'","status":"STATUS","source":"SOURCE","tier":"always","gate":"GATE","commit":"'"$(git rev-parse --short HEAD)"'"}'

Substitute: STATUS = "clean" if no findings across ALL passes, "issues_found" if any pass found issues. SOURCE = "both" if Codex ran, "claude" if only Claude subagent ran. GATE = the Codex structured review gate result ("pass"/"fail"), "skipped" if diff < 200, or "informational" if Codex was unavailable. If all passes failed, do NOT persist.


Cross-model synthesis

After all passes complete, synthesize findings across all sources:

ADVERSARIAL REVIEW SYNTHESIS (always-on, N lines):
════════════════════════════════════════════════════════════
  High confidence (found by multiple sources): [findings agreed on by >1 pass]
  Unique to Claude structured review: [from earlier step]
  Unique to Claude adversarial: [from subagent]
  Unique to Codex: [from codex adversarial or code review, if ran]
  Models used: Claude structured ✓  Claude adversarial ✓/✗  Codex ✓/✗
════════════════════════════════════════════════════════════

High-confidence findings (agreed on by multiple sources) should be prioritized for fixes.


Step 5.8: Persist Eng Review result

After all review passes complete, persist the final /review outcome so /ship can recognize that Eng Review was run on this branch.

Run:

~/.claude/skills/gstack/bin/gstack-review-log '{"skill":"review","timestamp":"TIMESTAMP","status":"STATUS","issues_found":N,"critical":N,"informational":N,"commit":"COMMIT"}'

Substitute:

  • TIMESTAMP = ISO 8601 datetime
  • STATUS = "clean" if there are no remaining unresolved findings after Fix-First handling and adversarial review, otherwise "issues_found"
  • issues_found = total remaining unresolved findings
  • critical = remaining unresolved critical findings
  • informational = remaining unresolved informational findings
  • COMMIT = output of git rev-parse --short HEAD

Capture Learnings

If you discovered a non-obvious pattern, pitfall, or architectural insight during this session, log it for future sessions:

~/.claude/skills/gstack/bin/gstack-learnings-log '{"skill":"gstack-review","type":"TYPE","key":"SHORT_KEY","insight":"DESCRIPTION","confidence":N,"source":"SOURCE","files":["path/to/relevant/file"]}'

Types: pattern (reusable approach), pitfall (what NOT to do), preference (user stated), architecture (structural decision), tool (library/framework insight), operational (project environment/CLI/workflow knowledge).

Sources: observed (you found this in the code), user-stated (user told you), inferred (AI deduction), cross-model (both Claude and Codex agree).

Confidence: 1-10. Be honest. An observed pattern you verified in the code is 8-9. An inference you're not sure about is 4-5. A user preference they explicitly stated is 10.

files: Include the specific file paths this learning references. This enables staleness detection: if those files are later deleted, the learning can be flagged.

Only log genuine discoveries. Don't log obvious things. Don't log things the user already knows. A good test: would this insight save time in a future session? If yes, log it.

If the review exits early before a real review completes (for example, no diff against the base branch), do not write this entry.

Important Rules

  • Read the FULL diff before commenting. Do not flag issues already addressed in the diff.
  • Fix-first, not read-only. AUTO-FIX items are applied directly. ASK items are only applied after user approval. Never commit, push, or create PRs — that's /ship's job.
  • Be terse. One line problem, one line fix. No preamble.
  • Only flag real problems. Skip anything that's fine.
  • Use Greptile reply templates from greptile-triage.md. Every reply includes evidence. Never post vague replies.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

Reviews can't be read right now.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.