agentleFS
prinxprinx/agents/skills/quality-review/SKILL.md

quality-review

Skill0 starsChanged 4 months agoMITView on GitHub

Use when reviewing a ticket diff for correctness, regressions, architecture, security, and maintainability.

8 other projects use a version of this.

Adopted by

Most recently taken up by

The file

We split this skill into the rules it gives an agent

1 rule. 0 are common, 1 is distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 6 edited versions we read keep these.

  • 1

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Write actionable findings with severity and location in the diff.

    line 18

“Common” is measured: kept by at least 6 in 10 of the 6 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Quality Review

Review in three sequential phases. Do not skip a phase.

Phase 1 — Run tests. Execute unit, feature, and end-to-end tests. Record exact commands and output. Confirm acceptance criteria are verified. If a test level is not applicable, state why.

Phase 2 — Inspect the diff. Focus on correctness (does the code do what the ticket requires?), security (are inputs handled safely?), and scope (did the developer stay within the ticket?). Do not review for subjective style or naming preferences.

Risk-triggered evidence: Require evidence only when triggered. Security triggers are authentication, authorization, sessions, secrets/credentials, payments, sensitive personal data, security controls, or an untrusted-input/external-data boundary. Accessibility triggers are a user-facing interface, navigation, form, or interactive control. Performance triggers are a hot path, database query pattern, N+1 query risk, response-time budget, large data set processing, memory allocation, bundle size, or caching behavior. Record the trigger, change-specific checks, results, and remaining risk: security covers the relevant boundary, access control, data exposure, and safe handling; accessibility covers keyboard path, semantic/accessible name, focus behavior, and visual readability; performance covers the affected path, measured or estimated cost, and whether the change stays within the existing budget. Missing triggered evidence or an unresolved issue is blocking and requires REQUEST CHANGES; non-triggered changes require no evidence. This is not a scanner, formal compliance assessment, or a reliability or architecture review.

Phase 3 — Write artifacts and decide. Classify findings as blocking (must fix) or advisory (should fix). Write qa-report.md, review.md, and local-test.md. Outcome is APPROVE only if no blocking findings exist.

Write actionable findings with severity and location in the diff. Return concise evidence to the orchestrator; keep detailed findings in the review artifact and never claim checks that were not run.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.