agentleFS
otaviobarrosotaviobarros/agent-engineering/skills/review-change/SKILL.md

review-change

Skill3 starsChanged 21 days agoMITView on GitHub

Review a software change against requirements and project standards. Use for change, branch, or PR reviews. Return validated findings about bugs, security, and maintainability. Stop before remediation.

29 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use write-runbook, incident-triage and 5 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • MaheshAwasareSkill

    write-runbook

    Generate an operational runbook for a service from its code, config, and dependencies — what to do when it breaks, where to look, how to roll back, who to escalate to. Use proactively before a service goes to production, after a major incident, or when handing off operational ownership.

    Also in 3 projects that use this

  • testified-ossSkill

    incident-triage

    Triage production incidents with severity assessment, root cause hypothesis, impact analysis, and escalation recommendations. Use when analyzing outages, errors, or production issues.

    Also in 4 projects that use this

  • srclightSkill

    refactor-safely

    This skill should be used when the user asks to "refactor", "rename", "move", "change a function signature", "extract a method", "delete unused code", "clean up", or any modification that could break callers or dependents. Provides a pre-change safety checklist using srclight's graph tools to assess blast radius before touching code.

    Also in 3 projects that use this

  • Google CloudSkill

    open-pr

    Commits local changes to a new Git branch and opens a GitHub pull request through the configured GitHub MCP server. Use when proposing code changes in a new pull request. Don't use for local-only commits without a remote GitHub repository.

    Also in 4 projects that use this

  • ShopifySkill

    prepare-release

    Prepare the changeset-release/main branch for release by syncing version.ts files and running pnpm install

    Also in 3 projects that use this

  • Microsoft AzureSkill

    release-notes

    Author and update release notes for Azure App Configuration libraries and providers. USE FOR: write release notes, add release note entry, update release notes, draft release notes, new version release notes, format release notes. DO NOT USE FOR: generating changelogs from git history, writing internal engineering notes.

    Also in 3 projects that use this

The file

We split this skill into the rules it gives an agent

3 rules. 0 are common, 3 are distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 25 edited versions we read keep these.

  • 3

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Run tests only under the review rules' test-execution limit.

    line 23
  2. Distinctive:

    Read callers, callees, tests, and configuration beyond the diff as needed.

    line 44
  3. Distinctive:

    Clean verdict: Before returning no findings, try the strongest plausible counterexample.

    line 68

“Common” is measured: kept by at least 6 in 10 of the 25 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Review change

Return evidence-backed findings for one candidate. First read the contract core and the review rules.

Each tool call resends the whole context, so batch reads: read both references and the diff in one command, and the files you need to inspect in as few commands as possible.

1. Pin the candidate

  • Identify the repository, requirements, governing instructions, and the diff. Record base, revision, and relevant dirty inputs. For a PR, fetch its current head. Resolve an ambiguous target before judging it.
  • Missing requirements → Spec coverage gap. Code and commit messages alone do not establish intended behavior.
  • Run tests only under the review rules' test-execution limit.
  • Edits, commits, remote comments, thread resolution, and approval each need their own authorization.

2. Choose reviewers

One fresh reviewer covers all five axes by default. Add a focused specialist only for a material risk the change touches: security or privacy, money, schema or migrations, concurrency, or a public contract. Risk sets this, not size.

  • Independence. A fresh reviewer did not author the candidate and gets neutral context. An implementer reviewing its own work delegates. No delegation → report the missing independent review.
  • Delegation. Each delegate gets the same candidate identity, requirements, scope, permissions, and its assignment. It returns findings, coverage, checks, and gaps, not code summaries. Delegates must see uncommitted inputs in scope; a worktree with only HEAD is a different candidate. Use only approved delegation destinations. Run at most three reviewers at once; reviewers spawn no reviewers.

3. Inspect

Read callers, callees, tests, and configuration beyond the diff as needed.

  • Standards: cite the governing project rule; separate convention from preference.
  • Spec: trace requirements and exclusions through code, tests, and behavior docs; find omissions and unintended changes.
  • Bugs: trace reachable failures, including retries, concurrency, and recovery; check that tests detect the defect.
  • Quality: coupling, state, abstraction cost. Propose a simpler form that keeps required behavior.
  • Security: trust boundaries, permissions, data exposure, and dangerous operations from reachable input to effect.
  • Performance: tie each concern to a reachable workload; label predictions unmeasured.

Claims. For changed docs, comments, or messages that state facts, list each material claim, confirmed ones included. Mark it confirmed, contradicted, or unverified against its governing source, cited as file:line. Cite the line that sets or enforces the value, not the start of its file or function. An uncited claim is unverified. Group claims only when source and conclusion match. Contradictions become findings.

Each finding. Quote the motivating file:line; a finding you cannot quote is unverified. Compare with the base to separate regressions from pre-existing issues.

Clean verdict. Before returning no findings, try the strongest plausible counterexample. Record target, source, and result.

4. Validate and return

Validate and label findings under the review rules; votes do not decide correctness. Order by impact: critical, high, medium, low. Recommend a material redesign for decision; do not apply it. Run the contract's freshness check. Unverified freshness or coverage → review incomplete.

Return this report in your final message even when findings are also saved elsewhere. A saved file does not change its shape. Keep all eight numbered labels, in this order; do not merge, rename, or move them. Fill every slot; write none when empty.

1. Candidate: base, head, dirty inputs | freshness: unchanged, refreshed, or unverified
2. Arrangement: reviewers, axes, specialists, missing coverage
3. Findings by impact, or "no findings":
   label | severity | axis | location | trigger | expected vs observed | evidence | remedy
4. Claims: claim | changed location | status | source file:line
5. Coverage: axis | files or interfaces inspected | not checked
6. Checks: existing evidence | tests run | tests not run
7. Clean verdict only: counterexample | source | result
8. Open questions, gaps, next action

Fictional rows:

4. "Tokens expire after 24 hours" | docs/api.md:12 | confirmed | src/auth/config.py:8
5. Security | src/auth/session.py, POST /login | rate limiting

"No findings" never implies unrun checks passed. Standalone review ends here. In delivery mode, return the report to the caller.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.