agentleFS
osmandapposmandapp/web/.claude/skills/review/SKILL.md

review

Skill63 starsChanged 2 months agoApache-2.0View on GitHub

Review a diff, a branch or a PR - a static line-by-line pass over the diff plus reproduction in the running app, findings reported in chat only. Use for any review request ("отревьюй", "посмотри диф", "проверь мои правки", review of a PR or of the agent's own changes), and before saying "done" about own changes.

192 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use close-spec, design-with-images and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • dzhngSkill

    close-spec

    When a spec under specs/<feature>/ is done shipping (a write-spec build, or any planned task that produced a spec), archive it to specs/done/ and rewrite it from a build-plan into a durable rationale — the why, the principles, the invariants — pointing back to the real code for the how. Use when implementation has landed and the plan no longer matches what shipped, or the user says a feature/spec is finished. Pairs with [write-spec](../write-spec/SKILL.md) (the plan this closes) and [review](../review/SKILL.md) (run before closing).

    Also in 5 projects that use this

  • dzhngSkill

    design-with-images

    Explore UI and visual design with image generation, then iterate the real implementation against the user-selected concept. Use when brainstorming visual directions, offering mockup variants, or implementing an approved generated design; do not stop at the mockups or the first code approximation.

    Also in 5 projects that use this

  • LambenthanSkill

    daily-arxiv

    每日从 arXiv 拉取新论文,过滤相关性,auto-ingest 高优先级论文,检测 SOTA 更新

    Also in 5 projects that use this

  • LambenthanSkill

    exp-eval

    实验判决门:Review LLM 独立评判实验结果 → 4 种判决路径 → 自动更新 claims confidence、ideas status、graph edges

    Also in 5 projects that use this

  • +3 more from dzhng
  • +5 more from Lambenthan

The file

We split this skill into the rules it gives an agent

2 rules. 0 are common, 2 are distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 157 edited versions we read keep these.

  • 2

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    1. Static pass over the diff, line by line: Read the diff as a reviewer who cannot run anything (this is what Copilot does well and what …

    line 12
  2. Distinctive:

    When reviewing someone else's review (Copilot, a colleague), check each finding against the current code before agreeing: some are written …

    line 30

“Common” is measured: kept by at least 6 in 10 of the 157 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Review

Complements /code-review, does not replace it: run that skill for its checks, then add the two passes below. Findings from both go into one list.

Two passes, one does not replace the other

1. Static pass over the diff, line by line. Read the diff as a reviewer who cannot run anything (this is what Copilot does well and what reproduction misses). For every changed hunk ask:

  • who else writes the same state? list every writer, not only the one in the diff;
  • what can run between an await and the write that follows it? a newer request, a newer effect, a cleanup;
  • which other paths do the same job? a second effect, a second caller, a fallback branch - a fix applied to one of them is not a fix;
  • what happens on the early return, the error branch, the aborted branch? which flags stay set;
  • does a guard cover every exit, or only the happy one?

2. Reproduction pass in the running app. Reproduce the defect before the fix and re-check after it. Force the case if it is not reachable by hand (hold a promise, stub a value) instead of declaring it untestable.

The static pass catches what a scenario never hits; reproduction catches what the diff does not show. Skipping either one is how a regression ships.

Apply both to own changes too: before the words "готово" / "done", re-read own diff as if someone else wrote it.

Reporting

Say plainly which findings are proven by code, which are reproduced, and which are guesses.

When reviewing someone else's review (Copilot, a colleague), check each finding against the current code before agreeing: some are written against an older revision and are already fixed.

Never publish

Findings go into the chat only. No inline comments, no PR comment, no review, no --comment, no gh pr comment / gh pr review. The author decides what goes into the PR, finding by finding.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.