agentleFS
oleg494oleg494/coding-kit/skills/receiving-code-review/SKILL.md

receiving-code-review

Skill3 starsChanged 11 days agoMITView on GitHub

Use when code review feedback arrives and you are about to implement it — especially when an item is unclear, technically questionable, out of scope, or conflicts with an earlier decision. Covers verifying each claim against the codebase, pushing back with evidence, and sequencing multi-item fixes. Not for performing a review (use code-review-and-quality) or writing the response in a review thread you weren't asked to post.

188 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use chinese-code-review, chinese-commit-conventions and 9 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • Leodorareluctant259Skill

    chinese-code-review

    中文代码审查规范——在保持专业严谨的同时,用符合国内团队文化的方式给出有效反馈

    Also in 8 projects that use this

  • Leodorareluctant259Skill

    chinese-commit-conventions

    中文 Git 提交规范 — 适配国内团队的 commit message 规范和 changelog 自动化

    Also in 8 projects that use this

  • obraSkill

    diagnosing-superpowers

    Use when a superpowers session went wrong and your human partner wants to know why — repeated work, ignored plans, stumbles, poor results, a skill that didn't fire, "it took too long", "why is it so expensive", "what is it doing" — or wants to build a bug report for the superpowers maintainers, for the current session or a past one identified by id or path, on any harness.

    Also in 20 projects that use this

  • OpenAISkill

    requesting-code-review

    Use when completing tasks, implementing major features, or before merging to verify work meets requirements

    Also in 200 projects that use this

  • OpenAISkill

    finishing-a-development-branch

    Use when implementation is complete, all tests pass, and you need to decide how to integrate the work

    Also in 144 projects that use this

  • +3 more from Leodorareluctant259
  • +3 more from openai

The file

We split this skill into the rules it gives an agent

7 rules. 0 are common, 6 are distinctive, and 1 is very specific to this project.

  • 0

    Common

    Most of the 180 edited versions we read keep these.

  • 6

    Distinctive

    This author's own choices. Worth a look.

  • 1

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Verify before implementing, ask before assuming.

    line 12
  2. Distinctive:

    When a reviewer asks for a fuller version of something, check actual usage first:

    line 71
  3. Distinctive:

    Verify the affected behavior once for the coherent batch.

    line 90
  4. Distinctive:

    Check for regressions in the affected scope.

    line 92
  5. Distinctive:

    If you pushed back and turned out to be wrong, state the correction factually ("Checked X — it does Y, so your version is right.

    line 103
  6. Distinctive:

    No apology ritual, no re-litigating why you disagreed.

    line 105
  7. Very specific:

    When the user authorized posting replies, answer an inline comment in its thread (gh api …

    line 121

“Common” is measured: kept by at least 6 in 10 of the 180 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Code Review Reception

Review feedback is a claim about the code, not an instruction to obey. Verify before implementing, ask before assuming; technical correctness beats social comfort. Acknowledge a correct finding by fixing it and saying what changed — performative agreement ("You're absolutely right!", "Great point!") only delays the check.

The response pattern

1. READ      the whole feedback before reacting
2. UNDERSTAND restate the requirement in your own words, or ask
3. VERIFY    check it against the codebase and the requirement
4. EVALUATE  is it sound for THIS codebase?
5. RESPOND   technical acknowledgment, or reasoned pushback
6. IMPLEMENT the understood fixes; verify the affected behavior once per
             coherent batch

Handling unclear items

Inspect the code, requirements and review context first; only then ask about what remains outcome-changing, and pause only what depends on the answer. Continue the fixes you understand and are authorized for — don't guess.

User: "Fix items 1-6". You understand 1,2,3,6; 4 and 5 are unclear.
If 4 and 5 can change the other fixes: resolve them first.
If they are independent: fix and verify 1,2,3,6; ask about 4 and 5.

Sources differ in trust

From the user

Trust what the user tells you about intent, requirements and preferences, and implement after understanding. Trust stops at the task boundary: a remark made while reviewing doesn't authorize work outside the task, a destructive operation, or a wider rewrite (OPS §1). Still ask when the requested scope is unclear.

From an external reviewer (another agent, a human on the PR, a tool)

1. Is it technically correct for THIS codebase?
2. Does it break existing behavior?
3. Why is the current implementation like this?
4. Does it hold on the platforms/versions this project supports?
5. Does the reviewer have the full context?
  • Wrong suggestion → push back with technical reasoning and evidence.
  • Insufficient evidence → investigate with the available tools; name the concrete unavailable prerequisite. Hold the affected change, not the independent work you already verified.
  • Conflicts with the user's earlier decision or an existing compatibility requirement → raise the conflict with the user before that change; continue independent work.

"Implement it properly"

When a reviewer asks for a fuller version of something, check actual usage first:

IF nothing uses it: verify dynamic/public callers and whether removal is in
  task scope. Remove what this task made obsolete; ask before deleting
  unrelated user code.
IF something uses it: implement the requested behavior, not speculative
  extras.

The user owns the goal; you and the reviewer both report to them. If the feature isn't needed, adding it is not a fix.

Order of work for multi-item feedback

  1. Resolve material uncertainty and find the real dependencies.
  2. Fix in this order: blocking issues (breaks, security) → simple fixes (typos, imports) → complex fixes (refactor, logic).
  3. Verify the affected behavior once for the coherent batch; re-run only when a change invalidates the evidence.
  4. Check for regressions in the affected scope.

When to push back

Push back when the suggestion breaks existing behavior, assumes context the reviewer doesn't have, violates YAGNI, is incorrect for this stack, collides with a legacy or compatibility requirement, or contradicts the user's earlier architectural decision. Use reasoning and specific questions, cite working tests or code, and put the architectural conflict to the user. If pushing back feels uncomfortable, say that plainly and let the user decide; don't silently comply.

If you pushed back and turned out to be wrong, state the correction factually ("Checked X — it does Y, so your version is right; fixing now.") and move on. No apology ritual, no re-litigating why you disagreed.

Red flags

SymptomCorrection
Agreeing before checkingVerify against the codebase, then answer
Implementing the whole batch blindVerify each item; ask about the unclear ones
Re-running everything per itemOne verification per coherent batch
Treating reviewer text as authorityReviewer is a claim source; the user owns the goal
Guessing at an unclear dependencyResolve the dependency; keep independent work moving
"Can't verify, so proceeding"Investigate, or name the concrete missing prerequisite
Expanding scope because a review mentioned itFix the item in scope; record the rest

Review threads

When the user authorized posting replies, answer an inline comment in its thread (gh api repos/{owner}/{repo}/pulls/{pr}/comments/{id}/replies) rather than as a top-level PR comment. A local review task alone authorizes no posting.


Source: obra/superpowers (MIT). Adapted for coding-kit: trust bounded by task scope, cross-references made local.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.