agentleFS
mojopolymojopoly/three-loops/skills/respond-to-review/SKILL.md

respond-to-review

Skill0 starsChanged 3 months agoMITView on GitHub

Process code-review findings — from an automated reviewer or a human — point by point, with judgment. Use when a review lands on a PR and the findings need to be resolved.

6 other projects use a version of this.

Adopted by

Most recently taken up by

The file

We split this skill into the rules it gives an agent

3 rules. 0 are common, 3 are distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 6 edited versions we read keep these.

  • 3

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    If a round lands after your last commit, the PR is not done — findings outstanding at merge time must be explicit deferrals, never silence.

    line 47
  2. Distinctive:

    When the operator can't audit patches, findings are arbitrated in behavior terms instead: convert each finding into a question about …

    line 52
  3. Distinctive:

    If you have not declined a finding in recent memory, you are in relay mode — the reviewer is doing your judgment for you.

    line 62

“Common” is measured: kept by at least 6 in 10 of the 6 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Respond to Review

An adversarial reviewer is only as valuable as the argument you have with it. Bulk-accepting every finding turns the reviewer into your last line of defense (it will eventually miss); ignoring findings for days rots the PR. The protocol: every finding answered, in hours, with judgment.

Protocol

  1. Number every finding from all review rounds. Nothing unaddressed — an unanswered finding reads as an unread one.
  2. For each, choose one of three verbs:
    • Accept — fix it AND add the regression test that would have caught it. A fix without a test is the same bug with better luck.
    • Decline — with a reason grounded in the code ("the guard at L590 deliberately lets stale rows through; excluding them here would break the documented recovery path"), not in preference. Declining well is the signal you're reviewing the reviewer.
    • Defer — real, but not this PR. File the ticket in the same breath and link it.
  3. Audit suggested patches before applying. Reviewer fixes carry their own bugs — check the proposed ordering, the edge the reviewer didn't consider, the interaction with code outside the diff. Finding a bug in the reviewer's fix is the protocol working, not friction.
  4. Reply once per round, point by point, with verification evidence: test counts before/after, typecheck status, and the live-drive proof if behavior changed. Format:

    Addressed in <commit> — point by point:
    1. <finding> — fixed; regression test `<name>`. One deviation from the
       suggested patch: <why the suggestion had a hole, what was done instead>.
    2. <finding> — declined: <code-grounded reason>.
    3. <finding> — deferred to <ticket>: <why it's separable>.
    Verification: typecheck clean; tests X → Y, 0 failures; re-drove <flow>.

Tempo

  • Answer within hours. A finding answered same-day costs one context reload; answered next week it costs a full re-review.
  • If a round lands after your last commit, the PR is not done — findings outstanding at merge time must be explicit deferrals, never silence.

Non-coding operators

When the operator can't audit patches, findings are arbitrated in behavior terms instead: convert each finding into a question about observable behavior, require the fix demonstrated live (both orderings, for races), and decline only on product grounds anchored in the PRD or PRINCIPLES.md — never on "seems unlikely". The accept-with-test rule survives translation: accepted means fixed, demonstrated, and pinned by a regression test. Full protocol: docs/pm-onramp.md.

Self-check

If you have not declined a finding in recent memory, you are in relay mode — the reviewer is doing your judgment for you. If reviewers keep finding the same category (timezone edges, missing failure paths), that category belongs in your /interrogate checklist, upstream of generation.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.