agentleFS
moberghrmoberghr/mtk-agent-toolkit/.claude/skills/code-review-and-quality/SKILL.md

code-review-and-quality

Skill8 starsChanged 3 days agoMITView on GitHub

Review a PR (pull request), branch or diff outside implement — runs the compliance, silent-failure, test and architecture lanes with full lane accounting.

84 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use constraint-driven-development, observability-and-instrumentation and 9 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • MrCipherSmithSkill

    constraint-driven-development

    Use when a project needs a persistent, measurable quality bar — starting a project without documented standards, 'set up constraints', or when coverage/perf/a11y thresholds get re-debated per-PR. Produces CONSTRAINTS.md with enforceable numbers, ratchets, and a guard against silent weakening. NOT for throwaway prototypes or a one-off CI setup.

    Also in 15 projects that use this

  • HK-hubSkill

    observability-and-instrumentation

    Instruments code so production behavior is visible and diagnosable. Use when adding logging, metrics, tracing, or alerting. Use when shipping any feature that runs in production and you need evidence it works. Use when production issues are reported but you can't tell what happened from the available data.

    Also in 34 projects that use this

  • HK-hubSkill

    deprecation-and-migration

    Manages deprecation and migration. Use when removing old systems, APIs, or features. Use when migrating users from one implementation to another. Use when deciding whether to maintain or sunset existing code.

    Also in 34 projects that use this

  • seikaikyoSkill

    doubt-driven-development

    對非平凡決策啟動新鮮 context 對抗審查(找碴不背書),在修正還便宜的時候抓出錯誤方向。適用:高風險改動(production、資安敏感邏輯、不可逆操作)、不熟的程式碼、要宣稱「這樣是安全的 / 可行的」之前。機械性操作與一行修改不適用。

    Also in 37 projects that use this

  • seikaikyoSkill

    interview-me

    需求不明時的意圖萃取訪談:一次一題、每題附上自己的猜測、聽出「真正想要 vs 覺得應該要」,直到能預測使用者反應(約 95% 信心)才動工。適用:需求缺少對象 / 動機 / 成功標準 / 約束,或使用者點名「訪談我」「先確認一下」「我們確定嗎」。明確自足的指示、純資訊查詢、機械性操作不適用。

    Also in 37 projects that use this

  • JetBrainsSkill

    modern-web-guidance

    Search tool for modern web development best practices. MANDATORY: Execute FIRST for all HTML/CSS and clientside JS tasks. Do NOT skip — web APIs evolve rapidly and training weights contain obsolete patterns.

    Also in 3 projects that use this

  • +1 more from HK-hub

The file

We split this skill into the rules it gives an agent

1 rule. 0 are common, 0 are distinctive, and 1 is very specific to this project.

  • 0

    Common

    Most of the 77 edited versions we read keep these.

  • 0

    Distinctive

    This author's own choices. Worth a look.

  • 1

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Very specific:

    Read .claude/references/implement-review-lanes.md and pick lanes from its Outside implement column: compliance-reviewer always.

    line 27

“Common” is measured: kept by at least 6 in 10 of the 77 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Code Review And Quality

MTK File Resolution

Resolve MTK skill/reference/script paths per .claude/references/mtk-file-resolution.md unless the router already stated MTK_ROOT=<path> this session; CLAUDE.md, .claude/tech-stack, .claude/rules/, tasks/, docs/, .mtk/ stay project-relative.

Overview

Adversarial review of a PR or diff that did not come through implement (implement Phase 4 reads the reference directly). This skill is read-only except for workflow-artifact recording.

When To Use

  • Reviewing a PR, branch, or local diff before merge, outside the implement loop

Workflow

  1. Get the diff (gh pr diff <n> or git diff <base>...HEAD) and the changed-file set; exclude files that were already dirty before the change.
  2. Read .claude/references/implement-review-lanes.md and pick lanes from its Outside implement column: compliance-reviewer always; silent-failure-hunter when the trigger regex matches; test-reviewer when public behavior changed; architecture-reviewer on a new slice, boundary, or cross-project call.
  3. Dispatch them per Dispatch rules (inline when the Agent tool is unavailable) following the Review protocol (scripts via $MTK_ROOT; no workflow artifact here, so skip review-input binding and say the review is unbound), run the Defect-class sweep on every confirmed finding, and apply Lane accounting before aggregating. finding-verifier is implement-only (HIGH/MAX).
  4. Emit the findings table and fenced JSON per .claude/references/review-finding-schema.md, with the lane roster. Write the push receipt only as the protocol's Receipt step qualifies (its --check clause is implement-only).

Verification

  • Every dispatched lane is accounted for; the verdict is not PASS while any lane abstained or returned nothing
  • Findings follow the schema; an empty findings[] carries below_threshold_rationale

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.