agentleFS
mnzraleemnzralee/claude-multi-agent-architecture/.claude/skills/review/SKILL.md

review

Skill8 starsChanged 45 days agoMITView on GitHub

Code review skill covering security, correctness, type safety, and maintainability for any software project

192 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use close-spec, daily-arxiv and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • dzhngSkill

    close-spec

    When a spec under specs/<feature>/ is done shipping (a write-spec build, or any planned task that produced a spec), archive it to specs/done/ and rewrite it from a build-plan into a durable rationale — the why, the principles, the invariants — pointing back to the real code for the how. Use when implementation has landed and the plan no longer matches what shipped, or the user says a feature/spec is finished. Pairs with [write-spec](../write-spec/SKILL.md) (the plan this closes) and [review](../review/SKILL.md) (run before closing).

    Also in 5 projects that use this

  • LambenthanSkill

    daily-arxiv

    每日从 arXiv 拉取新论文,过滤相关性,auto-ingest 高优先级论文,检测 SOTA 更新

    Also in 5 projects that use this

  • dzhngSkill

    design-with-images

    Explore UI and visual design with image generation, then iterate the real implementation against the user-selected concept. Use when brainstorming visual directions, offering mockup variants, or implementing an approved generated design; do not stop at the mockups or the first code approximation.

    Also in 5 projects that use this

  • LambenthanSkill

    exp-eval

    实验判决门:Review LLM 独立评判实验结果 → 4 种判决路径 → 自动更新 claims confidence、ideas status、graph edges

    Also in 5 projects that use this

  • +5 more from Lambenthan
  • +3 more from dzhng

The file

We split this skill into the rules it gives an agent

4 rules. 0 are common, 4 are distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 156 edited versions we read keep these.

  • 4

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Understand the change: - Read the PR description and commits

    line 14
  2. Distinctive:

    Verify patterns: - Ensure code follows project conventions

    line 16
  3. Distinctive:

    Test coverage: - Check if tests cover the changes

    line 17
  4. Distinctive:

    Add a section here for each additional language or runtime your project uses (Go, Python, Java, etc.).

    line 67

“Common” is measured: kept by at least 6 in 10 of the 156 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Code Review Skill

Review code changes following enterprise-grade engineering standards. The checklists, comment templates, and command patterns here apply to any software project regardless of stack (examples use TypeScript / Node / React; the discipline is stack-agnostic).


Review Process

  1. Understand the change - Read the PR description and commits
  2. Check for issues - Security, bugs, performance, maintainability
  3. Verify patterns - Ensure code follows project conventions
  4. Test coverage - Check if tests cover the changes
  5. Provide feedback - Clear, actionable comments

Review Checklist by Area

Security (CRITICAL)

  • No hardcoded secrets, passwords, or API keys
  • Input validation on all user inputs
  • SQL injection prevention (parameterized queries)
  • XSS prevention (output encoding)
  • Authentication checks on protected endpoints
  • Authorization checks (role-based access)
  • No sensitive data in logs
  • Secure error messages (no stack traces to client)

TypeScript/JavaScript

  • No any types - use proper type definitions
  • No unused variables or imports
  • Async/await error handling (try/catch)
  • No console.log in production code
  • Proper null/undefined checks
  • No hardcoded strings (use constants)

React/Frontend

  • Components follow naming convention (PascalCase)
  • Hooks follow rules (no conditional hooks)
  • Loading states handled
  • Error states handled
  • Empty states handled
  • Form validation implemented
  • Accessibility (ARIA labels, keyboard nav)
  • Responsive design verified
  • Error handling uses the project's centralized error module
  • API routes use the shared error handler utility, not inline ad-hoc error construction
  • Components use the project's API call wrapper, never raw new Error(message) directly
  • Error messages come from the project's error-code registry, no duplicated message strings
  • Form errors use the shared form-error handler for consistent toast and field display

Backend/API

  • DTOs defined for request/response
  • Input validation with proper error messages
  • Authentication middleware applied
  • Structured logging at key points
  • Error handling with proper status codes
  • Multi-tenant queries are scoped to the correct tenant
  • Transactions for multi-table operations

[CUSTOMIZE: additional language/runtime]

Add a section here for each additional language or runtime your project uses (Go, Python, Java, etc.). For each, list:

  • Authorization check is FIRST operation
  • All inputs validated
  • Errors wrapped with context
  • Events or side-effects emitted for state changes
  • Idempotency handled for non-idempotent operations

Database

  • Migrations are reversible
  • Indexes on frequently queried columns
  • Foreign keys properly defined
  • No N+1 query patterns
  • Transactions for related changes

Comment Templates

Request Change

**Issue:** [Brief description]

[Explanation of the problem]

**Suggestion:**
```suggestion
// Fixed code here

### Ask Question

Question: [Your question]

[Context or reason for asking]


### Approve with Note

Note: [Observation]

[Minor suggestion or future consideration - not blocking]


### Security Concern

Security: [Issue description]

[Explanation of risk]

Required fix: [How to fix it]


---

## Common Issues to Flag

### Security
```typescript
// BAD: SQL injection risk
const query = `SELECT * FROM users WHERE id = '${userId}'`;

// GOOD: Parameterized query (using your ORM)
const user = await db.user.findUnique({ where: { id: userId } });

Error Handling

// BAD: Swallowing errors
try {
  await doSomething();
} catch (e) {
  // Silent fail
}

// GOOD: Handle or propagate
try {
  await doSomething();
} catch (error) {
  logger.error({ error }, 'Failed to do something');
  throw error;
}

Type Safety

// BAD: any type
const data: any = response.data;

// GOOD: Proper typing
interface UserResponse {
  id: string;
  name: string;
}
const data: UserResponse = response.data;

React Performance

// BAD: Creating function on every render
<Button onClick={() => handleClick(item.id)}>Click</Button>

// GOOD: Memoized callback
const handleItemClick = useCallback((id: string) => {
  handleClick(id);
}, [handleClick]);

Async State

// BAD: Not handling loading/error
const { data } = useQuery(...);
return <div>{data.name}</div>; // Crashes if data is undefined

// GOOD: Handle all states
const { data, isLoading, isError } = useQuery(...);
if (isLoading) return <Skeleton />;
if (isError) return <ErrorState />;
return <div>{data.name}</div>;

Review Commands

Get PR Diff

# View PR changes
gh pr diff <number>

# View specific file changes
gh pr diff <number> -- path/to/file.ts

# View PR details
gh pr view <number>

Checkout PR Locally

# Checkout PR branch
gh pr checkout <number>

# Run tests locally
npm test

# Build locally
npm run build

Add Review Comments

# Start review
gh pr review <number>

# Approve
gh pr review <number> --approve -b "LGTM!"

# Request changes
gh pr review <number> --request-changes -b "Please address the security concern."

# Comment only
gh pr review <number> --comment -b "A few suggestions..."

Review Response Format

## Review Summary

**Status:** [Approve / Request Changes / Comment]

### What I Reviewed
- [List of files/features reviewed]

### Findings

#### Critical (Must Fix)
- [ ] [Issue 1 with file:line reference]
- [ ] [Issue 2 with file:line reference]

#### Important (Should Fix)
- [ ] [Issue with explanation]

#### Minor (Consider)
- [ ] [Suggestion or optimization]

### What Looks Good
- [Positive feedback on well-done aspects]

### Questions
- [Any questions about the implementation]

Apply to: $ARGUMENTS

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.