reviewer-godot
Skill0 starsChanged 59 days agoMITView on GitHub
Review Godot 4 projects: GDScript (.gd), scenes and resources (.tscn, .tres), project.godot, export_presets.cfg and shaders. Use when reviewing changes to any of these files, or when the user types /reviewer-godot. Catches type-inference and JSON number bugs, node lifecycle mistakes, export-only breakage (missing include filters, res:// writes, unimported class_name globals), web and Android export pitfalls, and container layout traps. Part of the reviewer bundle.
In this repository15 other files it gives its agents.
- ai-scaffoldingSkill
- comment-hygieneSkill
- microfrontendsSkill
- reviewer-cloudflareSkill
- reviewer-dataSkill
- reviewer-docsSkill
- reviewer-pythonSkill
- reviewer-readabilitySkill
- reviewer-shellSkill
- reviewer-toolingSkill
- reviewer-unitySkill
- reviewer-webSkill
- reviewerSkill
- startup-scriptSkill
- typed-blocksSkill
The file
We split this skill into the rules it gives an agent
2 rules. About 0 are common, 0 are distinctive, and 2 are very specific to this project.
≈0
Common · estimate
Many files like this have a rule of this kind.
≈0
Distinctive · estimate
This author's own choices. Worth a look.
2
Very specific
Tied to their project's names, files or tools. Probably skip.
- Common
- Distinctive
- Very specific
- Very specific: line 13
Read project.godot: autoloads, renderer, display and stretch settings, and the input map.
- Very specific: line 92
Use the reviewer format: [severity] path:line — problem, then failure: (the concrete input, state or platform → wrong result) and fix: (the …
≈ “Common” is an estimate: at least 1 in 5 of the 372,429 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.
Files
Godot reviewer
Scope: *.gd, *.tscn, *.tres, *.gdshader, project.godot, export_presets.cfg. Assumes Godot 4.x; check config/features in project.godot for the exact version.
Before reviewing
- Read
project.godot: autoloads, renderer, display and stretch settings, and the input map. - Find how tests run (headless
--script, test scenes, CI) and run them. Fresh checkouts needgodot --headless --path <dir> --importfirst, orclass_nameglobals fail to resolve.
Checklist
Typing and values
:=on a Variant right-hand side (dictionary lookup, JSON, an autoload method with no return type) fails with "Cannot infer the type". Use an explicit type.JSON.parse_stringreturns every number as a float.{"a": 1}loaded from disk is not equal to{"a": 1}built in code,1.0keys miss1keys, and"%d"truncates. Normalize withint()where a value is an integer./on two ints is integer division (5 / 2 == 2).- Typed arrays (
Array[String]) reject assignment from untyped arrays at runtime. Use.assign().
Node lifecycle
queue_free()keeps the node in the tree until the frame ends. A new child added with the same name is renamed (Label2,@Label@3), so lookups by name or path break. Callremove_child()first, or don't depend on names.- Any use after
await, a timer or a tween must checkis_instance_valid(). The node or its target may have been freed meanwhile. @onreadyvars are null in_init(). Children get_ready()before their parent.- Signals connected to lambdas that capture a node outlive that node. Disconnect them, or connect with the node as the target.
RandomNumberGenerator.new()is not randomized. Callrandomize()or set a seed on purpose (tests).
Files and persistence
res://is read-only in exports. Write user data touser://.- Writes that must survive a crash: write a
.tmpfile, thenDirAccess.rename_absolute(). Loading must survive missing or corrupt files with a default, not a crash. FileAccess.open()returns null on failure. Check it andFileAccess.get_open_error().- Non-resource files the game reads (
*.json,*.txt,*.md,*.csv) ship only ifinclude_filterinexport_presets.cfglists them. They work in the editor and are missing in the export. Image.load_from_file("res://…")works only in the editor (tools). Game code mustload()the imported resource.
UI
- Containers own their children's position and size. Setting
sizeorpositionon a child of a container is overwritten. Usecustom_minimum_sizeand size flags. - A
Labelwith autowrap inside anHBoxContainerand no width collapses to one letter per line. Give itSIZE_EXPAND_FILLor turn autowrap off. - Decorative Controls drawn over buttons must use
mouse_filter = MOUSE_FILTER_IGNORE, or they swallow clicks. - Glyphs missing from the font render as boxes (●, ⌫, arrows). Check the font's coverage, or draw the shape or use an icon.
- Text that must fit (buttons, tiles) at the longest content and smallest supported resolution.
Performance
- No
get_node(),find_child(), allocation or string building in_process/_physics_processwhen it can be cached. Prefer signals to polling.
Export targets
- Web: thread support needs COOP/COEP headers. Audio starts only after a user gesture.
JavaScriptBridgemust sit behindOS.has_feature("web"). The generated service worker serves the old.pckuntil it is patched or the version changes. - Android:
display/window/handheld/orientationis an int (1= portrait). A string is silently ignored. Dev and release builds need distinct package names.version/codemust increase for every store upload. Keystores and passwords never go inexport_presets.cfgor the repo; use env vars orcredentialsoutside git. export_presets.cfgmust not contain absolute paths from one machine, unless the project accepts that.
Scenes and project files
.tscndiffs should contain only the intended change. Flag editor noise (reordered nodes, unrelatedunique_idchurn) that hides real edits.ext_resourcepaths anduid://references must resolve after moves and renames. Every new script has its.uidcommitted (Godot 4.4+)..godot/is never committed.- Autoload names in
project.godotmust match the names the code uses. Renaming aclass_namebreaks every reference to it, including other scenes.
Conventions (official style guide, unless the project differs)
- Tabs;
snake_casefiles, functions and variables;PascalCaseclass_name;CONSTANT_CASEconstants. - Signals in past tense (
answered,round_finished). Handlers named_on_<source>_<signal>. ##doc comments on classes and functions the project documents. Static types wherever the project uses them.- Gameplay numbers in a data or tuning file when the project has one, not hard-coded.
Tests
- Headless tests must exit non-zero on failure (
quit(1)), and new tests are registered in the runner or CI list.
Readability
Apply reviewer-readability to the same files (names, structure, dead code, and whether comments are true, needed and well-shaped), plus:
##doc comments sit above the class (class_name), functions, signals and exported vars the project documents;#for inline notes. Typed signatures already document types, so the comment says purpose and side effects.- Member order follows the style guide (signals, enums, constants, exports, vars,
@onready, built-in callbacks, public, private) unless the project has its own. - Scene-tree lookups by long
$Path/To/Nodestrings in many places read worse than one@onreadyvar with a clear name.
Not findings
- Missing types in a project that does not use static typing.
@warning_ignorewith a reason.- Editor-generated formatting of
.tscnfiles when the content change is intended.
Report
Use the reviewer format: [severity] path:line — problem, then failure: (the concrete input, state or platform → wrong result) and fix: (the smallest change). Most severe first. Prove each finding before reporting it, and say No findings with what you checked when there are none.
Does it work?
Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.
No reviews yet
People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.
- It worked
- Partly
- It didn't
Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.
Your trail
Files you open will collect here, so you can find them again.
Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.
Now do this for your own.
Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.

