agentleFS
luisgui1757luisgui1757/sentinel/skills/sol-loop/SKILL.md

sol-loop

Skill0 starsChanged 9 days agoMITView on GitHub

Use when the user says "sol loop".

9 other projects use a version of this, 8 of them edited.

Adopted by

Most recently taken up by

Used with

Projects with it also use takeover.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • assisjpSkill

    takeover

    Take over an existing branch, pull request, worktree, or agent handoff while preserving the original goal, contributor credit, and concurrent work. Use when the user asks to take over, finish, rescue, or continue someone else's implementation. Do not use to replace a clear request to start new work.

    Also in 3 projects that use this

The file

Show its rules and text

We split this skill into the rules it gives an agent

13 rules. 8 are common, 2 are distinctive, and 3 are very specific to this project.

  • 8

    Common

    Most of the 9 edited versions we read keep these.

  • 2

    Distinctive

    This author's own choices. Worth a look.

  • 3

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Common:

    Default: 3 rounds total. Round 1 is full.

    line 17
  2. Common:

    Stop early if a round returns only nits.

    line 22
  3. Common:

    Keep a ledger: id, severity, outcome, usage if returned.

    line 25
  4. Common:

    Run git status --short. Do not stash, discard, or include unrelated changes.

    line 29
  5. Common:

    Use one diff command all rounds.

    line 44
  6. Distinctive:

    If no route runs Sol, report the blocker.

    line 64
  7. Common:

    Do not edit scoped files while review runs.

    line 66
  8. Common:

    Check each finding and severity yourself.

    line 88
  9. Very specific:

    Update the ledger. Re-run checks and git diff --shortstat <base>.

    line 97
  10. Very specific:

    Start one only if budget remains and a blocker or should is open, behavior code changed, or approval does not cover the current behavior …

    line 102
  11. Common:

    Do not push during the loop.

    line 116
  12. Very specific:

    Add on <effort> only if verified.

    line 122
  13. Distinctive:

    Put your own findings in the same ledger.

    line 126

“Common” is measured: kept by at least 6 in 10 of the 9 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

sol-loop

This is a workflow for making your code changes more correct before (or sometimes after) filing a pull request. tl;dr - use OpenAI's GPT Sol to review your code in a loop.

Make the most minimal possible changes to appease the Sol reviewers. Be careful of scope creep and don't be scared to push back.

Budget

  • Default: 3 rounds total. Round 1 is full. Later rounds check only changed code and open findings.
  • Extend to 5 only for security, permissions, auth, data loss, or state/concurrency, while a blocker or should stays open with evidence. Or when the user asks.
  • Stop early if a round returns only nits. Declined nits and comment, doc, or format-only fixes need no new round.
  • One reviewer only. Sol must not start subagents or reviewers.
  • Keep a ledger: id, severity, outcome, usage if returned. Never guess it.

1. Scope

Run git status --short. Do not stash, discard, or include unrelated changes. Limit review to the change paths if they separate cleanly. Otherwise stop and ask.

Find the base after git fetch origin:

  • PR: gh pr view <n> --json baseRefName,headRefOid. On another forge, use its CLI or API for the same step. Find the forge from the PR URL, the remote URL, the CI files and the signed-in CLIs. Check out the branch only if clean. Confirm HEAD is the PR head, or ahead only by this change. Base: git merge-base HEAD origin/<baseRefName>.
  • Local: git merge-base HEAD origin/<default-branch>. No remote: a base the user names, or HEAD for uncommitted changes only.

The change is base to working tree in those paths, with untracked files. Use one diff command all rounds. State intent and out-of-scope in 1-2 sentences. Run covering checks. Do not send code this change breaks. Note missing or pre-failing checks in the brief.

2. Start Sol

In T3, call orchestrator_capabilities. Pick the latest Sol unless the user named a version. Do not hardcode an ID. Use high effort unless the user names another effort. Record provider, model, and effort only if exposed. Use delegate_task every round (role: "review", mode: "async"). Save taskId. New clientRequestId per round. childThreadId is storage, not the next target. Do not use t3_thread_send, create_threads, or t3_thread_launch for review.

In T3 Code, if its tools are not listed, try one direct capability call. Outside T3, use a native Sol subagent and keep its ID. In Claude Code, use a custom subagent only if it is set up to run Sol. Otherwise, start each round as a background command with the brief on stdin: codex exec --sandbox read-only --model <Sol ID> -c model_reasoning_effort=<effort> -. Without the Codex CLI, use another CLI from the council skill that runs Sol. If no route runs Sol, report the blocker. Do not substitute a model.

Do not edit scoped files while review runs. Wait for the notice. Do not poll or start a second reviewer. Timeout, error, or no reply is not approval. On failure, cancel, verify stop, restart with the ledger.

Round 1 brief (T3 children and CLI reviewers get no history):

Review only. Do not edit, commit, push, comment on PRs, or start subagents.
Repo: <abs path> Base: <sha> Intent: <intent> Out of scope: <scope> Checks: <results>
See: git diff <base> [-- <paths>]; git status --short (read untracked).
Read surrounding code. Find bugs, broken callers, mismatch with intent.
Skip style unless it hides a bug. Hold to the smallest change. Flag code,
tests, or guards the intent does not need. Other paths, rare cases, small
perf, extra compat: nits.
blocker = intended case wrong. should = real bug callers will hit, in intent. nit = rest.
Reply:
VERDICT: APPROVE or CHANGES
S1 [blocker|should|nit] <file>:<line> <claim>. Fix: <suggestion> (stable ids)

3. Answer findings

Check each finding and severity yourself. Another path, rare case, or small cost is a nit, whatever label it came with.

  • Agree: smallest fix. Prefer delete or narrow over new lock, cache, helper, or option. Fix the case that happened. Add one focused test that fails without the fix, if intent needs it.
  • Disagree: say why, with evidence (file:line, test, output).
  • Out of scope or nit: decline in one line. List as follow-up.

Update the ledger. Re-run checks and git diff --shortstat <base>. If review grew the diff, cut first. Do not agree just to end the loop.

4. Next round

Start one only if budget remains and a blocker or should is open, behavior code changed, or approval does not cover the current behavior diff. Use a fresh delegate_task in T3 or a fresh CLI round, or follow up the saved native ID. Send the round 1 brief, the ledger (fixed: / disagree: / declined: + evidence), the same base diff, and the change since last round. Tell Sol: open ids and changed code only. Mark each old id resolved or still open: <reason>.

5. Stop and ship

Agreed: APPROVE on the current behavior diff, no blocker or should open, no concern of your own. Stuck: an item stays disputed after two replies, or budget ends. Show both sides in 2-3 lines each. The user decides. Budget end is not approval.

Do not push during the loop. Push after agreement only if the user asked to push, ship, or update the PR. If you push to a PR, add above the model blurb:

Reviewed with sol-loop: <N> rounds with <model>. Sol verdict: approved.

Add on <effort> only if verified.

Report: rounds, model, what Sol changed, diff size before/after, fixed and declined findings with reasons, usage if exposed (else say not), pushed or not. Put your own findings in the same ledger. For each finding that you did not fix, yours or Sol's, give the reason in one line.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.