agentleFS
lmagsinolmagsino/ai-light-factory/skills/verify/SKILL.md

verify

Skill1 starsChanged 45 days agoMITView on GitHub

The last stage of the AI Light Factory, after /alf:dev-loop. Proves a parent issue, milestone, feature or PR set behaves correctly where it will actually run, by driving the running app end to end (Playwright) in every feature-flag state and recording each journey as PASS, FAIL, NOT RUN or N/A with an artefact. Checks that every planned ticket has a PR and that nothing else broke. Use when a parent's or milestone's PRs are drafted, or when someone asks to verify, QA or prove a feature before merge.

188 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use instinct-export, instinct-import and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • TheKREATORSSkill

    instinct-export

    Export instincts from project/global scope to a file

    Also in 3 projects that use this

  • TheKREATORSSkill

    instinct-import

    Import instincts from file or URL into project/global scope

    Also in 3 projects that use this

  • AviadPSkill

    risk-assess

    Assess the risk and blast radius of a proposed code change before implementing it. Evaluates CI impact, framework-wide vs localized scope, rollback path, and identifies blindspots. Use when user says "what's the risk", "is this safe", "assess the impact", "risk assess", "blast radius", or before applying framework-wide or CI-affecting changes. Do NOT use for code quality review (use code-quality) or plan validation (use design-validator).

    Also in 3 projects that use this

  • diego-tobalinaSkill

    build-fix

    Fix build and compilation errors systematically. Run when build fails.

    Also in 6 projects that use this

  • AaravChadhaSkill

    secure

    Security review with a confidence gate - a finding exists only with a concrete exploit scenario and a high/medium/low confidence rating; everything else goes to a worth-hardening list, never inflated. Sweeps five surfaces: auth gates, secrets hygiene, injection and unsafe sinks, unsafe deserialization/crypto/transport, and LLM tool-use trust boundaries. Reports only, never fixes. Use when the user asks for a security review or to check vulnerabilities, secrets, or auth.

    Also in 3 projects that use this

  • ArvorCoSkill

    specify

    Create feature specification from natural language description. Use when starting a new feature or creating a spec. Triggers on: create spec, specify feature, new feature spec.

    Also in 10 projects that use this

  • +1 more from TheKREATORS

The file

We split this skill into the rules it gives an agent

4 rules. 0 are common, 3 are distinctive, and 1 is very specific to this project.

  • 0

    Common

    Most of the 167 edited versions we read keep these.

  • 3

    Distinctive

    This author's own choices. Worth a look.

  • 1

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Run them. Name every flow you did not run.

    line 26
  2. Very specific:

    Start it with commands.dev_server, and wait until commands.dev_url answers.

    line 45
  3. Distinctive:

    If there is no Playwright harness, say so.

    line 49
  4. Distinctive:

    Commit the verdict file. Comment on each PR in scope: overall verdict, its own rows, and a link to the file.

    line 74

“Common” is measured: kept by at least 6 in 10 of the 167 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Verifier: prove it works where it will run

Input: $ARGUMENTS, one of: a parent issue (#40), a milestone (milestone:NAME), a named feature, or a PR list (#57 #58 #61). The scope decides what "promised" means. Output: .factory/verdicts/YYYY-MM-DD-<scope>.md (format: ${CLAUDE_PLUGIN_ROOT}/templates/verdict.md), plus a short comment on each PR in scope linking it. Cadence: once per milestone or phase, not once per PR. Until a phase is nearly done there is usually nothing end to end to exercise, and verifying per ticket produces theatre.

Every earlier stage checks internal consistency: the code matches the ticket, the ticket matches the plan. This is the only stage that checks the world. A line without it catches bugs. A line with it also catches wrong premises, which cost an order of magnitude more. An implementation can match its spec exactly and still be wrong about the world.

There is one Verifier at a time, because it binds the app's port. Take the lock with ${CLAUDE_PLUGIN_ROOT}/bin/alf-seat acquire verifier, which also gives you a clean worktree to run the app from, and release it when you finish. If the lock is taken, wait.

Three claims, and they are not the same claim

1. It does what was promised

  • Every planned ticket has a PR. Compare tasks/plan.md and the parent's tickets (or the milestone's issues) against the PRs. A dropped ticket leaves nothing to review, so no per-PR check ever notices it. List any that are missing.
  • The milestone's outcome, driven in the running app. Drive the outcome the PRD describes, not each ticket's slice (the dev loop already checked those).

2. Nothing else broke

  • Find the flows that actually go through the changed files: search for callers, routes and jobs that reach them. Do not guess.
  • Run them. Name every flow you did not run. "Regression: passed" with no list usually means the new feature was run twice.

3. The flag makes false safe

Not "is there a kill switch", but: does OFF behave exactly as though the milestone never shipped? This is the claim nobody tests, and the one that ships incidents. On release day, almost every account is in the OFF state.

A flag paired with an account setting is two gates, not one, so the matrix has three states:

StateMust showA failure means
Flag OFFidentical to before the milestonethe change leaks past its gate. Ship-blocking
Flag ON, setting OFFstill the old behavioura call site reads the flag alone, so the whole cohort is switched on without opting in
Flag ON, setting ONthe new behaviour, in fullthe milestone did not deliver

With no setting, there are two states. Whether the setting defaults to false decides whether the middle row is a real test or N/A. Look it up; do not assume.

Toggle flags the way .factory/config.json → flags says. Platform notes are in ${CLAUDE_SKILL_DIR}/references/flags.md. Toggle only the gate under test: on some platforms "disable" also clears every targeting rule, which destroys the partial rollout you were trying to test against.

Driving the app

  • Start it with commands.dev_server, and wait until commands.dev_url answers.
  • Write the journey the PRD describes, not the code paths the diff touched. A test derived from the implementation passes on an implementation that does the wrong thing correctly, which is exactly the failure this stage exists to catch.
  • Every PASS carries an artefact: a trace, a screenshot, or a file and line. Without one, a verdict is an opinion.
  • Reference artefacts; never read them. A page, a trace and its console are the largest things in the factory, and this seat runs on the largest model. Assert against the page, record the verdict and the artefact path, and open a trace only to explain a FAIL. Send command output to files.
  • If there is no Playwright harness, say so. Report the browser legs as NOT RUN, and offer to add a minimal harness as its own ticket. Budget for it once rather than being surprised by it every milestone.

Verdicts

Make one row per journey per flag state, not one row per journey with a note about flags. No blank cells. Every pair is:

VerdictMeaning
PASSrun, and it did the thing, with the artefact
FAILrun, and it did not, with the trace and expected vs actual
NOT RUNcould not be reached, and why
N/Adoes not apply, and why

NOT RUN is a result, not a hole in the report. Silence reads as a pass. A verdict table with no NOT RUN rows on a real milestone is usually a report that stopped looking.

Read the OFF rows first. They say whether it is safe to merge; the ON rows only say whether it was worth merging. An OFF row that was not run makes the overall verdict NOT VERIFIED, however green the rest is.

Failures route back up the line

For each FAIL, decide which stage should have caught it, and say so:

  • The code is wrong (it does not behave as the plan said, and the code is the reason): goes back to the Developer as a new ticket, or a fix on the PR.
  • The plan is wrong (it behaves as planned, and the plan was wrong about the world): goes back to /mattpocock-skills:grill-with-docs, which records the correction as a new ADR. This is the expensive path, and the reason this stage exists.

Finish

Commit the verdict file. Comment on each PR in scope: overall verdict, its own rows, and a link to the file. Do not mark anything ready. The human reads the verdict and merges.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.