agentleFS
kenhuanguskenhuangus/defense-factory-skills/skills/fix-finding/SKILL.md

fix-finding

Skill2 starsChanged 47 days agoMITView on GitHub

Implements a verified-ready code or config fix for an owned finding in the Defense Factory Verified remediation phase. Use after ownership assignment; does not mark the finding verified—that requires verify-fix after deploy.

We split this skill into the rules it gives an agent

6 rules. About 0 are common, 4 are distinctive, and 2 are very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈4

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 2

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Read finding + evidence + ownership SLA.

    line 25
  2. Distinctive:

    Add or update automated tests that would fail on the old behavior when feasible.

    line 27
  3. Distinctive:

    Test commands run locally

    line 32
  4. Very specific:

    Do not claim verified_fixed from this skill.

    line 47
  5. Distinctive:

    Do not “fix” by disabling tests or hiding scanner output without addressing the issue.

    line 48
  6. Very specific:

    After deploy to the verification environment, run verify-fix.

    line 53

≈ “Common” is an estimate: at least 1 in 5 of the 308,232 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

fix-finding

Phase: Verified remediation (fix half)
Style: Blue (defensive)

When to use

  • Validated finding has an ownership assignment
  • User asks to remediate a specific finding id

Preconditions

  1. Finding status is validated or remediating.
  2. Ownership assignment exists under .defense-factory/ownership/.
  3. Authorization to modify the target repository.
  4. Clear reproduction notes from validation (so the fix addresses the proven issue).

Procedure

  1. Read finding + evidence + ownership SLA.
  2. Implement the minimal fix (code, config, dependency bump, or feature flag) that addresses root cause.
  3. Add or update automated tests that would fail on the old behavior when feasible.
  4. Open a PR or commit per project norms; record references in .defense-factory/remediation/<finding-id>.md:
    • Finding id
    • Change summary
    • PR URL / commit SHAs
    • Test commands run locally
    • Residual risk
  5. Set finding status to fixed_pending_verify (not verified_fixed).
  6. Explicitly note in the remediation doc: merged PR is not remediation complete.

Required outputs

PathNotes
Code/config changes in the target repoActual fix
.defense-factory/remediation/<finding-id>.mdRemediation record
Updated finding JSONfixed_pending_verify

Stop / refuse

  • Do not claim verified_fixed from this skill.
  • Do not “fix” by disabling tests or hiding scanner output without addressing the issue.
  • Refuse fixes that intentionally weaken security controls without documented risk acceptance in SECURITY.md.

Next phase

After deploy to the verification environment, run verify-fix.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.