rest-controller-conventions
Skill35 starsChanged 5 months agoMITView on GitHub
Use when writing hand-rolled REST controllers in Symfony (without API Platform) — routing attributes, HTTP status codes, request payload mapping, serialization groups, pagination, and versioning. Use when generating controllers, JSON endpoints, or resource routes.
In this repository16 other files it gives its agents.
- api-platform-resourcesSkill
- bundle-organizationSkill
- console-commandsSkill
- doctrine-migrationsSkill
- doctrine-ormSkill
- doctrine-query-optimizationSkill
- domain-driven-designSkill
- dto-and-validationSkill
- hexagonal-architectureSkill
- jwt-authenticationSkill
- layered-architectureSkill
- messenger-asyncSkill
- problem-details-rfc9457Skill
- security-authenticationSkill
- testing-pyramidSkill
- transactional-patternsSkill
The file
We split this skill into the rules it gives an agent
4 rules. About 0 are common, 1 is distinctive, and 3 are very specific to this project.
≈0
Common · estimate
Many files like this have a rule of this kind.
≈1
Distinctive · estimate
This author's own choices. Worth a look.
3
Very specific
Tied to their project's names, files or tools. Probably skip.
- Common
- Distinctive
- Very specific
- Very specific: line 80
Don't return 200 for everything.
- Very specific: line 84
Never serialize a Doctrine entity straight to the client without scoping.
- Very specific: line 127
No verbs in paths (/orders POST, not /createOrder).
- Distinctive: line 128
Use HTTP methods for actions.
≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.
Files
REST Controller Conventions (Symfony, no API Platform)
Controller shape
- One
finalclass per resource,#[Route]prefix on the class. - Constructor injection of services only (no repositories — see
layered-architecture). - Map the request body with
#[MapRequestPayload]and query params with#[MapQueryString]into DTOs. - Return
JsonResponsevia$this->json(...)with explicit status codes.
#[Route('/api/orders')]
final class OrderController extends AbstractController
{
public function __construct(private readonly OrderService $orders) {}
#[Route('', methods: ['GET'])]
public function list(#[MapQueryString] OrderListQuery $query): JsonResponse
{
$page = $this->orders->list($query);
return $this->json($page, context: ['groups' => ['order:read']]);
}
#[Route('/{id}', methods: ['GET'])]
public function show(Uuid $id): JsonResponse
{
return $this->json(
$this->orders->get($id),
context: ['groups' => ['order:read', 'order:detail']],
);
}
#[Route('', methods: ['POST'])]
public function create(#[MapRequestPayload] CreateOrderRequest $request): JsonResponse
{
$order = $this->orders->createOrder($request);
return $this->json(
OrderResponse::fromEntity($order),
Response::HTTP_CREATED,
['Location' => $this->generateUrl('order_show', ['id' => $order->getId()])],
['groups' => ['order:read']],
);
}
#[Route('/{id}', methods: ['DELETE'])]
public function delete(Uuid $id): JsonResponse
{
$this->orders->cancel($id);
return new JsonResponse(null, Response::HTTP_NO_CONTENT);
}
}HTTP status codes
| Situation | Status |
| Successful GET | 200 OK |
| Resource created | 201 Created + Location header |
| Accepted, processed async | 202 Accepted |
| Successful DELETE / no body | 204 No Content |
| Validation failed | 422 Unprocessable Entity |
| Malformed JSON | 400 Bad Request |
| Unauthenticated | 401 Unauthorized |
| Authenticated but forbidden | 403 Forbidden |
| Not found | 404 Not Found |
| Conflict (duplicate, version) | 409 Conflict |
Don't return 200 for everything. Map domain exceptions to status codes in an exception listener (see problem-details-rfc9457).
Serialization groups, not entity exposure
Never serialize a Doctrine entity straight to the client without scoping. Either map to a response DTO or apply #[Groups] and pass the group in the serialization context.
// On the entity / DTO
#[Groups(['order:read'])]
private string $customerEmail;
#[Groups(['order:detail'])] // only on the detail endpoint
private array $internalNotes;Request mapping & validation
#[MapRequestPayload] deserializes and validates the DTO (via the Validator). On constraint failure it throws automatically → your exception listener turns it into a 422.
public function create(#[MapRequestPayload] CreateOrderRequest $request): JsonResponseValidate query params the same way with #[MapQueryString]. See dto-and-validation.
Pagination
Return a stable envelope, never a bare array, so you can add metadata without a breaking change:
{
"data": [ ... ],
"page": 1,
"perPage": 20,
"total": 137
}return $this->json(new PaginatedResponse($items, $page, $perPage, $total), context: ['groups' => ['order:read']]);Cap perPage server-side. For deep pages, prefer keyset pagination (see doctrine-query-optimization).
Routing conventions
- Plural nouns:
/orders,/orders/{id},/orders/{id}/lines. - No verbs in paths (
/ordersPOST, not/createOrder). - Use HTTP methods for actions; reserve sub-resources for relationships.
- Constrain params:
#[Route('/{id}', requirements: ['id' => Requirement::UUID])].
Gotchas
- Agent returns
$this->json($entity)without groups — scope with#[Groups]or map to a DTO; otherwise lazy associations serialize and leak fields. - Agent returns
200for created/deleted resources — use201(+Location) and204. - Agent decodes JSON by hand (
json_decode($request->getContent())) — use#[MapRequestPayload]+ DTO. - Agent puts verbs in routes (
/getOrders,/createOrder) — use nouns + HTTP methods. - Agent returns a bare JSON array for collections — use a paginated envelope.
- Agent catches
NotFoundExceptionin the controller — let the exception listener map it to404. - Agent skips param requirements — constrain
{id}to UUID to avoid route collisions.
Does it work?
Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.
No reviews yet
People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.
- It worked
- Partly
- It didn't
Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.
Your trail
Files you open will collect here, so you can find them again.
Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.
Now do this for your own.
Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.

