agentleFS
emiliodominguezemiliodominguez/flow-skills/skills/flow-review/SKILL.md

flow-review

Skill1 starsChanged 48 days agoMITView on GitHub

Code review with evidence-backed correctness and maintainability findings. Use before shipping, on a PR, MR or diff, or when asked to review; gates belong in `flow-verify`. Routes to `flow-work`, `flow-adversarial-review` or `flow-ship`.

2 other projects use a version of this.

Adopted by

Most recently taken up by

The file

We split this skill into the rules it gives an agent

2 rules. About 0 are common, 2 are distinctive, and 0 are very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈2

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Use the supplied change request, base or commit.

    line 15
  2. Distinctive:

    Never promote PLAUSIBLE to confirmed or drop it as refuted.

    line 54

≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Review

Find defects a maintainer can act on, within the requested scope. Separate confirmed bugs from plausible risks and refuted claims.

Phase 1: Pin the change

  • Use the supplied change request, base or commit. Otherwise resolve the default branch and merge base from repository metadata; do not assume main or a remote name.
  • Review committed, staged, unstaged and relevant untracked changes as separate layers. When staged and unstaged versions diverge, inspect both: the staged one is what a commit publishes.
  • A whole-repository audit request reviews that scope instead of returning "no diff".
  • Record the inspected revision, assumptions and anything inaccessible.

Phase 2: Choose the lenses

Correctness is the baseline. Add a persona only when the change warrants it: security for trust-boundary changes, architecture for ownership/API changes, performance for hot paths, readability for maintenance risk. A small diff needs one reviewer; no fixed panel size.

For large independent surfaces, delegate bounded read-only reviewers in parallel (by persona or file shard) with one findings schema, each in its own context. Reviewers may run isolated checks but never edit the source under review. Without independent agents, state that this was a single-reviewer pass.

Findings schema

  • Location: file, symbol/line, inspected revision/layer.
  • Lens and severity: blocking | should-fix | optional.
  • Claim, and the scenario (inputs/state) that reaches a wrong outcome.
  • Evidence: reproduction, source proof, or the unresolved premise.
  • Correction: smallest useful direction, not a demanded redesign.

Drop preferences with no practical consequence unless style feedback is requested. Required formatter/linter failures are repository gates, not taste.

Phase 3: Challenge findings

Deduplicate by defect and scenario (distinct defects on one line stay separate). Try to refute each candidate with caller contracts, guards, types, tests and reachability. Types do not prove external JSON, storage, DOM or network data meets a runtime invariant. Send consequential or disputed findings, batched, to an independent verifier when available. Classify:

  • CONFIRMED: reproduced or proven reachable with a concrete wrong result.
  • PLAUSIBLE: a specific risk remains, but necessary evidence is unavailable.
  • REFUTED: a named guard, contract or reproduction disproves the scenario.

Never promote PLAUSIBLE to confirmed or drop it as refuted. Only a demonstrated blocker is a confirmed blocking defect; if uncertainty stops a required gate, report the gate as blocked.

Phase 4: Report and close

Lead with findings by severity, with file references and evidence. List checks performed, scope not checked and material uncertainty. "No findings" is valid and does not certify unrun tests. After later changes, reassess only the affected diff and invalidate stale findings. In a coordinated run, return findings to the owner; edits and retry state stay with them.

Red flags

  • "This looks wrong": trace a concrete input to a wrong result, or tag it PLAUSIBLE.
  • "The author probably handled it": find the guard or report the gap.
  • "I should find something": no findings is a valid result.
  • "Tests pass, so it's fine": check whether the tests cover the changed behavior.

Anti-patterns

  • A fixed six-persona ceremony for a small diff.
  • Reporting suspicion as proven, or hiding a plausible unresolved risk.
  • Treating no findings as deployment permission or production verification.
  • Reviewing only the working tree when the staged artifact differs.

Done when

  • The requested scope is inspected with fitting lenses and revision context.
  • Findings are deduplicated, confidence-tagged and backed by a falsifiable scenario.
  • Checks and remaining uncertainty are explicit, with no padded findings.

Route fixes to flow-work, deeper attack analysis to flow-adversarial-review, and completed review to flow-ship only within the user's delivery authorization.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.