pr-review
Skill1.5k starsChanged 3 days agoApache-2.0View on GitHub
Use when reviewing a PebbleOS pull request (number, URL or branch). Checks contribution policy first (big AI-assisted PRs, hardware proof, UX media, tests), runs a security analysis on syscall changes, then reviews the code.
195 other projects use a version of this.
Trending
More talk lately.about the whole repository
Most recently taken up by
- minio/skillstheir own version, first seen Nov 16, 2026
- lumlaolao/spike-evaltheir own version, first seen Nov 16, 2026
- AshrafDurjoy/genai-shared-patternstheir own version, first seen Nov 16, 2026
- neomjs/neo-agent-skillstheir own version, first seen Nov 15, 2026
- asarelcastellanos/claude-workbenchtheir own version, first seen Nov 15, 2026
- NVIDIA/cclustertheir own version, first seen Nov 15, 2026
Who's talking about coredevices/PebbleOS
- coredevices/mobileapp“Add in blood oxygen support into the mobile app.”GitHub · Jun 24, 2026 · 5 reactions
- pebble-dev/pebble-firmware“MenuLayer: scroll wrap around and vibes”GitHub · Dec 23, 2025 · 5 reactions
- coredevices/mobileapp“Day/night backlight color”GitHub · Jun 23, 2026 · 2 reactions
- A Hacker News story“PebbleOS”Hacker News · Jun 21, 2026 · 2 points
- matejdro/microPebble“Automatic firmware update”GitHub · Nov 15, 2025 · 2 reactions
The biggest 5 of 51 mentions linking to the repository that our crawl found. Each line is their own headline.
See all 51
Talked about on GitHub and Hacker News (51 times).
On GitHub · 50
- Jun 24, 2026Add in blood oxygen support into the mobile app. — coredevices/mobileapp5 reactions · 11 comments
- Dec 23, 2025MenuLayer: scroll wrap around and vibes — pebble-dev/pebble-firmware5 reactions · 5 comments
- Jun 23, 2026Day/night backlight color — coredevices/mobileapp2 reactions · 8 comments
- Nov 15, 2025Automatic firmware update — matejdro/microPebble2 reactions
- Jun 24, 2026Enable blood oxygen support + change values around — coredevices/pebbleos-nonfree1 reaction · 2 comments
45 more on GitHub
- Apr 26, 2026Add support for iOS Notifications Filter — coredevices/mobileapp1 reaction · 2 comments
- Jan 12, 2026notifications: iOS support for custom icon/vibe/color — coredevices/mobileapp1 reaction · 1 comment
- Nov 26, 2025Add notification icons and colors for EU neobank apps — coredevices/mobileapp1 reaction
- Nov 6, 2026Stop waiting forever for the emulator's firmware — coredevices/cloudpebble0 reactions · 2 comments
- Nov 6, 2026Stop waiting forever for the emulator's firmware — coredevices/pebble-tool0 reactions
- Oct 30, 2026Sideloading the same version of an app with the microphone permission leaves the old binary on the watch — coredevices/mobileapp0 reactions
- Oct 25, 2026Diagnostics v2: settings, "did you feel it?", stillness, last 10 sessions — nicolinux/silent-sit-pebble0 reactions
- Oct 20, 2026Button cues when in "left-handed mode" — Sykero-Software/PebbleCountdownTimer0 reactions · 1 comment
- Oct 16, 2026pebble: define the XS FFI syscalls with PBL_SYSCALL — Moddable-OpenSource/moddable0 reactions · 1 comment
- Oct 16, 2026pebble: harden the XS FFI syscall boundary — Moddable-OpenSource/moddable0 reactions · 1 comment
- Oct 16, 2026pebble: drop an unused kernel/util/sleep.h include — Moddable-OpenSource/moddable0 reactions · 2 comments
- Oct 14, 2026PebbleOS: PBLBOOTのRecovery OTA転送が通常OSの起動選択に混入する — zunda-pixel/pebble-app0 reactions
- Oct 14, 2026PebbleOS: Recovery更新前にイメージの領域サイズと整数オーバーフローを検証していない — zunda-pixel/pebble-app0 reactions
- Oct 8, 2026pebble: use struct pbl_tm for c_tm — Moddable-OpenSource/moddable0 reactions · 1 comment
- Oct 6, 2026pebble: exit the app instead of rebooting on fatal errors — Moddable-OpenSource/moddable0 reactions · 9 comments
- Oct 2, 2026pebble: handle the SpO2 health event — coredevices/moddable0 reactions
- Sep 13, 2026Implement everything as a watchapp — OpenMinimed/PebbleOS0 reactions
- Sep 13, 2026Music: add watch output device selection — coredevices/mobileapp0 reactions · 4 comments
- Sep 8, 2026bluetooth-fw/nimble: reset GATT resource counters on host restart — embedder-dev/PebbleOS0 reactions
- Sep 5, 2026Link Checker Report — nschonni/PebbleOS0 reactions
- Aug 30, 2026Voice Assistant UI improvements — skylord123/pebble-home-assistant-ws0 reactions
- Aug 25, 2026Implement Pebble companion app — zunda-pixel/pebble-app0 reactions
- Jul 31, 2026hal: keep VBAT_LDO at 3.3V to preserve RTC during hibernate — coredevices/SiFli-SDK0 reactions · 2 comments
- Jul 31, 2026Battery optimization — OpenMinimed/PebbleOS0 reactions · 4 comments
- Jul 23, 2026Update repo table — arran4/arran40 reactions
- Jul 21, 2026Update repo table — arran4/arran40 reactions
- Jul 20, 2026Update repo table — arran4/arran40 reactions
- Jul 17, 2026Update repo table — arran4/arran40 reactions
- Jul 16, 2026Update repo table — arran4/arran40 reactions
- Jul 16, 2026Show alarm — mxmehl/pebble-clean-overview0 reactions
- Jul 13, 2026Update repo table — arran4/arran40 reactions
- Jun 30, 2026Update repo table — arran4/arran40 reactions
- May 26, 2026Music App Prefs: Allow disabling priority in launcher, configure vibe strength — coredevices/mobileapp0 reactions · 3 comments
- May 19, 2026iOS find phone — coredevices/mobileapp0 reactions · 7 comments
- May 7, 2026Add Gentle vibe option to WatchPrefEntity — coredevices/mobileapp0 reactions · 1 comment
- May 3, 2026settings_quick_launch: combo hold up + down — coredevices/mobileapp0 reactions · 1 comment
- Apr 27, 2026Stop stripping patch version from package.json during build — coredevices/pebble-tool0 reactions
- Apr 26, 2026broken semver support; pebble build strips the patch version from the built .pbw — coredevices/pebble-tool0 reactions · 2 comments
- Apr 15, 2026Dockerfile missing librsvg2-bin dependency — pebble-dev/pebbleos-docker0 reactions
- Apr 15, 2026Clarify compass calibration and peek behaviour — coredevices/sdk-docs0 reactions · 1 comment
- Apr 4, 2026Add Music player settings — coredevices/mobileapp0 reactions · 1 comment
- Mar 30, 2026Allow overriding webpack config — coredevices/pebble-tool0 reactions
- Mar 13, 2026Add Hebrew (he_IL) language pack — coredevices/mobileapp0 reactions · 1 comment
- Feb 22, 2026settings_quick_launch: new combo back + up — coredevices/mobileapp0 reactions
- Feb 16, 2026fw/freertos/cm33: add PSPLIM to task context save/restore — coredevices/FreeRTOS-Kernel0 reactions
On Hacker News · 1
- Jun 21, 2026PebbleOS2 points
Used with
Projects with it also use oss-pr, pr-automation and 10 more.
Other files people use alongside this one.
Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
CES-LtdSkilloss-pr
Use when creating a pull request, after committing changes, or when user invokes /oss-pr. Covers branch management, quality checks, commit, push, and PR creation.
Also in 3 projects that use this
CES-LtdSkillpr-automation
PR Automation Orchestrator: poll open PRs, check CI, run review, fix, and merge eligible PRs. Use when: (1) Invoked by daemon via scripts/pr-automation.sh, (2) User says "/pr-automation".
Also in 3 projects that use this
jtenniswoodSkillexpert-reset
Reimagine this repository from first principles using the current product and user experience as the target. Use when the user says "/expert-reset", asks how the project should be rebuilt if starting again, wants bold architecture or component-structure recommendations, or wants a research-only reset plan unconstrained by current implementation details.
Also in 3 projects that use this
jtenniswoodSkillupdates
Summarize user-facing project updates from the last 7 days, ordered by importance and written as one-sentence "Feature: description" entries. Use when the user says "/updates", asks what changed recently, or wants a concise list of recent features, device support, fixes that users will notice, or other product value.
Also in 3 projects that use this
openchamberSkillclack-cli-patterns
Use when creating or modifying OpenChamber CLI commands, prompts, terminal output, non-TTY behavior, `--quiet`, or `--json` behavior.
Also in 3 projects that use this
openchamberSkilldrag-to-reorder
Use when implementing or modifying OpenChamber sortable or drag-to-reorder behavior, especially `@dnd-kit`, touch/mobile interactions, variable-width items, or wrapping layouts.
Also in 3 projects that use this
- +6 more from openchamber
Other versions195 projects use a version of this.
Word for word · 0
None found.
Edited · 0
None found.
Wrote their own version · 195
- Significant-Gravitas/AutoGPT★ 188ksame name
- pytorch/pytorch★ 106ksame name
- rtk-ai/rtk★ 87ksame name
- saadeghi/daisyui★ 43ksame name
- rustfs/rustfs★ 36ksame name
- dotnet/maui★ 23ksame name
- NVIDIA/Megatron-LM★ 18ksame name
- MiniMax-AI/skills★ 14ksame name
- btriapitsyn/openchamber★ 13ksame name
- openchamber/openchamber★ 13ksame name
185 more not listed
How matches are found. Word for word: the exact same text. Edited: shares passages with this file (“99% same” means 99% of its five-word phrases also appear here; 10% or more counts). Their own version: similar meaning, or, weakest, the same name. We can’t tell which project had it first. Projects are counted among the 200 most-starred candidates, and mentions are links to the repository we found, up to 50 per site, so both counts are a floor.
In this repository3 other files it gives its agents.
- AGENTS.mdAGENTS.md
- releaseSkill
- working-with-qemuSkill
The file
We split this skill into the rules it gives an agent
8 rules. 0 are common, 6 are distinctive, and 2 are very specific to this project.
0
Common
Most of the 179 edited versions we read keep these.
6
Distinctive
This author's own choices. Worth a look.
2
Very specific
Tied to their project's names, files or tools. Probably skip.
- Common
- Distinctive
- Very specific
- Distinctive: line 25
Before reading the code, decide whether the PR is big, AI-assisted and not authored by a maintainer:
- Distinctive: line 34
Check the PR and linked issues for prior agreement with a maintainer.
- Distinctive: line 36
If all three hold and there is no prior agreement, stop.
- Very specific: line 70
Run this whenever the PR adds or changes a PBL_SYSCALL/DEFINE_SYSCALL, an applib function that reaches the kernel, exported_symbols.json, …
- Very specific: line 77
Every pointer argument uses the right kind (IN/OUT/*_BUF/ *_ARRAY/STR/STRN).
- Distinctive: line 108
Check out the branch (use a git worktree.
- Distinctive: line 116
Lifecycle: every exit path (stop, app kill, disconnect, phone app death, failed transfer, timeout) releases what start acquired.
- Distinctive: line 152
Only report findings you can back with a concrete scenario: inputs or a sequence of events, and what goes wrong.
“Common” is measured: kept by at least 6 in 10 of the 179 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.
Files
Reviewing a PebbleOS pull request
The rules being enforced live in docs/community/contributing.md and
docs/development/conventions.md; read them before starting. This skill
says how to apply them, and what maintainers repeatedly catch in review.
1. Gather
gh pr view N --json number,title,author,body,labels,files,additions,deletions,commits,isDraft
gh pr diff N
gh pr view N --comments # earlier review rounds, author replies
gh api repos/coredevices/pebbleos/pulls/N/comments # inline threadsMaintainers are the owners in .github/CODEOWNERS.
2. Gate: big AI-assisted pull requests
Before reading the code, decide whether the PR is big, AI-assisted and not authored by a maintainer:
- AI-assisted: an
Assisted-by: LLMtrailer, a leftover tool trailer (Co-Authored-By: <model>), a "Generated with ..." line in the body, or the usual tells (verbose comments restating the commit message, a long templated PR body, many near-duplicate code paths). - Big: more than 1000 changed lines (ignore goldens, generated files and vendored code), or changes to multiple unrelated areas.
- Check the PR and linked issues for prior agreement with a maintainer.
If all three hold and there is no prior agreement, stop. Report the size, the AI signals and the policy line ("Big pull requests are not allowed ... unless previously agreed with the maintainers"), and ask the user whether to review anyway. Only continue if they say so.
3. Policy checks
Report each missing item; none of these needs reading the code.
- Hardware proof for low-level changes: anything matched by
pending:hw-validationin.github/labeler.yml(drivers, kernel, soc, Bluetooth, HALs, NimBLE), plus power management, flash/storage and connectivity code elsewhere. Logs, scope/logic captures or measurements from a named board. QEMU runs or "it builds" do not count. - Power impact where the change can affect it (sleep, wake-ups,
radios, timers, sensors, display refresh): numbers from a power meter or
battery logs, ideally A/B against
main. - UX media: user-visible changes carry screenshots or a video; changes to an existing screen show before and after. Check every affected shape (rect/round, colour/B&W, touch/buttons) is covered or argued irrelevant. No AI-generated images, icons or SVGs.
- Tests: new behaviour has unit tests or integration tests
(
docs/development/tests/). Test the API, not the implementation. - Commits:
area: descriptionmatchinggit logfor those files; one logical change each, bisectable; no fixups or reverts of something added in the same PR;Signed-off-bymatching the author;Assisted-by: LLMwhere AI was used and no tool/vendor names. Rungitlint --commits upstream/main..HEADon the checked-out branch. - Scope: unrelated drive-by changes split out; English only.
- Cross-repo: changes needing a phone (CoreApp) side or a submodule PR link to it; submodule SHAs point at merged commits.
4. Syscall and trust-boundary security analysis
Run this whenever the PR adds or changes a PBL_SYSCALL/DEFINE_SYSCALL,
an applib function that reaches the kernel, exported_symbols.json, or
code parsing data from the phone/BLE. Read docs/sdk/exporting.md and
include/pbl/kernel/syscall.h first.
Syscalls — assume the caller is a hostile app or watchface:
- Every pointer argument uses the right kind (
IN/OUT/*_BUF/*_ARRAY/STR/STRN); nothing is declaredVALthat is then dereferenced. Lengths and counts come from the same checked argument. - New syscalls use
PBL_SYSCALL, neverDEFINE_SYSCALL(only the ones inpebble/syscall/legacy_syscalls.txtmay). - Non-copied buffers (
*_BUF,*_ARRAY,STR) are app memory the app can change: no check-then-use on their contents (TOCTOU); copy first. - Ownership checks the kinds cannot express go in the body under
from_user: handles, sessions and IDs belong to the caller, the caller is in the foreground when that matters. - Enum and index arguments are range-checked, including values the
internal API accepts but apps must not (e.g. a new enum value placed
before
...Countsilently becoming app-reachable). - No
PBL_ASSERT/PBL_ASSERTNreachable from app input: an app must not be able to reset the watch. - Integer overflow in size arithmetic;
int16coordinate wraparound in rects/points from app memory. - Nothing kernel-private leaks back: kernel pointers, uninitialised
padding in
OUTstructs, other apps' data. - Resource exhaustion: kernel heap allocations, timers, flash writes or events an app can trigger in a loop; freed on every stop/kill path.
- Blocking, locks and flash I/O inside the body, and on which task.
- SDK side:
exported_symbols.jsonrevision bumped, declarations still C99,pending:sdk-reviewapplies.
Phone/BLE input: records, blob DB entries and protocol messages are range-checked before they reach cron, UI, persistence or array indexing; size checks alone are not enough.
5. Code review
Check out the branch (use a git worktree; the main tree may be switching branches), build the affected board and run the affected tests. Then look for what review rounds on this repo keep finding:
- Concurrency: lock-order inversions (including
bt_lock, driver mutexes),event_put()or blocking sends while holding a lock, heavy work on timer tasks, state published before it is fully set up, unlocked reads of shared state. - Lifecycle: every exit path (stop, app kill, disconnect, phone app death, failed transfer, timeout) releases what start acquired; stale callbacks/session IDs from a previous run are rejected.
- Persistence and sync: persisted or synced structs have a fixed
layout (
uint8_tnot enums/bool); migrations run once, handle default and partially customised values, and don't change semantics silently; legacy keys stay in sync in both directions with old phone apps; flash wear from frequent writes. - Compatibility: old apps (SDK revisions, legacy framebuffer sizes), old phones, older firmware peers; capability bits gate new protocol fields.
- Platforms: B&W vs colour (
PBL_COLOR/PBL_BW), round displays, rotation, touch, boards without the hardware (Kconfig capabilities, not stubs orCONFIG_BOARD_*checks). - Cost: permanently resident RAM (
.bss) for features that are rarely active, stack use on small task stacks, extra flash reads on hot paths, scans on every DB change. - Error handling:
int 0/-errnowith early return; errors mapped to the right public meaning (a transientENOMEMis not "unsupported"); retries have backoff or a cap. - Dead and duplicate code: APIs left with only test callers, unused resources, chains no longer invoked, the same gate or state machine written twice.
- Product fit: duplicates an existing setting, or a design maintainers already prefer; new settings default to the old behaviour.
- i18n: user-visible strings reachable by extraction (
pbl_i18n_noop),strncpywith translated text NUL-terminated. - Tests: catch the bug they claim to (no pass-by-construction, e.g.
swapped
memsetarguments); cover the case actually fixed, not a neighbouring one. - Style: comments short, no rationale that belongs in the commit
message, no issue references in code; naming per conventions; logging
levels per
CLAUDE.md.
6. Verify, then report
Only report findings you can back with a concrete scenario: inputs or a sequence of events, and what goes wrong. Reproduce where cheap (unit test, QEMU, a quick patch). Drop anything speculative.
Report to the user first. Post to the PR only when the user asks, and only the findings they kept: the comments are for the author, written as the user's own review. Never reply to other AI review comments or bot threads on the PR, and never post on your own pull request; there, fix the confirmed bugs instead.
- One summary line: verdict, and which findings block merging.
- Policy gaps from section 3.
- Findings ranked most severe first, each with
file:line, the scenario and a suggested fix. Mark minor onesnit:; mark issues the PR did not introduce as pre-existing. - On a re-review, go through each earlier thread and say whether it is fixed in the new head, quoting the commit SHA reviewed.
Does it work?
Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.
No reviews yet
People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.
- It worked
- Partly
- It didn't
Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.
Your trail
Files you open will collect here, so you can find them again.
Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.
Now do this for your own.
Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.

